[INFO] crate structopt-toml-derive 0.3.0 is already in cache [INFO] extracting crate structopt-toml-derive 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/structopt-toml-derive/0.3.0 [INFO] extracting crate structopt-toml-derive 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/structopt-toml-derive/0.3.0 [INFO] validating manifest of structopt-toml-derive-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of structopt-toml-derive-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing structopt-toml-derive-0.3.0 [INFO] finished frobbing structopt-toml-derive-0.3.0 [INFO] frobbed toml for structopt-toml-derive-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/structopt-toml-derive/0.3.0/Cargo.toml [INFO] started frobbing structopt-toml-derive-0.3.0 [INFO] finished frobbing structopt-toml-derive-0.3.0 [INFO] frobbed toml for structopt-toml-derive-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/structopt-toml-derive/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting structopt-toml-derive-0.3.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/structopt-toml-derive/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e27e6a113fd3e72dcb87255b97b0a01216ffe2a79a2f1174409e61443f98b4ec [INFO] running `"docker" "start" "-a" "e27e6a113fd3e72dcb87255b97b0a01216ffe2a79a2f1174409e61443f98b4ec"` [INFO] [stderr] Checking structopt-toml-derive v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:32:11 [INFO] [stderr] | [INFO] [stderr] 32 | name: &Ident, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:32:11 [INFO] [stderr] | [INFO] [stderr] 32 | name: &Ident, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | / match quote!(#path) == quote!(structopt) { [INFO] [stderr] 69 | | true => Some( [INFO] [stderr] 70 | | attr.interpret_meta() [INFO] [stderr] 71 | | .expect(&format!("invalid structopt syntax: {}", quote!(attr))) [INFO] [stderr] 72 | | ), [INFO] [stderr] 73 | | false => None, [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 68 | if quote!(#path) == quote!(structopt) { Some( [INFO] [stderr] 69 | attr.interpret_meta() [INFO] [stderr] 70 | .expect(&format!("invalid structopt syntax: {}", quote!(attr))) [INFO] [stderr] 71 | ) } else { None } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:71:26 [INFO] [stderr] | [INFO] [stderr] 71 | .expect(&format!("invalid structopt syntax: {}", quote!(attr))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("invalid structopt syntax: {}", quote!(attr)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:85:61 [INFO] [stderr] | [INFO] [stderr] 85 | let mut structopt_name = LitStr::new(&format!("{}", field.ident.unwrap().clone()), field.ident.unwrap().span); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `field.ident.unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | / match attr { [INFO] [stderr] 88 | | NameValue(MetaNameValue { ident, lit: Str(value), .. }) => { [INFO] [stderr] 89 | | if ident == "name" { [INFO] [stderr] 90 | | structopt_name = value; [INFO] [stderr] ... | [INFO] [stderr] 93 | | _ => () [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 87 | if let NameValue(MetaNameValue { ident, lit: Str(value), .. }) = attr { [INFO] [stderr] 88 | if ident == "name" { [INFO] [stderr] 89 | structopt_name = value; [INFO] [stderr] 90 | } [INFO] [stderr] 91 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | / match quote!(#path) == quote!(structopt) { [INFO] [stderr] 69 | | true => Some( [INFO] [stderr] 70 | | attr.interpret_meta() [INFO] [stderr] 71 | | .expect(&format!("invalid structopt syntax: {}", quote!(attr))) [INFO] [stderr] 72 | | ), [INFO] [stderr] 73 | | false => None, [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 68 | if quote!(#path) == quote!(structopt) { Some( [INFO] [stderr] 69 | attr.interpret_meta() [INFO] [stderr] 70 | .expect(&format!("invalid structopt syntax: {}", quote!(attr))) [INFO] [stderr] 71 | ) } else { None } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:71:26 [INFO] [stderr] | [INFO] [stderr] 71 | .expect(&format!("invalid structopt syntax: {}", quote!(attr))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("invalid structopt syntax: {}", quote!(attr)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:85:61 [INFO] [stderr] | [INFO] [stderr] 85 | let mut structopt_name = LitStr::new(&format!("{}", field.ident.unwrap().clone()), field.ident.unwrap().span); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `field.ident.unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | / match attr { [INFO] [stderr] 88 | | NameValue(MetaNameValue { ident, lit: Str(value), .. }) => { [INFO] [stderr] 89 | | if ident == "name" { [INFO] [stderr] 90 | | structopt_name = value; [INFO] [stderr] ... | [INFO] [stderr] 93 | | _ => () [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 87 | if let NameValue(MetaNameValue { ident, lit: Str(value), .. }) = attr { [INFO] [stderr] 88 | if ident == "name" { [INFO] [stderr] 89 | structopt_name = value; [INFO] [stderr] 90 | } [INFO] [stderr] 91 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.72s [INFO] running `"docker" "inspect" "e27e6a113fd3e72dcb87255b97b0a01216ffe2a79a2f1174409e61443f98b4ec"` [INFO] running `"docker" "rm" "-f" "e27e6a113fd3e72dcb87255b97b0a01216ffe2a79a2f1174409e61443f98b4ec"` [INFO] [stdout] e27e6a113fd3e72dcb87255b97b0a01216ffe2a79a2f1174409e61443f98b4ec