[INFO] crate stripper_interface 0.0.6 is already in cache [INFO] extracting crate stripper_interface 0.0.6 into work/ex/clippy-test-run/sources/stable/reg/stripper_interface/0.0.6 [INFO] extracting crate stripper_interface 0.0.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stripper_interface/0.0.6 [INFO] validating manifest of stripper_interface-0.0.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stripper_interface-0.0.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stripper_interface-0.0.6 [INFO] finished frobbing stripper_interface-0.0.6 [INFO] frobbed toml for stripper_interface-0.0.6 written to work/ex/clippy-test-run/sources/stable/reg/stripper_interface/0.0.6/Cargo.toml [INFO] started frobbing stripper_interface-0.0.6 [INFO] finished frobbing stripper_interface-0.0.6 [INFO] frobbed toml for stripper_interface-0.0.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stripper_interface/0.0.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stripper_interface-0.0.6 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stripper_interface/0.0.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e5ea79086923f1ee7ffa72ce504b4b5aa059adf2a51285e3a850c92af0c5c5f7 [INFO] running `"docker" "start" "-a" "e5ea79086923f1ee7ffa72ce504b4b5aa059adf2a51285e3a850c92af0c5c5f7"` [INFO] [stderr] Checking stripper_interface v0.0.6 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/consts.rs:15:26 [INFO] [stderr] | [INFO] [stderr] 15 | pub const MOD_COMMENT : &'static str = " src/consts.rs:16:27 [INFO] [stderr] | [INFO] [stderr] 16 | pub const FILE_COMMENT : &'static str = " src/consts.rs:17:19 [INFO] [stderr] | [INFO] [stderr] 17 | pub const FILE : &'static str = " src/consts.rs:18:23 [INFO] [stderr] | [INFO] [stderr] 18 | pub const END_INFO : &'static str = " -->"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/consts.rs:15:26 [INFO] [stderr] | [INFO] [stderr] 15 | pub const MOD_COMMENT : &'static str = " src/consts.rs:16:27 [INFO] [stderr] | [INFO] [stderr] 16 | pub const FILE_COMMENT : &'static str = " src/consts.rs:17:19 [INFO] [stderr] | [INFO] [stderr] 17 | pub const FILE : &'static str = " src/consts.rs:18:23 [INFO] [stderr] | [INFO] [stderr] 18 | pub const END_INFO : &'static str = " -->"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / match self { [INFO] [stderr] 31 | | &EventType::Type(ref t) => writeln!(fmt, "{}", t), [INFO] [stderr] 32 | | _ => Ok(()) [INFO] [stderr] 33 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 30 | match *self { [INFO] [stderr] 31 | EventType::Type(ref t) => writeln!(fmt, "{}", t), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | / match ty { [INFO] [stderr] 75 | | &Some(ref t) => { [INFO] [stderr] 76 | | if ignore_macros && is_parent && t.ty == Type::Macro { [INFO] [stderr] 77 | | recur(&t.parent, true, ignore_macros) [INFO] [stderr] ... | [INFO] [stderr] 82 | | _ => 0, [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 74 | match *ty { [INFO] [stderr] 75 | Some(ref t) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/types.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | / fn ne(&self, other: &TypeStruct) -> bool { [INFO] [stderr] 98 | | !self.eq(other) [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | / match parent { [INFO] [stderr] 130 | | &Some(ref p) => write!(f, "{:?}§{} {}{}", p, self.ty, self.name, self.args.join(" ")), [INFO] [stderr] 131 | | _ => write!(f, "{} {}{}", self.ty, self.name, self.args.join(" ")), [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 129 | match *parent { [INFO] [stderr] 130 | Some(ref p) => write!(f, "{:?}§{} {}{}", p, self.ty, self.name, self.args.join(" ")), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/types.rs:145:31 [INFO] [stderr] | [INFO] [stderr] 145 | if t.ty == Type::Macro && is_parent == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `is_parent` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / match self { [INFO] [stderr] 31 | | &EventType::Type(ref t) => writeln!(fmt, "{}", t), [INFO] [stderr] 32 | | _ => Ok(()) [INFO] [stderr] 33 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 30 | match *self { [INFO] [stderr] 31 | EventType::Type(ref t) => writeln!(fmt, "{}", t), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | / match ty { [INFO] [stderr] 75 | | &Some(ref t) => { [INFO] [stderr] 76 | | if ignore_macros && is_parent && t.ty == Type::Macro { [INFO] [stderr] 77 | | recur(&t.parent, true, ignore_macros) [INFO] [stderr] ... | [INFO] [stderr] 82 | | _ => 0, [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 74 | match *ty { [INFO] [stderr] 75 | Some(ref t) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/types.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | / fn ne(&self, other: &TypeStruct) -> bool { [INFO] [stderr] 98 | | !self.eq(other) [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | / match parent { [INFO] [stderr] 130 | | &Some(ref p) => write!(f, "{:?}§{} {}{}", p, self.ty, self.name, self.args.join(" ")), [INFO] [stderr] 131 | | _ => write!(f, "{} {}{}", self.ty, self.name, self.args.join(" ")), [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 129 | match *parent { [INFO] [stderr] 130 | Some(ref p) => write!(f, "{:?}§{} {}{}", p, self.ty, self.name, self.args.join(" ")), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/types.rs:145:31 [INFO] [stderr] | [INFO] [stderr] 145 | if t.ty == Type::Macro && is_parent == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `is_parent` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.46s [INFO] running `"docker" "inspect" "e5ea79086923f1ee7ffa72ce504b4b5aa059adf2a51285e3a850c92af0c5c5f7"` [INFO] running `"docker" "rm" "-f" "e5ea79086923f1ee7ffa72ce504b4b5aa059adf2a51285e3a850c92af0c5c5f7"` [INFO] [stdout] e5ea79086923f1ee7ffa72ce504b4b5aa059adf2a51285e3a850c92af0c5c5f7