[INFO] crate stringsort 2.0.0 is already in cache
[INFO] extracting crate stringsort 2.0.0 into work/ex/clippy-test-run/sources/stable/reg/stringsort/2.0.0
[INFO] extracting crate stringsort 2.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stringsort/2.0.0
[INFO] validating manifest of stringsort-2.0.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of stringsort-2.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing stringsort-2.0.0
[INFO] finished frobbing stringsort-2.0.0
[INFO] frobbed toml for stringsort-2.0.0 written to work/ex/clippy-test-run/sources/stable/reg/stringsort/2.0.0/Cargo.toml
[INFO] started frobbing stringsort-2.0.0
[INFO] finished frobbing stringsort-2.0.0
[INFO] frobbed toml for stringsort-2.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stringsort/2.0.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting stringsort-2.0.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stringsort/2.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0e58ce485ae1b070337350cdb72f376cf899f7e0fca65a6199533951cdb25131
[INFO] running `"docker" "start" "-a" "0e58ce485ae1b070337350cdb72f376cf899f7e0fca65a6199533951cdb25131"`
[INFO] [stderr]     Checking stringsort v2.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]  --> src/lib.rs:7:18
[INFO] [stderr]   |
[INFO] [stderr] 7 |     let mut si = s.chars().into_iter();
[INFO] [stderr]   |                  ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `s.chars()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/lib.rs:12:26
[INFO] [stderr]    |
[INFO] [stderr] 12 |     while let Some(ch) = si.next() {
[INFO] [stderr]    |                          ^^^^^^^^^ help: try: `for ch in si { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher': use `std::collections::hash_map::DefaultHasher` instead
[INFO] [stderr]    --> src/lib.rs:116:9
[INFO] [stderr]     |
[INFO] [stderr] 116 |     use std::hash::SipHasher;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher': use `std::collections::hash_map::DefaultHasher` instead
[INFO] [stderr]    --> src/lib.rs:130:57
[INFO] [stderr]     |
[INFO] [stderr] 130 |         let (count, countdur) = teststr1(s, countsort::<SipHasher>);
[INFO] [stderr]     |                                                         ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/lib.rs:40:20
[INFO] [stderr]    |
[INFO] [stderr] 40 |     let mut keys = buckets.keys().map(|&k| k).collect::<Vec<_>>();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `buckets.keys().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]  --> src/lib.rs:7:18
[INFO] [stderr]   |
[INFO] [stderr] 7 |     let mut si = s.chars().into_iter();
[INFO] [stderr]   |                  ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `s.chars()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/lib.rs:12:26
[INFO] [stderr]    |
[INFO] [stderr] 12 |     while let Some(ch) = si.next() {
[INFO] [stderr]    |                          ^^^^^^^^^ help: try: `for ch in si { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/lib.rs:40:20
[INFO] [stderr]    |
[INFO] [stderr] 40 |     let mut keys = buckets.keys().map(|&k| k).collect::<Vec<_>>();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `buckets.keys().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.46s
[INFO] running `"docker" "inspect" "0e58ce485ae1b070337350cdb72f376cf899f7e0fca65a6199533951cdb25131"`
[INFO] running `"docker" "rm" "-f" "0e58ce485ae1b070337350cdb72f376cf899f7e0fca65a6199533951cdb25131"`
[INFO] [stdout] 0e58ce485ae1b070337350cdb72f376cf899f7e0fca65a6199533951cdb25131