[INFO] crate stringprep 0.1.2 is already in cache [INFO] extracting crate stringprep 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/stringprep/0.1.2 [INFO] extracting crate stringprep 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stringprep/0.1.2 [INFO] validating manifest of stringprep-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stringprep-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stringprep-0.1.2 [INFO] finished frobbing stringprep-0.1.2 [INFO] frobbed toml for stringprep-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/stringprep/0.1.2/Cargo.toml [INFO] started frobbing stringprep-0.1.2 [INFO] finished frobbing stringprep-0.1.2 [INFO] frobbed toml for stringprep-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stringprep/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stringprep-0.1.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stringprep/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 945ea036c78738ebda8b0dade9fb71181a5c4a2ebc56db9f858e8454efe0a8f1 [INFO] running `"docker" "start" "-a" "945ea036c78738ebda8b0dade9fb71181a5c4a2ebc56db9f858e8454efe0a8f1"` [INFO] [stderr] Checking stringprep v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rfc3454.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | pub const A_1: &'static [(char, char)] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[(char, char)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rfc3454.rs:402:17 [INFO] [stderr] | [INFO] [stderr] 402 | pub const B_2: &'static [(char, &'static str)] = &[ [INFO] [stderr] | -^^^^^^^----------------------- help: consider removing `'static`: `&[(char, &'static str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rfc3454.rs:402:34 [INFO] [stderr] | [INFO] [stderr] 402 | pub const B_2: &'static [(char, &'static str)] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/lib.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rfc3454.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | pub const A_1: &'static [(char, char)] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[(char, char)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rfc3454.rs:402:17 [INFO] [stderr] | [INFO] [stderr] 402 | pub const B_2: &'static [(char, &'static str)] = &[ [INFO] [stderr] | -^^^^^^^----------------------- help: consider removing `'static`: `&[(char, &'static str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rfc3454.rs:402:34 [INFO] [stderr] | [INFO] [stderr] 402 | pub const B_2: &'static [(char, &'static str)] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/lib.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/lib.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/lib.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn saslprep<'a>(s: &'a str) -> Result, Error> { [INFO] [stderr] 52 | | // fast path for ascii text [INFO] [stderr] 53 | | if s.chars() [INFO] [stderr] 54 | | .all(|c| c.is_ascii() && !tables::ascii_control_character(c)) { [INFO] [stderr] ... | [INFO] [stderr] 102 | | Ok(Cow::Owned(normalized)) [INFO] [stderr] 103 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:131:1 [INFO] [stderr] | [INFO] [stderr] 131 | / pub fn nameprep<'a>(s: &'a str) -> Result, Error> { [INFO] [stderr] 132 | | // 3. Mapping [INFO] [stderr] 133 | | let mapped = s.chars() [INFO] [stderr] 134 | | .filter(|&c| !tables::commonly_mapped_to_nothing(c)) [INFO] [stderr] ... | [INFO] [stderr] 171 | | Ok(Cow::Owned(normalized)) [INFO] [stderr] 172 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:179:1 [INFO] [stderr] | [INFO] [stderr] 179 | / pub fn nodeprep<'a>(s: &'a str) -> Result, Error> { [INFO] [stderr] 180 | | // A.3. Mapping [INFO] [stderr] 181 | | let mapped = s.chars() [INFO] [stderr] 182 | | .filter(|&c| !tables::commonly_mapped_to_nothing(c)) [INFO] [stderr] ... | [INFO] [stderr] 221 | | Ok(Cow::Owned(normalized)) [INFO] [stderr] 222 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:237:1 [INFO] [stderr] | [INFO] [stderr] 237 | / pub fn resourceprep<'a>(s: &'a str) -> Result, Error> { [INFO] [stderr] 238 | | // B.3. Mapping [INFO] [stderr] 239 | | let mapped = s.chars() [INFO] [stderr] 240 | | .filter(|&c| !tables::commonly_mapped_to_nothing(c)) [INFO] [stderr] ... | [INFO] [stderr] 277 | | Ok(Cow::Owned(normalized)) [INFO] [stderr] 278 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn saslprep<'a>(s: &'a str) -> Result, Error> { [INFO] [stderr] 52 | | // fast path for ascii text [INFO] [stderr] 53 | | if s.chars() [INFO] [stderr] 54 | | .all(|c| c.is_ascii() && !tables::ascii_control_character(c)) { [INFO] [stderr] ... | [INFO] [stderr] 102 | | Ok(Cow::Owned(normalized)) [INFO] [stderr] 103 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:131:1 [INFO] [stderr] | [INFO] [stderr] 131 | / pub fn nameprep<'a>(s: &'a str) -> Result, Error> { [INFO] [stderr] 132 | | // 3. Mapping [INFO] [stderr] 133 | | let mapped = s.chars() [INFO] [stderr] 134 | | .filter(|&c| !tables::commonly_mapped_to_nothing(c)) [INFO] [stderr] ... | [INFO] [stderr] 171 | | Ok(Cow::Owned(normalized)) [INFO] [stderr] 172 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:179:1 [INFO] [stderr] | [INFO] [stderr] 179 | / pub fn nodeprep<'a>(s: &'a str) -> Result, Error> { [INFO] [stderr] 180 | | // A.3. Mapping [INFO] [stderr] 181 | | let mapped = s.chars() [INFO] [stderr] 182 | | .filter(|&c| !tables::commonly_mapped_to_nothing(c)) [INFO] [stderr] ... | [INFO] [stderr] 221 | | Ok(Cow::Owned(normalized)) [INFO] [stderr] 222 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:237:1 [INFO] [stderr] | [INFO] [stderr] 237 | / pub fn resourceprep<'a>(s: &'a str) -> Result, Error> { [INFO] [stderr] 238 | | // B.3. Mapping [INFO] [stderr] 239 | | let mapped = s.chars() [INFO] [stderr] 240 | | .filter(|&c| !tables::commonly_mapped_to_nothing(c)) [INFO] [stderr] ... | [INFO] [stderr] 277 | | Ok(Cow::Owned(normalized)) [INFO] [stderr] 278 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> tests/nameprep_tests.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | assert_eq!(input.clone(), nameprep(input).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 98 | assert_eq!(&(*input).clone(), nameprep(input).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 98 | assert_eq!(&str::clone(input), nameprep(input).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `stringprep`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "945ea036c78738ebda8b0dade9fb71181a5c4a2ebc56db9f858e8454efe0a8f1"` [INFO] running `"docker" "rm" "-f" "945ea036c78738ebda8b0dade9fb71181a5c4a2ebc56db9f858e8454efe0a8f1"` [INFO] [stdout] 945ea036c78738ebda8b0dade9fb71181a5c4a2ebc56db9f858e8454efe0a8f1