[INFO] crate steamy-vdf 0.2.0 is already in cache [INFO] extracting crate steamy-vdf 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/steamy-vdf/0.2.0 [INFO] extracting crate steamy-vdf 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/steamy-vdf/0.2.0 [INFO] validating manifest of steamy-vdf-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of steamy-vdf-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing steamy-vdf-0.2.0 [INFO] finished frobbing steamy-vdf-0.2.0 [INFO] frobbed toml for steamy-vdf-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/steamy-vdf/0.2.0/Cargo.toml [INFO] started frobbing steamy-vdf-0.2.0 [INFO] finished frobbing steamy-vdf-0.2.0 [INFO] frobbed toml for steamy-vdf-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/steamy-vdf/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting steamy-vdf-0.2.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/steamy-vdf/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2cccddd994db18e0b7568e6c5ce04a0efd53202be5b5bc40772399bcd04951ef [INFO] running `"docker" "start" "-a" "2cccddd994db18e0b7568e6c5ce04a0efd53202be5b5bc40772399bcd04951ef"` [INFO] [stderr] Checking steamy-vdf v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entry/table.rs:53:3 [INFO] [stderr] | [INFO] [stderr] 53 | return Ok(Table(map)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Table(map))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/entry/table.rs:53:3 [INFO] [stderr] | [INFO] [stderr] 53 | return Ok(Table(map)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Table(map))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 27 | | &Error::Io(ref err) => [INFO] [stderr] 28 | | err.description(), [INFO] [stderr] 29 | | [INFO] [stderr] ... | [INFO] [stderr] 34 | | "EOF reached.", [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 26 | match *self { [INFO] [stderr] 27 | Error::Io(ref err) => [INFO] [stderr] 28 | err.description(), [INFO] [stderr] 29 | [INFO] [stderr] 30 | Error::Parse => [INFO] [stderr] 31 | "Parsing error.", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/reader.rs:31:3 [INFO] [stderr] | [INFO] [stderr] 31 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 32 | | &Item::Statement(ref v) => [INFO] [stderr] 33 | | v, [INFO] [stderr] 34 | | [INFO] [stderr] 35 | | &Item::Value(ref v) => [INFO] [stderr] 36 | | v, [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | match *self { [INFO] [stderr] 32 | Item::Statement(ref v) => [INFO] [stderr] 33 | v, [INFO] [stderr] 34 | [INFO] [stderr] 35 | Item::Value(ref v) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/entry/mod.rs:38:3 [INFO] [stderr] | [INFO] [stderr] 38 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 39 | | &Entry::Table(ref value) => [INFO] [stderr] 40 | | value.get(name.as_ref()), [INFO] [stderr] 41 | | [INFO] [stderr] ... | [INFO] [stderr] 46 | | None [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 38 | match *self { [INFO] [stderr] 39 | Entry::Table(ref value) => [INFO] [stderr] 40 | value.get(name.as_ref()), [INFO] [stderr] 41 | [INFO] [stderr] 42 | Entry::Array(ref value) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/entry/mod.rs:52:3 [INFO] [stderr] | [INFO] [stderr] 52 | if let &Entry::Value(ref value) = self { [INFO] [stderr] | _________^ [INFO] [stderr] 53 | | value.to::() [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | else { [INFO] [stderr] 56 | | None [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 52 | if let Entry::Value(ref value) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/entry/mod.rs:62:3 [INFO] [stderr] | [INFO] [stderr] 62 | if let &Entry::Table(ref value) = self { [INFO] [stderr] | _________^ [INFO] [stderr] 63 | | Some(value) [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | else { [INFO] [stderr] 66 | | None [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 62 | if let Entry::Table(ref value) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/entry/mod.rs:72:3 [INFO] [stderr] | [INFO] [stderr] 72 | if let &Entry::Array(ref value) = self { [INFO] [stderr] | _________^ [INFO] [stderr] 73 | | Some(value.as_slice()) [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | else { [INFO] [stderr] ... | [INFO] [stderr] 78 | | } [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 72 | if let Entry::Array(ref value) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/entry/mod.rs:84:3 [INFO] [stderr] | [INFO] [stderr] 84 | if let &Entry::Statement(ref value) = self { [INFO] [stderr] | _________^ [INFO] [stderr] 85 | | Some(value) [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | else { [INFO] [stderr] 88 | | None [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 84 | if let Entry::Statement(ref value) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/entry/mod.rs:94:3 [INFO] [stderr] | [INFO] [stderr] 94 | if let &Entry::Value(ref value) = self { [INFO] [stderr] | _________^ [INFO] [stderr] 95 | | Some(value) [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | else { [INFO] [stderr] 98 | | None [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 94 | if let Entry::Value(ref value) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/entry/mod.rs:104:3 [INFO] [stderr] | [INFO] [stderr] 104 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 105 | | &Entry::Value(ref value) => [INFO] [stderr] 106 | | Some(&*value), [INFO] [stderr] 107 | | [INFO] [stderr] ... | [INFO] [stderr] 112 | | None [INFO] [stderr] 113 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 104 | match *self { [INFO] [stderr] 105 | Entry::Value(ref value) => [INFO] [stderr] 106 | Some(&*value), [INFO] [stderr] 107 | [INFO] [stderr] 108 | Entry::Statement(ref value) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/entry/table.rs:13:2 [INFO] [stderr] | [INFO] [stderr] 13 | if !map.contains_key(&key) { [INFO] [stderr] | _____^ [INFO] [stderr] 14 | | map.insert(key, value); [INFO] [stderr] 15 | | return; [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ help: consider using: `map.entry(key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:70:23 [INFO] [stderr] | [INFO] [stderr] 70 | |v| { string(v).map(|v| Token::Statement(v)) })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Token::Statement` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:74:23 [INFO] [stderr] | [INFO] [stderr] 74 | |v| { string(v).map(|v| Token::Item(v)) })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Token::Item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:84:23 [INFO] [stderr] | [INFO] [stderr] 84 | |v| { string(v).map(|v| Token::Statement(v)) })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Token::Statement` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:88:23 [INFO] [stderr] | [INFO] [stderr] 88 | |v| { string(v).map(|v| Token::Item(v)) })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Token::Item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 27 | | &Error::Io(ref err) => [INFO] [stderr] 28 | | err.description(), [INFO] [stderr] 29 | | [INFO] [stderr] ... | [INFO] [stderr] 34 | | "EOF reached.", [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 26 | match *self { [INFO] [stderr] 27 | Error::Io(ref err) => [INFO] [stderr] 28 | err.description(), [INFO] [stderr] 29 | [INFO] [stderr] 30 | Error::Parse => [INFO] [stderr] 31 | "Parsing error.", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/reader.rs:31:3 [INFO] [stderr] | [INFO] [stderr] 31 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 32 | | &Item::Statement(ref v) => [INFO] [stderr] 33 | | v, [INFO] [stderr] 34 | | [INFO] [stderr] 35 | | &Item::Value(ref v) => [INFO] [stderr] 36 | | v, [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | match *self { [INFO] [stderr] 32 | Item::Statement(ref v) => [INFO] [stderr] 33 | v, [INFO] [stderr] 34 | [INFO] [stderr] 35 | Item::Value(ref v) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/entry/mod.rs:38:3 [INFO] [stderr] | [INFO] [stderr] 38 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 39 | | &Entry::Table(ref value) => [INFO] [stderr] 40 | | value.get(name.as_ref()), [INFO] [stderr] 41 | | [INFO] [stderr] ... | [INFO] [stderr] 46 | | None [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 38 | match *self { [INFO] [stderr] 39 | Entry::Table(ref value) => [INFO] [stderr] 40 | value.get(name.as_ref()), [INFO] [stderr] 41 | [INFO] [stderr] 42 | Entry::Array(ref value) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/entry/mod.rs:52:3 [INFO] [stderr] | [INFO] [stderr] 52 | if let &Entry::Value(ref value) = self { [INFO] [stderr] | _________^ [INFO] [stderr] 53 | | value.to::() [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | else { [INFO] [stderr] 56 | | None [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 52 | if let Entry::Value(ref value) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/entry/mod.rs:62:3 [INFO] [stderr] | [INFO] [stderr] 62 | if let &Entry::Table(ref value) = self { [INFO] [stderr] | _________^ [INFO] [stderr] 63 | | Some(value) [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | else { [INFO] [stderr] 66 | | None [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 62 | if let Entry::Table(ref value) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/entry/mod.rs:72:3 [INFO] [stderr] | [INFO] [stderr] 72 | if let &Entry::Array(ref value) = self { [INFO] [stderr] | _________^ [INFO] [stderr] 73 | | Some(value.as_slice()) [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | else { [INFO] [stderr] ... | [INFO] [stderr] 78 | | } [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 72 | if let Entry::Array(ref value) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/entry/mod.rs:84:3 [INFO] [stderr] | [INFO] [stderr] 84 | if let &Entry::Statement(ref value) = self { [INFO] [stderr] | _________^ [INFO] [stderr] 85 | | Some(value) [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | else { [INFO] [stderr] 88 | | None [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 84 | if let Entry::Statement(ref value) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/entry/mod.rs:94:3 [INFO] [stderr] | [INFO] [stderr] 94 | if let &Entry::Value(ref value) = self { [INFO] [stderr] | _________^ [INFO] [stderr] 95 | | Some(value) [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | else { [INFO] [stderr] 98 | | None [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 94 | if let Entry::Value(ref value) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/entry/mod.rs:104:3 [INFO] [stderr] | [INFO] [stderr] 104 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 105 | | &Entry::Value(ref value) => [INFO] [stderr] 106 | | Some(&*value), [INFO] [stderr] 107 | | [INFO] [stderr] ... | [INFO] [stderr] 112 | | None [INFO] [stderr] 113 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 104 | match *self { [INFO] [stderr] 105 | Entry::Value(ref value) => [INFO] [stderr] 106 | Some(&*value), [INFO] [stderr] 107 | [INFO] [stderr] 108 | Entry::Statement(ref value) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/entry/table.rs:13:2 [INFO] [stderr] | [INFO] [stderr] 13 | if !map.contains_key(&key) { [INFO] [stderr] | _____^ [INFO] [stderr] 14 | | map.insert(key, value); [INFO] [stderr] 15 | | return; [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ help: consider using: `map.entry(key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:70:23 [INFO] [stderr] | [INFO] [stderr] 70 | |v| { string(v).map(|v| Token::Statement(v)) })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Token::Statement` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:74:23 [INFO] [stderr] | [INFO] [stderr] 74 | |v| { string(v).map(|v| Token::Item(v)) })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Token::Item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:84:23 [INFO] [stderr] | [INFO] [stderr] 84 | |v| { string(v).map(|v| Token::Statement(v)) })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Token::Statement` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:88:23 [INFO] [stderr] | [INFO] [stderr] 88 | |v| { string(v).map(|v| Token::Item(v)) })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Token::Item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/lib.rs:7:2 [INFO] [stderr] | [INFO] [stderr] 7 | assert_eq!(2.0, [INFO] [stderr] | _____^ [INFO] [stderr] 8 | | config.lookup("controller_mappings.version").unwrap() [INFO] [stderr] 9 | | .to::().unwrap()); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/lib.rs:7:2 [INFO] [stderr] | [INFO] [stderr] 7 | assert_eq!(2.0, [INFO] [stderr] | _____^ [INFO] [stderr] 8 | | config.lookup("controller_mappings.version").unwrap() [INFO] [stderr] 9 | | .to::().unwrap()); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `steamy-vdf`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2cccddd994db18e0b7568e6c5ce04a0efd53202be5b5bc40772399bcd04951ef"` [INFO] running `"docker" "rm" "-f" "2cccddd994db18e0b7568e6c5ce04a0efd53202be5b5bc40772399bcd04951ef"` [INFO] [stdout] 2cccddd994db18e0b7568e6c5ce04a0efd53202be5b5bc40772399bcd04951ef