[INFO] crate stator 0.1.1 is already in cache [INFO] extracting crate stator 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/stator/0.1.1 [INFO] extracting crate stator 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stator/0.1.1 [INFO] validating manifest of stator-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stator-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stator-0.1.1 [INFO] finished frobbing stator-0.1.1 [INFO] frobbed toml for stator-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/stator/0.1.1/Cargo.toml [INFO] started frobbing stator-0.1.1 [INFO] finished frobbing stator-0.1.1 [INFO] frobbed toml for stator-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stator/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stator-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/stator/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d82b08172541d58e437991d22bbb9a9479e2426cb25d5ab9e4b43f8247bd950d [INFO] running `"docker" "start" "-a" "d82b08172541d58e437991d22bbb9a9479e2426cb25d5ab9e4b43f8247bd950d"` [INFO] [stderr] Checking stator v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:81:21 [INFO] [stderr] | [INFO] [stderr] 81 | state_handlers: HashMap>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/lib.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / if self.state_handlers.contains_key(&key) [INFO] [stderr] 98 | | { [INFO] [stderr] 99 | | self.state_handlers.get_mut(&key).unwrap().push(Box::new(f)); [INFO] [stderr] 100 | | }else [INFO] [stderr] 101 | | { [INFO] [stderr] 102 | | self.state_handlers.insert(key, vec![Box::new(f)]); [INFO] [stderr] 103 | | } [INFO] [stderr] | |_________^ help: consider using: `self.state_handlers.entry(key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: unused variable: `from` [INFO] [stderr] --> src/lib.rs:30:50 [INFO] [stderr] | [INFO] [stderr] 30 | state.add_handler(States::a(), States::b(), |from: &String| [INFO] [stderr] | ^^^^ help: consider using `_from` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `from` [INFO] [stderr] --> src/lib.rs:36:58 [INFO] [stderr] | [INFO] [stderr] 36 | state.add_handler(Stator::any_state(), States::b(), |from: &String| [INFO] [stderr] | ^^^^ help: consider using `_from` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `from` [INFO] [stderr] --> src/lib.rs:42:58 [INFO] [stderr] | [INFO] [stderr] 42 | state.add_handler(States::a(), Stator::any_state(), |from: &String| [INFO] [stderr] | ^^^^ help: consider using `_from` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `from` [INFO] [stderr] --> src/lib.rs:48:58 [INFO] [stderr] | [INFO] [stderr] 48 | state.add_handler(Stator::any_state(), States::a(), |from: &String| [INFO] [stderr] | ^^^^ help: consider using `_from` instead [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:81:21 [INFO] [stderr] | [INFO] [stderr] 81 | state_handlers: HashMap>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/lib.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / if self.state_handlers.contains_key(&key) [INFO] [stderr] 98 | | { [INFO] [stderr] 99 | | self.state_handlers.get_mut(&key).unwrap().push(Box::new(f)); [INFO] [stderr] 100 | | }else [INFO] [stderr] 101 | | { [INFO] [stderr] 102 | | self.state_handlers.insert(key, vec![Box::new(f)]); [INFO] [stderr] 103 | | } [INFO] [stderr] | |_________^ help: consider using: `self.state_handlers.entry(key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.53s [INFO] running `"docker" "inspect" "d82b08172541d58e437991d22bbb9a9479e2426cb25d5ab9e4b43f8247bd950d"` [INFO] running `"docker" "rm" "-f" "d82b08172541d58e437991d22bbb9a9479e2426cb25d5ab9e4b43f8247bd950d"` [INFO] [stdout] d82b08172541d58e437991d22bbb9a9479e2426cb25d5ab9e4b43f8247bd950d