[INFO] crate state 0.4.1 is already in cache [INFO] extracting crate state 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/state/0.4.1 [INFO] extracting crate state 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/state/0.4.1 [INFO] validating manifest of state-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of state-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing state-0.4.1 [INFO] finished frobbing state-0.4.1 [INFO] frobbed toml for state-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/state/0.4.1/Cargo.toml [INFO] started frobbing state-0.4.1 [INFO] finished frobbing state-0.4.1 [INFO] frobbed toml for state-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/state/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting state-0.4.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/state/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3f6a55053d59107a3b5a02ecc8450c8ff7ebe29d5763c7b2a3a0f5303d790fd3 [INFO] running `"docker" "start" "-a" "3f6a55053d59107a3b5a02ecc8450c8ff7ebe29d5763c7b2a3a0f5303d790fd3"` [INFO] [stderr] Checking state v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ident_hash.rs:21:34 [INFO] [stderr] | [INFO] [stderr] 21 | self.0 = (self.0 << 8) | (i as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `container::Container` [INFO] [stderr] --> src/lib.rs:226:42 [INFO] [stderr] | [INFO] [stderr] 226 | const_if_enabled!([$(#[$($s)*])* pub] $($rest)*); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/container.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | / const_if_enabled! { [INFO] [stderr] 98 | | /// Creates a new container with no stored values. [INFO] [stderr] 99 | | /// [INFO] [stderr] 100 | | /// ## Example [INFO] [stderr] ... | [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 96 | impl Default for container::Container { [INFO] [stderr] 97 | fn default() -> Self { [INFO] [stderr] 98 | Self::new() [INFO] [stderr] 99 | } [INFO] [stderr] 100 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/container.rs:111:38 [INFO] [stderr] | [INFO] [stderr] 111 | map: UnsafeCell::new(0 as *mut _), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ident_hash.rs:21:34 [INFO] [stderr] | [INFO] [stderr] 21 | self.0 = (self.0 << 8) | (i as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/container.rs:403:17 [INFO] [stderr] | [INFO] [stderr] 403 | drop(&mut boxed_any); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_ref)] on by default [INFO] [stderr] note: argument has type &mut std::boxed::Box<(dyn std::any::Any + 'static)> [INFO] [stderr] --> src/container.rs:403:22 [INFO] [stderr] | [INFO] [stderr] 403 | drop(&mut boxed_any); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/container.rs:407:13 [INFO] [stderr] | [INFO] [stderr] 407 | drop(&mut boxed_map); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type &mut std::boxed::Box>> [INFO] [stderr] --> src/container.rs:407:18 [INFO] [stderr] | [INFO] [stderr] 407 | drop(&mut boxed_map); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] warning: you should consider adding a `Default` implementation for `container::Container` [INFO] [stderr] --> src/lib.rs:226:42 [INFO] [stderr] | [INFO] [stderr] 226 | const_if_enabled!([$(#[$($s)*])* pub] $($rest)*); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/container.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | / const_if_enabled! { [INFO] [stderr] 98 | | /// Creates a new container with no stored values. [INFO] [stderr] 99 | | /// [INFO] [stderr] 100 | | /// ## Example [INFO] [stderr] ... | [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 96 | impl Default for container::Container { [INFO] [stderr] 97 | fn default() -> Self { [INFO] [stderr] 98 | Self::new() [INFO] [stderr] 99 | } [INFO] [stderr] 100 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/container.rs:111:38 [INFO] [stderr] | [INFO] [stderr] 111 | map: UnsafeCell::new(0 as *mut _), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `storage::Storage` [INFO] [stderr] --> src/lib.rs:226:42 [INFO] [stderr] | [INFO] [stderr] 226 | const_if_enabled!([$(#[$($s)*])* pub] $($rest)*); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/storage.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / const_if_enabled! { [INFO] [stderr] 60 | | /// Create a new, uninitialized storage location. [INFO] [stderr] 61 | | /// [INFO] [stderr] 62 | | /// # Example [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | impl Default for storage::Storage { [INFO] [stderr] 59 | fn default() -> Self { [INFO] [stderr] 60 | Self::new() [INFO] [stderr] 61 | } [INFO] [stderr] 62 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/storage.rs:73:39 [INFO] [stderr] | [INFO] [stderr] 73 | item: UnsafeCell::new(0 as *mut T), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/storage.rs:219:17 [INFO] [stderr] | [INFO] [stderr] 219 | drop(&mut item); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type &mut std::boxed::Box [INFO] [stderr] --> src/storage.rs:219:22 [INFO] [stderr] | [INFO] [stderr] 219 | drop(&mut item); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/container.rs:403:17 [INFO] [stderr] | [INFO] [stderr] 403 | drop(&mut boxed_any); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_ref)] on by default [INFO] [stderr] note: argument has type &mut std::boxed::Box<(dyn std::any::Any + 'static)> [INFO] [stderr] --> src/container.rs:403:22 [INFO] [stderr] | [INFO] [stderr] 403 | drop(&mut boxed_any); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/container.rs:407:13 [INFO] [stderr] | [INFO] [stderr] 407 | drop(&mut boxed_map); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type &mut std::boxed::Box>> [INFO] [stderr] --> src/container.rs:407:18 [INFO] [stderr] | [INFO] [stderr] 407 | drop(&mut boxed_map); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `storage::Storage` [INFO] [stderr] --> src/lib.rs:226:42 [INFO] [stderr] | [INFO] [stderr] 226 | const_if_enabled!([$(#[$($s)*])* pub] $($rest)*); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/storage.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / const_if_enabled! { [INFO] [stderr] 60 | | /// Create a new, uninitialized storage location. [INFO] [stderr] 61 | | /// [INFO] [stderr] 62 | | /// # Example [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | impl Default for storage::Storage { [INFO] [stderr] 59 | fn default() -> Self { [INFO] [stderr] 60 | Self::new() [INFO] [stderr] 61 | } [INFO] [stderr] 62 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/storage.rs:73:39 [INFO] [stderr] | [INFO] [stderr] 73 | item: UnsafeCell::new(0 as *mut T), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a reference instead of an owned value. Dropping a reference does nothing. [INFO] [stderr] --> src/storage.rs:219:17 [INFO] [stderr] | [INFO] [stderr] 219 | drop(&mut item); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type &mut std::boxed::Box [INFO] [stderr] --> src/storage.rs:219:22 [INFO] [stderr] | [INFO] [stderr] 219 | drop(&mut item); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_ref [INFO] [stderr] [INFO] [stderr] error: Could not compile `state`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `state`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "3f6a55053d59107a3b5a02ecc8450c8ff7ebe29d5763c7b2a3a0f5303d790fd3"` [INFO] running `"docker" "rm" "-f" "3f6a55053d59107a3b5a02ecc8450c8ff7ebe29d5763c7b2a3a0f5303d790fd3"` [INFO] [stdout] 3f6a55053d59107a3b5a02ecc8450c8ff7ebe29d5763c7b2a3a0f5303d790fd3