[INFO] crate sse-client 1.0.0 is already in cache [INFO] extracting crate sse-client 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/sse-client/1.0.0 [INFO] extracting crate sse-client 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sse-client/1.0.0 [INFO] validating manifest of sse-client-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sse-client-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sse-client-1.0.0 [INFO] finished frobbing sse-client-1.0.0 [INFO] frobbed toml for sse-client-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/sse-client/1.0.0/Cargo.toml [INFO] started frobbing sse-client-1.0.0 [INFO] finished frobbing sse-client-1.0.0 [INFO] frobbed toml for sse-client-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sse-client/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sse-client-1.0.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sse-client/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0c857220f25f7098ef05714b09c8add33ebe1eb5ea9e537a650075252beb3b50 [INFO] running `"docker" "start" "-a" "0c857220f25f7098ef05714b09c8add33ebe1eb5ea9e537a650075252beb3b50"` [INFO] [stderr] Checking sse-client v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/network.rs:113:1 [INFO] [stderr] | [INFO] [stderr] 113 | / fn listen_stream( [INFO] [stderr] 114 | | url: Arc, [INFO] [stderr] 115 | | connection_url: Arc, [INFO] [stderr] 116 | | stream: StreamWrapper, [INFO] [stderr] ... | [INFO] [stderr] 157 | | }); [INFO] [stderr] 158 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/network.rs:188:5 [INFO] [stderr] | [INFO] [stderr] 188 | stream.write(request.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/network.rs:281:9 [INFO] [stderr] | [INFO] [stderr] 281 | 200 | 301 | 302 | 303 | 307 => Ok(()), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/network.rs:283:9 [INFO] [stderr] | [INFO] [stderr] 283 | 200 ... 299 => Err(StreamAction::Reconnect(status.to_string())), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/network.rs:313:1 [INFO] [stderr] | [INFO] [stderr] 313 | / fn reconnect_stream( [INFO] [stderr] 314 | | url: Arc, [INFO] [stderr] 315 | | stream: StreamWrapper, [INFO] [stderr] 316 | | state: StateWrapper, [INFO] [stderr] ... | [INFO] [stderr] 329 | | listen_stream(url.clone(), url, stream, Arc::clone(&state), on_open, on_message, on_error, Arc::clone(&failed_attempts), last_event_id); [INFO] [stderr] 330 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/pub_sub.rs:4:16 [INFO] [stderr] | [INFO] [stderr] 4 | listeners: HashMap>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/pub_sub.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / if self.listeners.contains_key(&name) { [INFO] [stderr] 16 | | self.listeners.get_mut(&name).unwrap().push(listener); [INFO] [stderr] 17 | | } else { [INFO] [stderr] 18 | | self.listeners.insert(name, vec!(listener)); [INFO] [stderr] 19 | | } [INFO] [stderr] | |_________^ help: consider using: `self.listeners.entry(name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/pub_sub.rs:24:29 [INFO] [stderr] | [INFO] [stderr] 24 | for listener in self.listeners.get(&name).unwrap().iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.listeners[&name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/data.rs:37:40 [INFO] [stderr] | [INFO] [stderr] 37 | } else if !message.starts_with(":") && message.contains(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/data.rs:37:65 [INFO] [stderr] | [INFO] [stderr] 37 | } else if !message.starts_with(":") && message.contains(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/data.rs:77:1 [INFO] [stderr] | [INFO] [stderr] 77 | / fn parse_field<'a>(message: &'a str) -> (&'a str, &'a str) { [INFO] [stderr] 78 | | let parts: Vec<&str> = message.splitn(2, ":").collect(); [INFO] [stderr] 79 | | (parts[0], parts[1].trim()) [INFO] [stderr] 80 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/data.rs:78:46 [INFO] [stderr] | [INFO] [stderr] 78 | let parts: Vec<&str> = message.splitn(2, ":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `sse-client`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/network.rs:113:1 [INFO] [stderr] | [INFO] [stderr] 113 | / fn listen_stream( [INFO] [stderr] 114 | | url: Arc, [INFO] [stderr] 115 | | connection_url: Arc, [INFO] [stderr] 116 | | stream: StreamWrapper, [INFO] [stderr] ... | [INFO] [stderr] 157 | | }); [INFO] [stderr] 158 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/network.rs:188:5 [INFO] [stderr] | [INFO] [stderr] 188 | stream.write(request.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/network.rs:281:9 [INFO] [stderr] | [INFO] [stderr] 281 | 200 | 301 | 302 | 303 | 307 => Ok(()), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/network.rs:283:9 [INFO] [stderr] | [INFO] [stderr] 283 | 200 ... 299 => Err(StreamAction::Reconnect(status.to_string())), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/network.rs:313:1 [INFO] [stderr] | [INFO] [stderr] 313 | / fn reconnect_stream( [INFO] [stderr] 314 | | url: Arc, [INFO] [stderr] 315 | | stream: StreamWrapper, [INFO] [stderr] 316 | | state: StateWrapper, [INFO] [stderr] ... | [INFO] [stderr] 329 | | listen_stream(url.clone(), url, stream, Arc::clone(&state), on_open, on_message, on_error, Arc::clone(&failed_attempts), last_event_id); [INFO] [stderr] 330 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/pub_sub.rs:4:16 [INFO] [stderr] | [INFO] [stderr] 4 | listeners: HashMap>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/pub_sub.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / if self.listeners.contains_key(&name) { [INFO] [stderr] 16 | | self.listeners.get_mut(&name).unwrap().push(listener); [INFO] [stderr] 17 | | } else { [INFO] [stderr] 18 | | self.listeners.insert(name, vec!(listener)); [INFO] [stderr] 19 | | } [INFO] [stderr] | |_________^ help: consider using: `self.listeners.entry(name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/pub_sub.rs:24:29 [INFO] [stderr] | [INFO] [stderr] 24 | for listener in self.listeners.get(&name).unwrap().iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.listeners[&name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/data.rs:37:40 [INFO] [stderr] | [INFO] [stderr] 37 | } else if !message.starts_with(":") && message.contains(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/data.rs:37:65 [INFO] [stderr] | [INFO] [stderr] 37 | } else if !message.starts_with(":") && message.contains(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/data.rs:77:1 [INFO] [stderr] | [INFO] [stderr] 77 | / fn parse_field<'a>(message: &'a str) -> (&'a str, &'a str) { [INFO] [stderr] 78 | | let parts: Vec<&str> = message.splitn(2, ":").collect(); [INFO] [stderr] 79 | | (parts[0], parts[1].trim()) [INFO] [stderr] 80 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/data.rs:78:46 [INFO] [stderr] | [INFO] [stderr] 78 | let parts: Vec<&str> = message.splitn(2, ":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/test_helper/fake_server.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | &self.client_tx.send(message).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.client_tx.send(message).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/test_helper/fake_server.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | &self.client_tx.send("close").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.client_tx.send("close").unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/test_helper/fake_server.rs:128:25 [INFO] [stderr] | [INFO] [stderr] 128 | stream.write(received.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sse-client`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0c857220f25f7098ef05714b09c8add33ebe1eb5ea9e537a650075252beb3b50"` [INFO] running `"docker" "rm" "-f" "0c857220f25f7098ef05714b09c8add33ebe1eb5ea9e537a650075252beb3b50"` [INFO] [stdout] 0c857220f25f7098ef05714b09c8add33ebe1eb5ea9e537a650075252beb3b50