[INFO] crate srtparse 0.1.1 is already in cache [INFO] extracting crate srtparse 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/srtparse/0.1.1 [INFO] extracting crate srtparse 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/srtparse/0.1.1 [INFO] validating manifest of srtparse-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of srtparse-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing srtparse-0.1.1 [INFO] finished frobbing srtparse-0.1.1 [INFO] frobbed toml for srtparse-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/srtparse/0.1.1/Cargo.toml [INFO] started frobbing srtparse-0.1.1 [INFO] finished frobbing srtparse-0.1.1 [INFO] frobbed toml for srtparse-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/srtparse/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting srtparse-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/srtparse/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7fe72e89b1a18aa105b49ec7f1df5fcde0f2367d3b9d33ead2812a54a1d74cef [INFO] running `"docker" "start" "-a" "7fe72e89b1a18aa105b49ec7f1df5fcde0f2367d3b9d33ead2812a54a1d74cef"` [INFO] [stderr] Checking srtparse v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | const UTF8_BOM: &'static str = "\u{feff}"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | const UTF8_BOM: &'static str = "\u{feff}"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:116:24 [INFO] [stderr] | [INFO] [stderr] 116 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 117 | | if let Some(ref mut txt) = text { [INFO] [stderr] 118 | | txt.push('\n'); [INFO] [stderr] 119 | | txt.push_str(line); [INFO] [stderr] ... | [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 116 | } else if let Some(ref mut txt) = text { [INFO] [stderr] 117 | txt.push('\n'); [INFO] [stderr] 118 | txt.push_str(line); [INFO] [stderr] 119 | } else { [INFO] [stderr] 120 | text = Some(line.to_string()); [INFO] [stderr] 121 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:116:24 [INFO] [stderr] | [INFO] [stderr] 116 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 117 | | if let Some(ref mut txt) = text { [INFO] [stderr] 118 | | txt.push('\n'); [INFO] [stderr] 119 | | txt.push_str(line); [INFO] [stderr] ... | [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 116 | } else if let Some(ref mut txt) = text { [INFO] [stderr] 117 | txt.push('\n'); [INFO] [stderr] 118 | txt.push_str(line); [INFO] [stderr] 119 | } else { [INFO] [stderr] 120 | text = Some(line.to_string()); [INFO] [stderr] 121 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:285:68 [INFO] [stderr] | [INFO] [stderr] 285 | assert_eq!(result[3].start_time, Duration::from_millis(6782325)); [INFO] [stderr] | ^^^^^^^ help: consider: `6_782_325` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:286:66 [INFO] [stderr] | [INFO] [stderr] 286 | assert_eq!(result[3].end_time, Duration::from_millis(6786162)); [INFO] [stderr] | ^^^^^^^ help: consider: `6_786_162` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:364:59 [INFO] [stderr] | [INFO] [stderr] 364 | assert_eq!(last.start_time, Duration::from_millis(6801628)); [INFO] [stderr] | ^^^^^^^ help: consider: `6_801_628` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:365:57 [INFO] [stderr] | [INFO] [stderr] 365 | assert_eq!(last.end_time, Duration::from_millis(6804381)); [INFO] [stderr] | ^^^^^^^ help: consider: `6_804_381` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:136:45 [INFO] [stderr] | [INFO] [stderr] 136 | let mut file = File::open(path).map_err(|err| Error::OpenFile(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::OpenFile` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:138:43 [INFO] [stderr] | [INFO] [stderr] 138 | file.read_to_string(&mut buf).map_err(|err| Error::ReadFile(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::ReadFile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:214:31 [INFO] [stderr] | [INFO] [stderr] 214 | let mut time = time.split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:217:39 [INFO] [stderr] | [INFO] [stderr] 217 | let mut parts = val.split(":"); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:136:45 [INFO] [stderr] | [INFO] [stderr] 136 | let mut file = File::open(path).map_err(|err| Error::OpenFile(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::OpenFile` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:138:43 [INFO] [stderr] | [INFO] [stderr] 138 | file.read_to_string(&mut buf).map_err(|err| Error::ReadFile(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::ReadFile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:214:31 [INFO] [stderr] | [INFO] [stderr] 214 | let mut time = time.split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:217:39 [INFO] [stderr] | [INFO] [stderr] 217 | let mut parts = val.split(":"); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.76s [INFO] running `"docker" "inspect" "7fe72e89b1a18aa105b49ec7f1df5fcde0f2367d3b9d33ead2812a54a1d74cef"` [INFO] running `"docker" "rm" "-f" "7fe72e89b1a18aa105b49ec7f1df5fcde0f2367d3b9d33ead2812a54a1d74cef"` [INFO] [stdout] 7fe72e89b1a18aa105b49ec7f1df5fcde0f2367d3b9d33ead2812a54a1d74cef