[INFO] crate solicit 0.4.4 is already in cache [INFO] extracting crate solicit 0.4.4 into work/ex/clippy-test-run/sources/stable/reg/solicit/0.4.4 [INFO] extracting crate solicit 0.4.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/solicit/0.4.4 [INFO] validating manifest of solicit-0.4.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of solicit-0.4.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing solicit-0.4.4 [INFO] finished frobbing solicit-0.4.4 [INFO] frobbed toml for solicit-0.4.4 written to work/ex/clippy-test-run/sources/stable/reg/solicit/0.4.4/Cargo.toml [INFO] started frobbing solicit-0.4.4 [INFO] finished frobbing solicit-0.4.4 [INFO] frobbed toml for solicit-0.4.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/solicit/0.4.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting solicit-0.4.4 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/solicit/0.4.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a209606e0db7abdf21530d3e12326cf4e4816a89a1840601f885c2b4fa99bfac [INFO] running `"docker" "start" "-a" "a209606e0db7abdf21530d3e12326cf4e4816a89a1840601f885c2b4fa99bfac"` [INFO] [stderr] Checking solicit v0.4.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/data.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/data.rs:156:21 [INFO] [stderr] | [INFO] [stderr] 156 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/data.rs:157:21 [INFO] [stderr] | [INFO] [stderr] 157 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/data.rs:158:21 [INFO] [stderr] | [INFO] [stderr] 158 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/data.rs:165:21 [INFO] [stderr] | [INFO] [stderr] 165 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/data.rs:166:21 [INFO] [stderr] | [INFO] [stderr] 166 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/data.rs:167:21 [INFO] [stderr] | [INFO] [stderr] 167 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/headers.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/headers.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | weight: weight, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/headers.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | is_exclusive: is_exclusive, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_exclusive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/headers.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/headers.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | is_exclusive: is_exclusive, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_exclusive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/headers.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/headers.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/headers.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/headers.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | stream_dep: stream_dep, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_dep` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/headers.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/settings.rs:258:21 [INFO] [stderr] | [INFO] [stderr] 258 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/settings.rs:266:21 [INFO] [stderr] | [INFO] [stderr] 266 | settings: settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/settings.rs:267:21 [INFO] [stderr] | [INFO] [stderr] 267 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/connection.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/connection.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/connection.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | end_stream: end_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `end_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/connection.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/connection.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | end_stream: end_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `end_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/connection.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | receiver: receiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/connection.rs:250:13 [INFO] [stderr] | [INFO] [stderr] 250 | sender: sender, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/connection.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | scheme: scheme, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `scheme` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/session.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/priority.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/priority.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/client/mod.rs:106:30 [INFO] [stderr] | [INFO] [stderr] 106 | CleartextConnector { host: host, port: 80 } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/client/mod.rs:112:30 [INFO] [stderr] | [INFO] [stderr] 112 | CleartextConnector { host: host, port: port } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/client/mod.rs:112:42 [INFO] [stderr] | [INFO] [stderr] 112 | CleartextConnector { host: host, port: port } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/client/mod.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | conn: conn, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/client/mod.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/client/mod.rs:289:13 [INFO] [stderr] | [INFO] [stderr] 289 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/server.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/server.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | conn: conn, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/server.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/mod.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/mod.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/mod.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/simple.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/simple.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/async.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/async.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/async.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | conn: conn, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/async.rs:475:17 [INFO] [stderr] | [INFO] [stderr] 475 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/async.rs:476:17 [INFO] [stderr] | [INFO] [stderr] 476 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/async.rs:692:13 [INFO] [stderr] | [INFO] [stderr] 692 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/mod.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | handler: handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/data.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/data.rs:156:21 [INFO] [stderr] | [INFO] [stderr] 156 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/data.rs:157:21 [INFO] [stderr] | [INFO] [stderr] 157 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/data.rs:158:21 [INFO] [stderr] | [INFO] [stderr] 158 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/data.rs:165:21 [INFO] [stderr] | [INFO] [stderr] 165 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/data.rs:166:21 [INFO] [stderr] | [INFO] [stderr] 166 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/data.rs:167:21 [INFO] [stderr] | [INFO] [stderr] 167 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/headers.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/headers.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | weight: weight, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/headers.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | is_exclusive: is_exclusive, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_exclusive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/headers.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/headers.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | is_exclusive: is_exclusive, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_exclusive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/headers.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/headers.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/headers.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/headers.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | stream_dep: stream_dep, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_dep` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/headers.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/settings.rs:258:21 [INFO] [stderr] | [INFO] [stderr] 258 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/settings.rs:266:21 [INFO] [stderr] | [INFO] [stderr] 266 | settings: settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/frame/settings.rs:267:21 [INFO] [stderr] | [INFO] [stderr] 267 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/connection.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/connection.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/connection.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | end_stream: end_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `end_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/connection.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/connection.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | end_stream: end_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `end_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/connection.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | receiver: receiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/connection.rs:250:13 [INFO] [stderr] | [INFO] [stderr] 250 | sender: sender, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/connection.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | scheme: scheme, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `scheme` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/session.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/priority.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/priority.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/client/mod.rs:106:30 [INFO] [stderr] | [INFO] [stderr] 106 | CleartextConnector { host: host, port: 80 } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/client/mod.rs:112:30 [INFO] [stderr] | [INFO] [stderr] 112 | CleartextConnector { host: host, port: port } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/client/mod.rs:112:42 [INFO] [stderr] | [INFO] [stderr] 112 | CleartextConnector { host: host, port: port } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/client/mod.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | conn: conn, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/client/mod.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/client/mod.rs:289:13 [INFO] [stderr] | [INFO] [stderr] 289 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/server.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/server.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | conn: conn, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/server.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/mod.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/mod.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/mod.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/tests/common.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | recv_list: recv_list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recv_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/tests/common.rs:264:17 [INFO] [stderr] | [INFO] [stderr] 264 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/tests/common.rs:265:17 [INFO] [stderr] | [INFO] [stderr] 265 | chunks: chunks, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `chunks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http/tests/common.rs:359:31 [INFO] [stderr] | [INFO] [stderr] 359 | StubDataPrioritizer { chunks: chunks } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `chunks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/simple.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/simple.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/async.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/async.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/async.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | conn: conn, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/async.rs:475:17 [INFO] [stderr] | [INFO] [stderr] 475 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/async.rs:476:17 [INFO] [stderr] | [INFO] [stderr] 476 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/async.rs:692:13 [INFO] [stderr] | [INFO] [stderr] 692 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/mod.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | handler: handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/headers.rs:112:40 [INFO] [stderr] | [INFO] [stderr] 112 | (((self.stream_id >> 24) & 0x000000FF) as u8) | e_bit, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/headers.rs:113:40 [INFO] [stderr] | [INFO] [stderr] 113 | (((self.stream_id >> 16) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/headers.rs:114:40 [INFO] [stderr] | [INFO] [stderr] 114 | (((self.stream_id >> 8) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/headers.rs:115:40 [INFO] [stderr] | [INFO] [stderr] 115 | (((self.stream_id >> 0) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/settings.rs:94:29 [INFO] [stderr] | [INFO] [stderr] 94 | (((val >> 24) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/settings.rs:95:29 [INFO] [stderr] | [INFO] [stderr] 95 | (((val >> 16) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/settings.rs:96:29 [INFO] [stderr] | [INFO] [stderr] 96 | (((val >> 8) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/settings.rs:97:29 [INFO] [stderr] | [INFO] [stderr] 97 | (((val >> 0) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/mod.rs:68:28 [INFO] [stderr] | [INFO] [stderr] 68 | (((length >> 16) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/mod.rs:69:28 [INFO] [stderr] | [INFO] [stderr] 69 | (((length >> 8) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/mod.rs:70:28 [INFO] [stderr] | [INFO] [stderr] 70 | (((length >> 0) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/mod.rs:73:31 [INFO] [stderr] | [INFO] [stderr] 73 | (((stream_id >> 24) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/mod.rs:74:31 [INFO] [stderr] | [INFO] [stderr] 74 | (((stream_id >> 16) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/mod.rs:75:31 [INFO] [stderr] | [INFO] [stderr] 75 | (((stream_id >> 8) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/mod.rs:76:31 [INFO] [stderr] | [INFO] [stderr] 76 | (((stream_id >> 0) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/http/mod.rs:30:28 [INFO] [stderr] | [INFO] [stderr] 30 | pub const ALPN_PROTOCOLS: &'static [&'static [u8]] = &[ [INFO] [stderr] | -^^^^^^^---------------- help: consider removing `'static`: `&[&'static [u8]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/http/mod.rs:30:38 [INFO] [stderr] | [INFO] [stderr] 30 | pub const ALPN_PROTOCOLS: &'static [&'static [u8]] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/headers.rs:112:40 [INFO] [stderr] | [INFO] [stderr] 112 | (((self.stream_id >> 24) & 0x000000FF) as u8) | e_bit, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/headers.rs:113:40 [INFO] [stderr] | [INFO] [stderr] 113 | (((self.stream_id >> 16) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/headers.rs:114:40 [INFO] [stderr] | [INFO] [stderr] 114 | (((self.stream_id >> 8) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/headers.rs:115:40 [INFO] [stderr] | [INFO] [stderr] 115 | (((self.stream_id >> 0) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/settings.rs:94:29 [INFO] [stderr] | [INFO] [stderr] 94 | (((val >> 24) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/settings.rs:95:29 [INFO] [stderr] | [INFO] [stderr] 95 | (((val >> 16) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/settings.rs:96:29 [INFO] [stderr] | [INFO] [stderr] 96 | (((val >> 8) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/settings.rs:97:29 [INFO] [stderr] | [INFO] [stderr] 97 | (((val >> 0) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/mod.rs:68:28 [INFO] [stderr] | [INFO] [stderr] 68 | (((length >> 16) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/mod.rs:69:28 [INFO] [stderr] | [INFO] [stderr] 69 | (((length >> 8) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/mod.rs:70:28 [INFO] [stderr] | [INFO] [stderr] 70 | (((length >> 0) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/mod.rs:73:31 [INFO] [stderr] | [INFO] [stderr] 73 | (((stream_id >> 24) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/mod.rs:74:31 [INFO] [stderr] | [INFO] [stderr] 74 | (((stream_id >> 16) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/mod.rs:75:31 [INFO] [stderr] | [INFO] [stderr] 75 | (((stream_id >> 8) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/http/frame/mod.rs:76:31 [INFO] [stderr] | [INFO] [stderr] 76 | (((stream_id >> 0) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/client/mod.rs:404:9 [INFO] [stderr] | [INFO] [stderr] 404 | return stream; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/http/mod.rs:30:28 [INFO] [stderr] | [INFO] [stderr] 30 | pub const ALPN_PROTOCOLS: &'static [&'static [u8]] = &[ [INFO] [stderr] | -^^^^^^^---------------- help: consider removing `'static`: `&[&'static [u8]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/http/mod.rs:30:38 [INFO] [stderr] | [INFO] [stderr] 30 | pub const ALPN_PROTOCOLS: &'static [&'static [u8]] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/http/client/mod.rs:297:13 [INFO] [stderr] | [INFO] [stderr] 297 | let mut stream = match self.state.get_stream_mut(stream_id) { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/http/client/mod.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | let mut stream = match self.state.get_stream_mut(stream_id) { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/http/client/mod.rs:323:13 [INFO] [stderr] | [INFO] [stderr] 323 | let mut stream = match self.state.get_stream_mut(stream_id) { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/http/server.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | let mut stream = match self.state.get_stream_mut(stream_id) { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/http/server.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | let mut stream = match self.state.get_stream_mut(stream_id) { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/data.rs:90:44 [INFO] [stderr] | [INFO] [stderr] 90 | 1 + (self.data.len() as u32) + (self.padding_len.unwrap_or(0) as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.padding_len.unwrap_or(0))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:21:10 [INFO] [stderr] | [INFO] [stderr] 21 | (($buf[$offset + 0] as $tip) << 24) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($buf[$offset + 0])` [INFO] [stderr] | [INFO] [stderr] ::: src/http/frame/headers.rs:77:26 [INFO] [stderr] | [INFO] [stderr] 77 | let mut id = unpack_octets_4!(buf, 0, u32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:22:10 [INFO] [stderr] | [INFO] [stderr] 22 | (($buf[$offset + 1] as $tip) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($buf[$offset + 1])` [INFO] [stderr] | [INFO] [stderr] ::: src/http/frame/headers.rs:77:26 [INFO] [stderr] | [INFO] [stderr] 77 | let mut id = unpack_octets_4!(buf, 0, u32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:23:10 [INFO] [stderr] | [INFO] [stderr] 23 | (($buf[$offset + 2] as $tip) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($buf[$offset + 2])` [INFO] [stderr] | [INFO] [stderr] ::: src/http/frame/headers.rs:77:26 [INFO] [stderr] | [INFO] [stderr] 77 | let mut id = unpack_octets_4!(buf, 0, u32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:24:10 [INFO] [stderr] | [INFO] [stderr] 24 | (($buf[$offset + 3] as $tip) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($buf[$offset + 3])` [INFO] [stderr] | [INFO] [stderr] ::: src/http/frame/headers.rs:77:26 [INFO] [stderr] | [INFO] [stderr] 77 | let mut id = unpack_octets_4!(buf, 0, u32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.stream_id` [INFO] [stderr] --> src/http/frame/headers.rs:115:15 [INFO] [stderr] | [INFO] [stderr] 115 | (((self.stream_id >> 0) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/headers.rs:190:17 [INFO] [stderr] | [INFO] [stderr] 190 | 1 + self.padding_len.unwrap_or(0) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.padding_len.unwrap_or(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/settings.rs:56:24 [INFO] [stderr] | [INFO] [stderr] 56 | let id: u16 = ((raw_setting[0] as u16) << 8) | (raw_setting[1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(raw_setting[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/settings.rs:56:56 [INFO] [stderr] | [INFO] [stderr] 56 | let id: u16 = ((raw_setting[0] as u16) << 8) | (raw_setting[1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(raw_setting[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:21:10 [INFO] [stderr] | [INFO] [stderr] 21 | (($buf[$offset + 0] as $tip) << 24) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($buf[$offset + 0])` [INFO] [stderr] | [INFO] [stderr] ::: src/http/frame/settings.rs:57:24 [INFO] [stderr] | [INFO] [stderr] 57 | let val: u32 = unpack_octets_4!(raw_setting, 2, u32); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:22:10 [INFO] [stderr] | [INFO] [stderr] 22 | (($buf[$offset + 1] as $tip) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($buf[$offset + 1])` [INFO] [stderr] | [INFO] [stderr] ::: src/http/frame/settings.rs:57:24 [INFO] [stderr] | [INFO] [stderr] 57 | let val: u32 = unpack_octets_4!(raw_setting, 2, u32); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:23:10 [INFO] [stderr] | [INFO] [stderr] 23 | (($buf[$offset + 2] as $tip) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($buf[$offset + 2])` [INFO] [stderr] | [INFO] [stderr] ::: src/http/frame/settings.rs:57:24 [INFO] [stderr] | [INFO] [stderr] 57 | let val: u32 = unpack_octets_4!(raw_setting, 2, u32); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:24:10 [INFO] [stderr] | [INFO] [stderr] 24 | (($buf[$offset + 3] as $tip) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($buf[$offset + 3])` [INFO] [stderr] | [INFO] [stderr] ::: src/http/frame/settings.rs:57:24 [INFO] [stderr] | [INFO] [stderr] 57 | let val: u32 = unpack_octets_4!(raw_setting, 2, u32); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/http/frame/settings.rs:64:19 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn get_id(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/http/frame/settings.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match self { [INFO] [stderr] 66 | | &HttpSetting::HeaderTableSize(_) => 1, [INFO] [stderr] 67 | | &HttpSetting::EnablePush(_) => 2, [INFO] [stderr] 68 | | &HttpSetting::MaxConcurrentStreams(_) => 3, [INFO] [stderr] ... | [INFO] [stderr] 71 | | &HttpSetting::MaxHeaderListSize(_) => 6, [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 65 | match *self { [INFO] [stderr] 66 | HttpSetting::HeaderTableSize(_) => 1, [INFO] [stderr] 67 | HttpSetting::EnablePush(_) => 2, [INFO] [stderr] 68 | HttpSetting::MaxConcurrentStreams(_) => 3, [INFO] [stderr] 69 | HttpSetting::InitialWindowSize(_) => 4, [INFO] [stderr] 70 | HttpSetting::MaxFrameSize(_) => 5, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/http/frame/settings.rs:76:20 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn get_val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/http/frame/settings.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / match self { [INFO] [stderr] 78 | | &HttpSetting::HeaderTableSize(ref val) => val.clone(), [INFO] [stderr] 79 | | &HttpSetting::EnablePush(ref val) => val.clone(), [INFO] [stderr] 80 | | &HttpSetting::MaxConcurrentStreams(ref val) => val.clone(), [INFO] [stderr] ... | [INFO] [stderr] 83 | | &HttpSetting::MaxHeaderListSize(ref val) => val.clone(), [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 77 | match *self { [INFO] [stderr] 78 | HttpSetting::HeaderTableSize(ref val) => val.clone(), [INFO] [stderr] 79 | HttpSetting::EnablePush(ref val) => val.clone(), [INFO] [stderr] 80 | HttpSetting::MaxConcurrentStreams(ref val) => val.clone(), [INFO] [stderr] 81 | HttpSetting::InitialWindowSize(ref val) => val.clone(), [INFO] [stderr] 82 | HttpSetting::MaxFrameSize(ref val) => val.clone(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/http/frame/settings.rs:78:55 [INFO] [stderr] | [INFO] [stderr] 78 | &HttpSetting::HeaderTableSize(ref val) => val.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*val` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/http/frame/settings.rs:79:50 [INFO] [stderr] | [INFO] [stderr] 79 | &HttpSetting::EnablePush(ref val) => val.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/http/frame/settings.rs:80:60 [INFO] [stderr] | [INFO] [stderr] 80 | &HttpSetting::MaxConcurrentStreams(ref val) => val.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/http/frame/settings.rs:81:57 [INFO] [stderr] | [INFO] [stderr] 81 | &HttpSetting::InitialWindowSize(ref val) => val.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/http/frame/settings.rs:82:52 [INFO] [stderr] | [INFO] [stderr] 82 | &HttpSetting::MaxFrameSize(ref val) => val.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/http/frame/settings.rs:83:57 [INFO] [stderr] | [INFO] [stderr] 83 | &HttpSetting::MaxHeaderListSize(ref val) => val.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/http/frame/settings.rs:89:18 [INFO] [stderr] | [INFO] [stderr] 89 | fn serialize(&self) -> [u8; 6] { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `id` [INFO] [stderr] --> src/http/frame/settings.rs:93:14 [INFO] [stderr] | [INFO] [stderr] 93 | ((id >> 0) & 0x00FF) as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `val` [INFO] [stderr] --> src/http/frame/settings.rs:97:15 [INFO] [stderr] | [INFO] [stderr] 97 | (((val >> 0) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `http::frame::settings::SettingsFrame` [INFO] [stderr] --> src/http/frame/settings.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn new() -> SettingsFrame { [INFO] [stderr] 155 | | SettingsFrame { [INFO] [stderr] 156 | | settings: Vec::new(), [INFO] [stderr] 157 | | // By default, no flags are set [INFO] [stderr] 158 | | flags: 0, [INFO] [stderr] 159 | | } [INFO] [stderr] 160 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 142 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:53:10 [INFO] [stderr] | [INFO] [stderr] 53 | ((header[0] as u32) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(header[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:54:10 [INFO] [stderr] | [INFO] [stderr] 54 | ((header[1] as u32) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(header[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(header[2] as u32)` [INFO] [stderr] --> src/http/frame/mod.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | ((header[2] as u32) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:55:10 [INFO] [stderr] | [INFO] [stderr] 55 | ((header[2] as u32) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(header[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:21:10 [INFO] [stderr] | [INFO] [stderr] 21 | (($buf[$offset + 0] as $tip) << 24) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($buf[$offset + 0])` [INFO] [stderr] ... [INFO] [stderr] 58 | let stream_id: u32 = unpack_octets_4!(header, 5, u32); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:22:10 [INFO] [stderr] | [INFO] [stderr] 22 | (($buf[$offset + 1] as $tip) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($buf[$offset + 1])` [INFO] [stderr] ... [INFO] [stderr] 58 | let stream_id: u32 = unpack_octets_4!(header, 5, u32); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:23:10 [INFO] [stderr] | [INFO] [stderr] 23 | (($buf[$offset + 2] as $tip) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($buf[$offset + 2])` [INFO] [stderr] ... [INFO] [stderr] 58 | let stream_id: u32 = unpack_octets_4!(header, 5, u32); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:24:10 [INFO] [stderr] | [INFO] [stderr] 24 | (($buf[$offset + 3] as $tip) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($buf[$offset + 3])` [INFO] [stderr] ... [INFO] [stderr] 58 | let stream_id: u32 = unpack_octets_4!(header, 5, u32); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `length` [INFO] [stderr] --> src/http/frame/mod.rs:70:11 [INFO] [stderr] | [INFO] [stderr] 70 | (((length >> 0) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `stream_id` [INFO] [stderr] --> src/http/frame/mod.rs:76:11 [INFO] [stderr] | [INFO] [stderr] 76 | (((stream_id >> 0) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/http/frame/mod.rs:92:1 [INFO] [stderr] | [INFO] [stderr] 92 | / fn parse_padded_payload<'a>(payload: &'a [u8]) -> Option<(&'a [u8], u8)> { [INFO] [stderr] 93 | | if payload.len() == 0 { [INFO] [stderr] 94 | | // We make sure not to index the payload before we're sure how [INFO] [stderr] 95 | | // large the buffer is. [INFO] [stderr] ... | [INFO] [stderr] 108 | | Some((&payload[1..payload.len() - pad_len], pad_len as u8)) [INFO] [stderr] 109 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/http/frame/mod.rs:93:8 [INFO] [stderr] | [INFO] [stderr] 93 | if payload.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `payload.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/http/frame/mod.rs:182:20 [INFO] [stderr] | [INFO] [stderr] 182 | raw.extend(pack_header(&header).into_iter().map(|x| *x)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `pack_header(&header).into_iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/http/frame/mod.rs:182:41 [INFO] [stderr] | [INFO] [stderr] 182 | raw.extend(pack_header(&header).into_iter().map(|x| *x)); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into-iter-on-array` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const u8`) to a reference type (`&[u8; 9]`) [INFO] [stderr] --> src/http/frame/mod.rs:206:13 [INFO] [stderr] | [INFO] [stderr] 206 | mem::transmute(buf.as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(buf.as_ptr() as *const [u8; 9])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const u8`) to a reference type (`&[u8; 9]`) [INFO] [stderr] --> src/http/frame/mod.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | mem::transmute(self.raw_content.as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self.raw_content.as_ptr() as *const [u8; 9])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/http/connection.rs:485:49 [INFO] [stderr] | [INFO] [stderr] 485 | .map_err(|e| HttpError::CompressionError(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HttpError::CompressionError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `http::session::DefaultSessionState` [INFO] [stderr] --> src/http/session.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | / pub fn new() -> DefaultSessionState { [INFO] [stderr] 102 | | DefaultSessionState { [INFO] [stderr] 103 | | streams: HashMap::new(), [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 94 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/http/session.rs:335:9 [INFO] [stderr] | [INFO] [stderr] 335 | / match chunk { [INFO] [stderr] 336 | | StreamDataChunk::Last(_) => self.close_local(), [INFO] [stderr] 337 | | _ => {}, [INFO] [stderr] 338 | | }; [INFO] [stderr] | |_________^ help: try this: `if let StreamDataChunk::Last(_) = chunk { self.close_local() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/http/server.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / match self.state.get_stream_mut(stream_id) { [INFO] [stderr] 55 | | Some(stream) => { [INFO] [stderr] 56 | | // This'd correspond to having received trailers... [INFO] [stderr] 57 | | stream.set_headers(headers); [INFO] [stderr] ... | [INFO] [stderr] 60 | | None => {}, [INFO] [stderr] 61 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 54 | if let Some(stream) = self.state.get_stream_mut(stream_id) { [INFO] [stderr] 55 | // This'd correspond to having received trailers... [INFO] [stderr] 56 | stream.set_headers(headers); [INFO] [stderr] 57 | return; [INFO] [stderr] 58 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/http/mod.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn as_bytes(&self) -> &'static [u8] { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/http/mod.rs:170:12 [INFO] [stderr] | [INFO] [stderr] 170 | if self.headers.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.headers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/http/mod.rs:173:12 [INFO] [stderr] | [INFO] [stderr] 173 | if &self.headers[0].0 != &b":status" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 173 | if self.headers[0].0 != b":status" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/http/mod.rs:199:18 [INFO] [stderr] | [INFO] [stderr] 199 | Ok(100 * ((buf[0] - b'0') as u16) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[0] - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/http/mod.rs:200:17 [INFO] [stderr] | [INFO] [stderr] 200 | 10 * ((buf[1] - b'0') as u16) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1] - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `((buf[2] - b'0') as u16)` [INFO] [stderr] --> src/http/mod.rs:201:12 [INFO] [stderr] | [INFO] [stderr] 201 | 1 * ((buf[2] - b'0') as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/http/mod.rs:201:16 [INFO] [stderr] | [INFO] [stderr] 201 | 1 * ((buf[2] - b'0') as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[2] - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/client/async.rs:299:5 [INFO] [stderr] | [INFO] [stderr] 299 | / pub fn new(client_stream: ClientStream) -> Option> [INFO] [stderr] 300 | | where S: TransportStream { [INFO] [stderr] 301 | | let (tx, rx): (Sender, Receiver) = [INFO] [stderr] 302 | | mpsc::channel(); [INFO] [stderr] ... | [INFO] [stderr] 336 | | Some(Service(service, tx, recv_frame, send_frame)) [INFO] [stderr] 337 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/client/async.rs:525:16 [INFO] [stderr] | [INFO] [stderr] 525 | if self.request_queue.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.request_queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/client/async.rs:626:16 [INFO] [stderr] | [INFO] [stderr] 626 | if let Err(_) = rx.send(WorkItem::NewClient) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 627 | | return None; [INFO] [stderr] 628 | | } [INFO] [stderr] | |_________- help: try this: `if rx.send(WorkItem::NewClient).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `solicit`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `SessionState` [INFO] [stderr] --> src/http/tests/common.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | SessionState, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/http/client/mod.rs:297:13 [INFO] [stderr] | [INFO] [stderr] 297 | let mut stream = match self.state.get_stream_mut(stream_id) { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/http/client/mod.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | let mut stream = match self.state.get_stream_mut(stream_id) { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/http/client/mod.rs:323:13 [INFO] [stderr] | [INFO] [stderr] 323 | let mut stream = match self.state.get_stream_mut(stream_id) { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/http/server.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | let mut stream = match self.state.get_stream_mut(stream_id) { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/http/server.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | let mut stream = match self.state.get_stream_mut(stream_id) { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/data.rs:90:44 [INFO] [stderr] | [INFO] [stderr] 90 | 1 + (self.data.len() as u32) + (self.padding_len.unwrap_or(0) as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.padding_len.unwrap_or(0))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/http/frame/data.rs:298:36 [INFO] [stderr] | [INFO] [stderr] 298 | RawFrame::with_payload(header.clone(), payload.to_vec())); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/http/frame/data.rs:314:36 [INFO] [stderr] | [INFO] [stderr] 314 | RawFrame::with_payload(header.clone(), payload.to_vec())); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/http/frame/data.rs:343:36 [INFO] [stderr] | [INFO] [stderr] 343 | RawFrame::with_payload(header.clone(), payload.to_vec())); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/http/frame/data.rs:378:36 [INFO] [stderr] | [INFO] [stderr] 378 | RawFrame::with_payload(header.clone(), payload.to_vec())); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:21:10 [INFO] [stderr] | [INFO] [stderr] 21 | (($buf[$offset + 0] as $tip) << 24) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($buf[$offset + 0])` [INFO] [stderr] | [INFO] [stderr] ::: src/http/frame/headers.rs:77:26 [INFO] [stderr] | [INFO] [stderr] 77 | let mut id = unpack_octets_4!(buf, 0, u32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:22:10 [INFO] [stderr] | [INFO] [stderr] 22 | (($buf[$offset + 1] as $tip) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($buf[$offset + 1])` [INFO] [stderr] | [INFO] [stderr] ::: src/http/frame/headers.rs:77:26 [INFO] [stderr] | [INFO] [stderr] 77 | let mut id = unpack_octets_4!(buf, 0, u32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:23:10 [INFO] [stderr] | [INFO] [stderr] 23 | (($buf[$offset + 2] as $tip) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($buf[$offset + 2])` [INFO] [stderr] | [INFO] [stderr] ::: src/http/frame/headers.rs:77:26 [INFO] [stderr] | [INFO] [stderr] 77 | let mut id = unpack_octets_4!(buf, 0, u32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:24:10 [INFO] [stderr] | [INFO] [stderr] 24 | (($buf[$offset + 3] as $tip) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($buf[$offset + 3])` [INFO] [stderr] | [INFO] [stderr] ::: src/http/frame/headers.rs:77:26 [INFO] [stderr] | [INFO] [stderr] 77 | let mut id = unpack_octets_4!(buf, 0, u32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.stream_id` [INFO] [stderr] --> src/http/frame/headers.rs:115:15 [INFO] [stderr] | [INFO] [stderr] 115 | (((self.stream_id >> 0) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/headers.rs:190:17 [INFO] [stderr] | [INFO] [stderr] 190 | 1 + self.padding_len.unwrap_or(0) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.padding_len.unwrap_or(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/settings.rs:56:24 [INFO] [stderr] | [INFO] [stderr] 56 | let id: u16 = ((raw_setting[0] as u16) << 8) | (raw_setting[1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(raw_setting[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/settings.rs:56:56 [INFO] [stderr] | [INFO] [stderr] 56 | let id: u16 = ((raw_setting[0] as u16) << 8) | (raw_setting[1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(raw_setting[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:21:10 [INFO] [stderr] | [INFO] [stderr] 21 | (($buf[$offset + 0] as $tip) << 24) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($buf[$offset + 0])` [INFO] [stderr] | [INFO] [stderr] ::: src/http/frame/settings.rs:57:24 [INFO] [stderr] | [INFO] [stderr] 57 | let val: u32 = unpack_octets_4!(raw_setting, 2, u32); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:22:10 [INFO] [stderr] | [INFO] [stderr] 22 | (($buf[$offset + 1] as $tip) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($buf[$offset + 1])` [INFO] [stderr] | [INFO] [stderr] ::: src/http/frame/settings.rs:57:24 [INFO] [stderr] | [INFO] [stderr] 57 | let val: u32 = unpack_octets_4!(raw_setting, 2, u32); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:23:10 [INFO] [stderr] | [INFO] [stderr] 23 | (($buf[$offset + 2] as $tip) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($buf[$offset + 2])` [INFO] [stderr] | [INFO] [stderr] ::: src/http/frame/settings.rs:57:24 [INFO] [stderr] | [INFO] [stderr] 57 | let val: u32 = unpack_octets_4!(raw_setting, 2, u32); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:24:10 [INFO] [stderr] | [INFO] [stderr] 24 | (($buf[$offset + 3] as $tip) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($buf[$offset + 3])` [INFO] [stderr] | [INFO] [stderr] ::: src/http/frame/settings.rs:57:24 [INFO] [stderr] | [INFO] [stderr] 57 | let val: u32 = unpack_octets_4!(raw_setting, 2, u32); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/http/frame/settings.rs:64:19 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn get_id(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/http/frame/settings.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match self { [INFO] [stderr] 66 | | &HttpSetting::HeaderTableSize(_) => 1, [INFO] [stderr] 67 | | &HttpSetting::EnablePush(_) => 2, [INFO] [stderr] 68 | | &HttpSetting::MaxConcurrentStreams(_) => 3, [INFO] [stderr] ... | [INFO] [stderr] 71 | | &HttpSetting::MaxHeaderListSize(_) => 6, [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 65 | match *self { [INFO] [stderr] 66 | HttpSetting::HeaderTableSize(_) => 1, [INFO] [stderr] 67 | HttpSetting::EnablePush(_) => 2, [INFO] [stderr] 68 | HttpSetting::MaxConcurrentStreams(_) => 3, [INFO] [stderr] 69 | HttpSetting::InitialWindowSize(_) => 4, [INFO] [stderr] 70 | HttpSetting::MaxFrameSize(_) => 5, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/http/frame/settings.rs:76:20 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn get_val(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/http/frame/settings.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / match self { [INFO] [stderr] 78 | | &HttpSetting::HeaderTableSize(ref val) => val.clone(), [INFO] [stderr] 79 | | &HttpSetting::EnablePush(ref val) => val.clone(), [INFO] [stderr] 80 | | &HttpSetting::MaxConcurrentStreams(ref val) => val.clone(), [INFO] [stderr] ... | [INFO] [stderr] 83 | | &HttpSetting::MaxHeaderListSize(ref val) => val.clone(), [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 77 | match *self { [INFO] [stderr] 78 | HttpSetting::HeaderTableSize(ref val) => val.clone(), [INFO] [stderr] 79 | HttpSetting::EnablePush(ref val) => val.clone(), [INFO] [stderr] 80 | HttpSetting::MaxConcurrentStreams(ref val) => val.clone(), [INFO] [stderr] 81 | HttpSetting::InitialWindowSize(ref val) => val.clone(), [INFO] [stderr] 82 | HttpSetting::MaxFrameSize(ref val) => val.clone(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/http/frame/settings.rs:78:55 [INFO] [stderr] | [INFO] [stderr] 78 | &HttpSetting::HeaderTableSize(ref val) => val.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/http/frame/settings.rs:79:50 [INFO] [stderr] | [INFO] [stderr] 79 | &HttpSetting::EnablePush(ref val) => val.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/http/frame/settings.rs:80:60 [INFO] [stderr] | [INFO] [stderr] 80 | &HttpSetting::MaxConcurrentStreams(ref val) => val.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/http/frame/settings.rs:81:57 [INFO] [stderr] | [INFO] [stderr] 81 | &HttpSetting::InitialWindowSize(ref val) => val.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/http/frame/settings.rs:82:52 [INFO] [stderr] | [INFO] [stderr] 82 | &HttpSetting::MaxFrameSize(ref val) => val.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/http/frame/settings.rs:83:57 [INFO] [stderr] | [INFO] [stderr] 83 | &HttpSetting::MaxHeaderListSize(ref val) => val.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/http/frame/settings.rs:89:18 [INFO] [stderr] | [INFO] [stderr] 89 | fn serialize(&self) -> [u8; 6] { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `id` [INFO] [stderr] --> src/http/frame/settings.rs:93:14 [INFO] [stderr] | [INFO] [stderr] 93 | ((id >> 0) & 0x00FF) as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `val` [INFO] [stderr] --> src/http/frame/settings.rs:97:15 [INFO] [stderr] | [INFO] [stderr] 97 | (((val >> 0) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `http::frame::settings::SettingsFrame` [INFO] [stderr] --> src/http/frame/settings.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn new() -> SettingsFrame { [INFO] [stderr] 155 | | SettingsFrame { [INFO] [stderr] 156 | | settings: Vec::new(), [INFO] [stderr] 157 | | // By default, no flags are set [INFO] [stderr] 158 | | flags: 0, [INFO] [stderr] 159 | | } [INFO] [stderr] 160 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 142 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:53:10 [INFO] [stderr] | [INFO] [stderr] 53 | ((header[0] as u32) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(header[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:54:10 [INFO] [stderr] | [INFO] [stderr] 54 | ((header[1] as u32) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(header[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(header[2] as u32)` [INFO] [stderr] --> src/http/frame/mod.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | ((header[2] as u32) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:55:10 [INFO] [stderr] | [INFO] [stderr] 55 | ((header[2] as u32) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(header[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:21:10 [INFO] [stderr] | [INFO] [stderr] 21 | (($buf[$offset + 0] as $tip) << 24) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($buf[$offset + 0])` [INFO] [stderr] ... [INFO] [stderr] 58 | let stream_id: u32 = unpack_octets_4!(header, 5, u32); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:22:10 [INFO] [stderr] | [INFO] [stderr] 22 | (($buf[$offset + 1] as $tip) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($buf[$offset + 1])` [INFO] [stderr] ... [INFO] [stderr] 58 | let stream_id: u32 = unpack_octets_4!(header, 5, u32); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:23:10 [INFO] [stderr] | [INFO] [stderr] 23 | (($buf[$offset + 2] as $tip) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($buf[$offset + 2])` [INFO] [stderr] ... [INFO] [stderr] 58 | let stream_id: u32 = unpack_octets_4!(header, 5, u32); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/http/frame/mod.rs:24:10 [INFO] [stderr] | [INFO] [stderr] 24 | (($buf[$offset + 3] as $tip) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($buf[$offset + 3])` [INFO] [stderr] ... [INFO] [stderr] 58 | let stream_id: u32 = unpack_octets_4!(header, 5, u32); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `length` [INFO] [stderr] --> src/http/frame/mod.rs:70:11 [INFO] [stderr] | [INFO] [stderr] 70 | (((length >> 0) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `stream_id` [INFO] [stderr] --> src/http/frame/mod.rs:76:11 [INFO] [stderr] | [INFO] [stderr] 76 | (((stream_id >> 0) & 0x000000FF) as u8), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/http/frame/mod.rs:92:1 [INFO] [stderr] | [INFO] [stderr] 92 | / fn parse_padded_payload<'a>(payload: &'a [u8]) -> Option<(&'a [u8], u8)> { [INFO] [stderr] 93 | | if payload.len() == 0 { [INFO] [stderr] 94 | | // We make sure not to index the payload before we're sure how [INFO] [stderr] 95 | | // large the buffer is. [INFO] [stderr] ... | [INFO] [stderr] 108 | | Some((&payload[1..payload.len() - pad_len], pad_len as u8)) [INFO] [stderr] 109 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/http/frame/mod.rs:93:8 [INFO] [stderr] | [INFO] [stderr] 93 | if payload.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `payload.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/http/frame/mod.rs:182:20 [INFO] [stderr] | [INFO] [stderr] 182 | raw.extend(pack_header(&header).into_iter().map(|x| *x)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `pack_header(&header).into_iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/http/frame/mod.rs:182:41 [INFO] [stderr] | [INFO] [stderr] 182 | raw.extend(pack_header(&header).into_iter().map(|x| *x)); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into-iter-on-array` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const u8`) to a reference type (`&[u8; 9]`) [INFO] [stderr] --> src/http/frame/mod.rs:206:13 [INFO] [stderr] | [INFO] [stderr] 206 | mem::transmute(buf.as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(buf.as_ptr() as *const [u8; 9])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const u8`) to a reference type (`&[u8; 9]`) [INFO] [stderr] --> src/http/frame/mod.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | mem::transmute(self.raw_content.as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self.raw_content.as_ptr() as *const [u8; 9])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/http/frame/mod.rs:356:42 [INFO] [stderr] | [INFO] [stderr] 356 | let raw = RawFrame::with_payload(header.clone(), payload.to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/http/connection.rs:485:49 [INFO] [stderr] | [INFO] [stderr] 485 | .map_err(|e| HttpError::CompressionError(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HttpError::CompressionError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/http/connection.rs:640:65 [INFO] [stderr] | [INFO] [stderr] 640 | let mut stream = StubTransportStream::with_stub_content(&vec![]); [INFO] [stderr] | ^^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/http/connection.rs:856:25 [INFO] [stderr] | [INFO] [stderr] 856 | let frame = match frame { [INFO] [stderr] | _________________________^ [INFO] [stderr] 857 | | &HttpFrame::DataFrame(ref frame) => frame, [INFO] [stderr] 858 | | _ => panic!("Expected a data frame"), [INFO] [stderr] 859 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 856 | let frame = match *frame { [INFO] [stderr] 857 | HttpFrame::DataFrame(ref frame) => frame, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `http::session::DefaultSessionState` [INFO] [stderr] --> src/http/session.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | / pub fn new() -> DefaultSessionState { [INFO] [stderr] 102 | | DefaultSessionState { [INFO] [stderr] 103 | | streams: HashMap::new(), [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 94 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/http/session.rs:335:9 [INFO] [stderr] | [INFO] [stderr] 335 | / match chunk { [INFO] [stderr] 336 | | StreamDataChunk::Last(_) => self.close_local(), [INFO] [stderr] 337 | | _ => {}, [INFO] [stderr] 338 | | }; [INFO] [stderr] | |_________^ help: try this: `if let StreamDataChunk::Last(_) = chunk { self.close_local() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/http/session.rs:397:36 [INFO] [stderr] | [INFO] [stderr] 397 | assert_eq!(state.iter().collect::>().len(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/http/client/mod.rs:555:32 [INFO] [stderr] | [INFO] [stderr] 555 | assert_eq!(state.iter().collect::>().len(), 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/http/client/mod.rs:561:32 [INFO] [stderr] | [INFO] [stderr] 561 | assert_eq!(state.iter().collect::>().len(), 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const u8`) to a reference type (`&[u8; 9]`) [INFO] [stderr] --> src/http/client/mod.rs:576:17 [INFO] [stderr] | [INFO] [stderr] 576 | mem::transmute(buf.as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(buf.as_ptr() as *const [u8; 9])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/http/server.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / match self.state.get_stream_mut(stream_id) { [INFO] [stderr] 55 | | Some(stream) => { [INFO] [stderr] 56 | | // This'd correspond to having received trailers... [INFO] [stderr] 57 | | stream.set_headers(headers); [INFO] [stderr] ... | [INFO] [stderr] 60 | | None => {}, [INFO] [stderr] 61 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 54 | if let Some(stream) = self.state.get_stream_mut(stream_id) { [INFO] [stderr] 55 | // This'd correspond to having received trailers... [INFO] [stderr] 56 | stream.set_headers(headers); [INFO] [stderr] 57 | return; [INFO] [stderr] 58 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/http/mod.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn as_bytes(&self) -> &'static [u8] { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/http/mod.rs:170:12 [INFO] [stderr] | [INFO] [stderr] 170 | if self.headers.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.headers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/http/mod.rs:173:12 [INFO] [stderr] | [INFO] [stderr] 173 | if &self.headers[0].0 != &b":status" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 173 | if self.headers[0].0 != b":status" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/http/mod.rs:199:18 [INFO] [stderr] | [INFO] [stderr] 199 | Ok(100 * ((buf[0] - b'0') as u16) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[0] - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/http/mod.rs:200:17 [INFO] [stderr] | [INFO] [stderr] 200 | 10 * ((buf[1] - b'0') as u16) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1] - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `((buf[2] - b'0') as u16)` [INFO] [stderr] --> src/http/mod.rs:201:12 [INFO] [stderr] | [INFO] [stderr] 201 | 1 * ((buf[2] - b'0') as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/http/mod.rs:201:16 [INFO] [stderr] | [INFO] [stderr] 201 | 1 * ((buf[2] - b'0') as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf[2] - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `http::tests::common::MockSendFrame` [INFO] [stderr] --> src/http/tests/common.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn new() -> MockSendFrame { [INFO] [stderr] 43 | | MockSendFrame { sent: Vec::new() } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/http/tests/common.rs:69:12 [INFO] [stderr] | [INFO] [stderr] 69 | if self.recv_list.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.recv_list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/http/tests/common.rs:161:39 [INFO] [stderr] | [INFO] [stderr] 161 | pub fn build_stub_from_frames(frames: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[HttpFrame]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/http/tests/common.rs:164:26 [INFO] [stderr] | [INFO] [stderr] 164 | let serialized = match frame { [INFO] [stderr] | __________________________^ [INFO] [stderr] 165 | | &HttpFrame::DataFrame(ref frame) => frame.serialize(), [INFO] [stderr] 166 | | &HttpFrame::HeadersFrame(ref frame) => frame.serialize(), [INFO] [stderr] 167 | | &HttpFrame::SettingsFrame(ref frame) => frame.serialize(), [INFO] [stderr] 168 | | &HttpFrame::UnknownFrame(ref frame) => frame.serialize(), [INFO] [stderr] 169 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 164 | let serialized = match *frame { [INFO] [stderr] 165 | HttpFrame::DataFrame(ref frame) => frame.serialize(), [INFO] [stderr] 166 | HttpFrame::HeadersFrame(ref frame) => frame.serialize(), [INFO] [stderr] 167 | HttpFrame::SettingsFrame(ref frame) => frame.serialize(), [INFO] [stderr] 168 | HttpFrame::UnknownFrame(ref frame) => frame.serialize(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/http/tests/common.rs:182:65 [INFO] [stderr] | [INFO] [stderr] 182 | let mut stream = StubTransportStream::with_stub_content(&vec![]); [INFO] [stderr] | ^^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/http/tests/common.rs:189:65 [INFO] [stderr] | [INFO] [stderr] 189 | let mut stream = StubTransportStream::with_stub_content(&vec![]); [INFO] [stderr] | ^^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/http/tests/common.rs:196:65 [INFO] [stderr] | [INFO] [stderr] 196 | let mut stream = StubTransportStream::with_stub_content(&vec![3, 4]); [INFO] [stderr] | ^^^^^^^^^^^ help: you can use a slice directly: `&[3, 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/http/tests/common.rs:199:9 [INFO] [stderr] | [INFO] [stderr] 199 | stream.write(&[1]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/http/tests/common.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | other.write(&[2]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/http/tests/common.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | stream.read(&mut buf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/http/tests/common.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | other.read(&mut buf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/http/tests/common.rs:212:65 [INFO] [stderr] | [INFO] [stderr] 212 | let mut stream = StubTransportStream::with_stub_content(&vec![3, 4]); [INFO] [stderr] | ^^^^^^^^^^^ help: you can use a slice directly: `&[3, 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `http::tests::common::TestSession` [INFO] [stderr] --> src/http/tests/common.rs:247:5 [INFO] [stderr] | [INFO] [stderr] 247 | / pub fn new() -> TestSession { [INFO] [stderr] 248 | | TestSession { [INFO] [stderr] 249 | | silent: true, [INFO] [stderr] 250 | | headers: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 254 | | } [INFO] [stderr] 255 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 232 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/http/tests/common.rs:339:9 [INFO] [stderr] | [INFO] [stderr] 339 | / match chunk { [INFO] [stderr] 340 | | StreamDataChunk::Last(_) => self.close_local(), [INFO] [stderr] 341 | | _ => {}, [INFO] [stderr] 342 | | }; [INFO] [stderr] | |_________^ help: try this: `if let StreamDataChunk::Last(_) = chunk { self.close_local() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/http/tests/common.rs:365:12 [INFO] [stderr] | [INFO] [stderr] 365 | if self.chunks.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.chunks.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/client/async.rs:299:5 [INFO] [stderr] | [INFO] [stderr] 299 | / pub fn new(client_stream: ClientStream) -> Option> [INFO] [stderr] 300 | | where S: TransportStream { [INFO] [stderr] 301 | | let (tx, rx): (Sender, Receiver) = [INFO] [stderr] 302 | | mpsc::channel(); [INFO] [stderr] ... | [INFO] [stderr] 336 | | Some(Service(service, tx, recv_frame, send_frame)) [INFO] [stderr] 337 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/client/async.rs:525:16 [INFO] [stderr] | [INFO] [stderr] 525 | if self.request_queue.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.request_queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/client/async.rs:626:16 [INFO] [stderr] | [INFO] [stderr] 626 | if let Err(_) = rx.send(WorkItem::NewClient) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 627 | | return None; [INFO] [stderr] 628 | | } [INFO] [stderr] | |_________- help: try this: `if rx.send(WorkItem::NewClient).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `solicit`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a209606e0db7abdf21530d3e12326cf4e4816a89a1840601f885c2b4fa99bfac"` [INFO] running `"docker" "rm" "-f" "a209606e0db7abdf21530d3e12326cf4e4816a89a1840601f885c2b4fa99bfac"` [INFO] [stdout] a209606e0db7abdf21530d3e12326cf4e4816a89a1840601f885c2b4fa99bfac