[INFO] crate slr_parser 0.0.17 is already in cache [INFO] extracting crate slr_parser 0.0.17 into work/ex/clippy-test-run/sources/stable/reg/slr_parser/0.0.17 [INFO] extracting crate slr_parser 0.0.17 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slr_parser/0.0.17 [INFO] validating manifest of slr_parser-0.0.17 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of slr_parser-0.0.17 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing slr_parser-0.0.17 [INFO] removed 0 missing examples [INFO] finished frobbing slr_parser-0.0.17 [INFO] frobbed toml for slr_parser-0.0.17 written to work/ex/clippy-test-run/sources/stable/reg/slr_parser/0.0.17/Cargo.toml [INFO] started frobbing slr_parser-0.0.17 [INFO] removed 0 missing examples [INFO] finished frobbing slr_parser-0.0.17 [INFO] frobbed toml for slr_parser-0.0.17 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slr_parser/0.0.17/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting slr_parser-0.0.17 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slr_parser/0.0.17:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 78a9d69a3806e5cbab5264b76b7631073272de5951dfd5ae68390b332ef33568 [INFO] running `"docker" "start" "-a" "78a9d69a3806e5cbab5264b76b7631073272de5951dfd5ae68390b332ef33568"` [INFO] [stderr] Checking slr_parser v0.0.17 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:132:11 [INFO] [stderr] | [INFO] [stderr] 132 | Token { kind: kind, span: span } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:132:23 [INFO] [stderr] | [INFO] [stderr] 132 | Token { kind: kind, span: span } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:209:4 [INFO] [stderr] | [INFO] [stderr] 209 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:210:4 [INFO] [stderr] | [INFO] [stderr] 210 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:211:4 [INFO] [stderr] | [INFO] [stderr] 211 | chars: chars, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:298:34 [INFO] [stderr] | [INFO] [stderr] 298 | Span { start: self.span_start, len: len } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:396:11 [INFO] [stderr] | [INFO] [stderr] 396 | Error { kind: kind, text: text } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:396:23 [INFO] [stderr] | [INFO] [stderr] 396 | Error { kind: kind, text: text } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:496:4 [INFO] [stderr] | [INFO] [stderr] 496 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:53:18 [INFO] [stderr] | [INFO] [stderr] 53 | ConfigString { kind: kind, span: tok.span } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:419:3 [INFO] [stderr] | [INFO] [stderr] 419 | lexer: lexer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lexer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:420:3 [INFO] [stderr] | [INFO] [stderr] 420 | visitor: visitor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `visitor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/printer.rs:24:4 [INFO] [stderr] | [INFO] [stderr] 24 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:132:11 [INFO] [stderr] | [INFO] [stderr] 132 | Token { kind: kind, span: span } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:132:23 [INFO] [stderr] | [INFO] [stderr] 132 | Token { kind: kind, span: span } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `span` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:209:4 [INFO] [stderr] | [INFO] [stderr] 209 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:210:4 [INFO] [stderr] | [INFO] [stderr] 210 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:211:4 [INFO] [stderr] | [INFO] [stderr] 211 | chars: chars, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:298:34 [INFO] [stderr] | [INFO] [stderr] 298 | Span { start: self.span_start, len: len } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:396:11 [INFO] [stderr] | [INFO] [stderr] 396 | Error { kind: kind, text: text } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:396:23 [INFO] [stderr] | [INFO] [stderr] 396 | Error { kind: kind, text: text } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:496:4 [INFO] [stderr] | [INFO] [stderr] 496 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:53:18 [INFO] [stderr] | [INFO] [stderr] 53 | ConfigString { kind: kind, span: tok.span } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:419:3 [INFO] [stderr] | [INFO] [stderr] 419 | lexer: lexer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lexer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:420:3 [INFO] [stderr] | [INFO] [stderr] 420 | visitor: visitor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `visitor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/printer.rs:24:4 [INFO] [stderr] | [INFO] [stderr] 24 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:66:3 [INFO] [stderr] | [INFO] [stderr] 66 | return StringQuoteType::Naked; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `StringQuoteType::Naked` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lexer.rs:696:3 [INFO] [stderr] | [INFO] [stderr] 696 | { [INFO] [stderr] | _________^ [INFO] [stderr] 697 | | if num_leading_braces == 0 [INFO] [stderr] 698 | | { [INFO] [stderr] 699 | | Some(Ok(Token::new(TokenKind::EscapedString(&self.source.source[start_pos..end_pos]), self.source.get_span()))) [INFO] [stderr] ... | [INFO] [stderr] 704 | | } [INFO] [stderr] 705 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 696 | if num_leading_braces == 0 [INFO] [stderr] 697 | { [INFO] [stderr] 698 | Some(Ok(Token::new(TokenKind::EscapedString(&self.source.source[start_pos..end_pos]), self.source.get_span()))) [INFO] [stderr] 699 | } [INFO] [stderr] 700 | else [INFO] [stderr] 701 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/printer.rs:78:3 [INFO] [stderr] | [INFO] [stderr] 78 | { [INFO] [stderr] | _________^ [INFO] [stderr] 79 | | if !self.is_empty() [INFO] [stderr] 80 | | { [INFO] [stderr] 81 | | try!(write!(self.writer, " ")); [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 78 | if !self.is_empty() [INFO] [stderr] 79 | { [INFO] [stderr] 80 | try!(write!(self.writer, " ")); [INFO] [stderr] 81 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:66:3 [INFO] [stderr] | [INFO] [stderr] 66 | return StringQuoteType::Naked; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `StringQuoteType::Naked` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lexer.rs:696:3 [INFO] [stderr] | [INFO] [stderr] 696 | { [INFO] [stderr] | _________^ [INFO] [stderr] 697 | | if num_leading_braces == 0 [INFO] [stderr] 698 | | { [INFO] [stderr] 699 | | Some(Ok(Token::new(TokenKind::EscapedString(&self.source.source[start_pos..end_pos]), self.source.get_span()))) [INFO] [stderr] ... | [INFO] [stderr] 704 | | } [INFO] [stderr] 705 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 696 | if num_leading_braces == 0 [INFO] [stderr] 697 | { [INFO] [stderr] 698 | Some(Ok(Token::new(TokenKind::EscapedString(&self.source.source[start_pos..end_pos]), self.source.get_span()))) [INFO] [stderr] 699 | } [INFO] [stderr] 700 | else [INFO] [stderr] 701 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/printer.rs:78:3 [INFO] [stderr] | [INFO] [stderr] 78 | { [INFO] [stderr] | _________^ [INFO] [stderr] 79 | | if !self.is_empty() [INFO] [stderr] 80 | | { [INFO] [stderr] 81 | | try!(write!(self.writer, " ")); [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 78 | if !self.is_empty() [INFO] [stderr] 79 | { [INFO] [stderr] 80 | try!(write!(self.writer, " ")); [INFO] [stderr] 81 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/parser.rs:170:12 [INFO] [stderr] | [INFO] [stderr] 170 | None => return $err [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 364 | let token = try_eof!(self.lexer.cur_token, [INFO] [stderr] | _________________________- [INFO] [stderr] 365 | | match last_span [INFO] [stderr] 366 | | { [INFO] [stderr] 367 | | Some(span) => [INFO] [stderr] ... | [INFO] [stderr] 371 | | None => return Ok(false), [INFO] [stderr] 372 | | }); [INFO] [stderr] | |___________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/parser.rs:170:12 [INFO] [stderr] | [INFO] [stderr] 170 | None => return $err [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 364 | let token = try_eof!(self.lexer.cur_token, [INFO] [stderr] | _________________________- [INFO] [stderr] 365 | | match last_span [INFO] [stderr] 366 | | { [INFO] [stderr] 367 | | Some(span) => [INFO] [stderr] ... | [INFO] [stderr] 371 | | None => return Ok(false), [INFO] [stderr] 372 | | }); [INFO] [stderr] | |___________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `lexer::Span` [INFO] [stderr] --> src/lexer.rs:97:2 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn new() -> Span [INFO] [stderr] | _____^ [INFO] [stderr] 98 | | { [INFO] [stderr] 99 | | Span { start: usize::MAX, len: 0 } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 89 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lexer.rs:250:57 [INFO] [stderr] | [INFO] [stderr] 250 | let end = match self.source[start..].chars().position(|c| is_newline(c)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `is_newline` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lexer.rs:335:49 [INFO] [stderr] | [INFO] [stderr] 335 | self.at_newline = self.cur_char.map_or(false, |c| is_newline(c)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `is_newline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lexer.rs:621:3 [INFO] [stderr] | [INFO] [stderr] 621 | loop [INFO] [stderr] | _________^ [INFO] [stderr] 622 | | { [INFO] [stderr] 623 | | match self.source.cur_char [INFO] [stderr] 624 | | { [INFO] [stderr] ... | [INFO] [stderr] 649 | | [INFO] [stderr] 650 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(c) = self.source.cur_char { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lexer.rs:656:3 [INFO] [stderr] | [INFO] [stderr] 656 | loop [INFO] [stderr] | _________^ [INFO] [stderr] 657 | | { [INFO] [stderr] 658 | | match self.source.cur_char [INFO] [stderr] 659 | | { [INFO] [stderr] ... | [INFO] [stderr] 688 | | self.source.bump(); [INFO] [stderr] 689 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(c) = self.source.cur_char { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lexer.rs:732:2 [INFO] [stderr] | [INFO] [stderr] 732 | pub fn next(&mut self) -> Option, Error>> [INFO] [stderr] | _____^ [INFO] [stderr] 733 | | { [INFO] [stderr] 734 | | if self.cur_token.as_ref().map_or(true, |res| res.is_ok()) [INFO] [stderr] 735 | | { [INFO] [stderr] ... | [INFO] [stderr] 744 | | self.cur_token.clone() [INFO] [stderr] 745 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/parser.rs:255:5 [INFO] [stderr] | [INFO] [stderr] 255 | { [INFO] [stderr] | _________________^ [INFO] [stderr] 256 | | true [INFO] [stderr] 257 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/parser.rs:251:5 [INFO] [stderr] | [INFO] [stderr] 251 | { [INFO] [stderr] | _________________^ [INFO] [stderr] 252 | | true [INFO] [stderr] 253 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/printer.rs:111:3 [INFO] [stderr] | [INFO] [stderr] 111 | match name [INFO] [stderr] | _________^ [INFO] [stderr] 112 | | { [INFO] [stderr] 113 | | Some(name) => [INFO] [stderr] 114 | | { [INFO] [stderr] ... | [INFO] [stderr] 118 | | _ => (), [INFO] [stderr] 119 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 111 | if let Some(name) = name { [INFO] [stderr] 112 | try!(self.write_string(name)); [INFO] [stderr] 113 | try!(write!(self.writer, " = ")); [INFO] [stderr] 114 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/printer.rs:128:3 [INFO] [stderr] | [INFO] [stderr] 128 | match name [INFO] [stderr] | _________^ [INFO] [stderr] 129 | | { [INFO] [stderr] 130 | | Some(name) => [INFO] [stderr] 131 | | { [INFO] [stderr] ... | [INFO] [stderr] 144 | | _ => (), [INFO] [stderr] 145 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 128 | if let Some(name) = name { [INFO] [stderr] 129 | try!(self.write_string(name)); [INFO] [stderr] 130 | try!(write!(self.writer, " =")); [INFO] [stderr] 131 | if one_line [INFO] [stderr] 132 | { [INFO] [stderr] 133 | try!(write!(self.writer, " ")); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/printer.rs:181:3 [INFO] [stderr] | [INFO] [stderr] 181 | match name [INFO] [stderr] | _________^ [INFO] [stderr] 182 | | { [INFO] [stderr] 183 | | Some(name) => [INFO] [stderr] 184 | | { [INFO] [stderr] ... | [INFO] [stderr] 196 | | _ => (), [INFO] [stderr] 197 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 181 | if let Some(name) = name { [INFO] [stderr] 182 | try!(self.write_string(name)); [INFO] [stderr] 183 | if one_line [INFO] [stderr] 184 | { [INFO] [stderr] 185 | try!(write!(self.writer, " ")); [INFO] [stderr] 186 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `slr_parser`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `lexer::Span` [INFO] [stderr] --> src/lexer.rs:97:2 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn new() -> Span [INFO] [stderr] | _____^ [INFO] [stderr] 98 | | { [INFO] [stderr] 99 | | Span { start: usize::MAX, len: 0 } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 89 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lexer.rs:250:57 [INFO] [stderr] | [INFO] [stderr] 250 | let end = match self.source[start..].chars().position(|c| is_newline(c)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `is_newline` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lexer.rs:335:49 [INFO] [stderr] | [INFO] [stderr] 335 | self.at_newline = self.cur_char.map_or(false, |c| is_newline(c)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `is_newline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lexer.rs:621:3 [INFO] [stderr] | [INFO] [stderr] 621 | loop [INFO] [stderr] | _________^ [INFO] [stderr] 622 | | { [INFO] [stderr] 623 | | match self.source.cur_char [INFO] [stderr] 624 | | { [INFO] [stderr] ... | [INFO] [stderr] 649 | | [INFO] [stderr] 650 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(c) = self.source.cur_char { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lexer.rs:656:3 [INFO] [stderr] | [INFO] [stderr] 656 | loop [INFO] [stderr] | _________^ [INFO] [stderr] 657 | | { [INFO] [stderr] 658 | | match self.source.cur_char [INFO] [stderr] 659 | | { [INFO] [stderr] ... | [INFO] [stderr] 688 | | self.source.bump(); [INFO] [stderr] 689 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(c) = self.source.cur_char { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lexer.rs:732:2 [INFO] [stderr] | [INFO] [stderr] 732 | pub fn next(&mut self) -> Option, Error>> [INFO] [stderr] | _____^ [INFO] [stderr] 733 | | { [INFO] [stderr] 734 | | if self.cur_token.as_ref().map_or(true, |res| res.is_ok()) [INFO] [stderr] 735 | | { [INFO] [stderr] ... | [INFO] [stderr] 744 | | self.cur_token.clone() [INFO] [stderr] 745 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/parser.rs:255:5 [INFO] [stderr] | [INFO] [stderr] 255 | { [INFO] [stderr] | _________________^ [INFO] [stderr] 256 | | true [INFO] [stderr] 257 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/parser.rs:251:5 [INFO] [stderr] | [INFO] [stderr] 251 | { [INFO] [stderr] | _________________^ [INFO] [stderr] 252 | | true [INFO] [stderr] 253 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/printer.rs:111:3 [INFO] [stderr] | [INFO] [stderr] 111 | match name [INFO] [stderr] | _________^ [INFO] [stderr] 112 | | { [INFO] [stderr] 113 | | Some(name) => [INFO] [stderr] 114 | | { [INFO] [stderr] ... | [INFO] [stderr] 118 | | _ => (), [INFO] [stderr] 119 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 111 | if let Some(name) = name { [INFO] [stderr] 112 | try!(self.write_string(name)); [INFO] [stderr] 113 | try!(write!(self.writer, " = ")); [INFO] [stderr] 114 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/printer.rs:128:3 [INFO] [stderr] | [INFO] [stderr] 128 | match name [INFO] [stderr] | _________^ [INFO] [stderr] 129 | | { [INFO] [stderr] 130 | | Some(name) => [INFO] [stderr] 131 | | { [INFO] [stderr] ... | [INFO] [stderr] 144 | | _ => (), [INFO] [stderr] 145 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 128 | if let Some(name) = name { [INFO] [stderr] 129 | try!(self.write_string(name)); [INFO] [stderr] 130 | try!(write!(self.writer, " =")); [INFO] [stderr] 131 | if one_line [INFO] [stderr] 132 | { [INFO] [stderr] 133 | try!(write!(self.writer, " ")); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/printer.rs:181:3 [INFO] [stderr] | [INFO] [stderr] 181 | match name [INFO] [stderr] | _________^ [INFO] [stderr] 182 | | { [INFO] [stderr] 183 | | Some(name) => [INFO] [stderr] 184 | | { [INFO] [stderr] ... | [INFO] [stderr] 196 | | _ => (), [INFO] [stderr] 197 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 181 | if let Some(name) = name { [INFO] [stderr] 182 | try!(self.write_string(name)); [INFO] [stderr] 183 | if one_line [INFO] [stderr] 184 | { [INFO] [stderr] 185 | try!(write!(self.writer, " ")); [INFO] [stderr] 186 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `slr_parser`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "78a9d69a3806e5cbab5264b76b7631073272de5951dfd5ae68390b332ef33568"` [INFO] running `"docker" "rm" "-f" "78a9d69a3806e5cbab5264b76b7631073272de5951dfd5ae68390b332ef33568"` [INFO] [stdout] 78a9d69a3806e5cbab5264b76b7631073272de5951dfd5ae68390b332ef33568