[INFO] crate slim 0.1.0 is already in cache [INFO] extracting crate slim 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/slim/0.1.0 [INFO] extracting crate slim 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slim/0.1.0 [INFO] validating manifest of slim-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of slim-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing slim-0.1.0 [INFO] finished frobbing slim-0.1.0 [INFO] frobbed toml for slim-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/slim/0.1.0/Cargo.toml [INFO] started frobbing slim-0.1.0 [INFO] finished frobbing slim-0.1.0 [INFO] frobbed toml for slim-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slim/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting slim-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slim/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2384713c8756dbffea553b1bf8fdd1bcb3e04e9355f298dbcc8b6ac9a57896bf [INFO] running `"docker" "start" "-a" "2384713c8756dbffea553b1bf8fdd1bcb3e04e9355f298dbcc8b6ac9a57896bf"` [INFO] [stderr] Checking slim v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize.rs:55:45 [INFO] [stderr] | [INFO] [stderr] 55 | ErrorKind::UnexpectedEof => return Err(SlimError::StreamClosed), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(SlimError::StreamClosed)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize.rs:56:22 [INFO] [stderr] | [INFO] [stderr] 56 | _ => return Err(SlimError::StreamError), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(SlimError::StreamError)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | Ok(_) => return Ok(()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/deserialize.rs:18:45 [INFO] [stderr] | [INFO] [stderr] 18 | ErrorKind::UnexpectedEof => return Err(SlimError::StreamClosed), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(SlimError::StreamClosed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/deserialize.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | _ => return Err(SlimError::StreamError), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(SlimError::StreamError)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/deserialize.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return Err(SlimError::DeserializationError); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(SlimError::DeserializationError)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/deserialize.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | return Err(SlimError::DeserializationError); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(SlimError::DeserializationError)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Result` [INFO] [stderr] --> src/transportable.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | use super::{SlimError, Result}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serialize.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | / match self { [INFO] [stderr] 107 | | &Ok(ref a) => { [INFO] [stderr] 108 | | try!(0u8.encode_stream(s)); [INFO] [stderr] 109 | | a.encode_stream(s) [INFO] [stderr] ... | [INFO] [stderr] 114 | | } [INFO] [stderr] 115 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 106 | match *self { [INFO] [stderr] 107 | Ok(ref a) => { [INFO] [stderr] 108 | try!(0u8.encode_stream(s)); [INFO] [stderr] 109 | a.encode_stream(s) [INFO] [stderr] 110 | } [INFO] [stderr] 111 | Err(ref a) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serialize.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | / match self { [INFO] [stderr] 127 | | &None => 0u8.encode_stream(s), [INFO] [stderr] 128 | | &Some(ref a) => { [INFO] [stderr] 129 | | try!(1u8.encode_stream(s)); [INFO] [stderr] 130 | | a.encode_stream(s) [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 126 | match *self { [INFO] [stderr] 127 | None => 0u8.encode_stream(s), [INFO] [stderr] 128 | Some(ref a) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize.rs:55:45 [INFO] [stderr] | [INFO] [stderr] 55 | ErrorKind::UnexpectedEof => return Err(SlimError::StreamClosed), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(SlimError::StreamClosed)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize.rs:56:22 [INFO] [stderr] | [INFO] [stderr] 56 | _ => return Err(SlimError::StreamError), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(SlimError::StreamError)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialize.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | Ok(_) => return Ok(()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/deserialize.rs:18:45 [INFO] [stderr] | [INFO] [stderr] 18 | ErrorKind::UnexpectedEof => return Err(SlimError::StreamClosed), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(SlimError::StreamClosed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/deserialize.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | _ => return Err(SlimError::StreamError), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(SlimError::StreamError)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/deserialize.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return Err(SlimError::DeserializationError); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(SlimError::DeserializationError)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/deserialize.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | return Err(SlimError::DeserializationError); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(SlimError::DeserializationError)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Result` [INFO] [stderr] --> src/transportable.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | use super::{SlimError, Result}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serialize.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | / match self { [INFO] [stderr] 107 | | &Ok(ref a) => { [INFO] [stderr] 108 | | try!(0u8.encode_stream(s)); [INFO] [stderr] 109 | | a.encode_stream(s) [INFO] [stderr] ... | [INFO] [stderr] 114 | | } [INFO] [stderr] 115 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 106 | match *self { [INFO] [stderr] 107 | Ok(ref a) => { [INFO] [stderr] 108 | try!(0u8.encode_stream(s)); [INFO] [stderr] 109 | a.encode_stream(s) [INFO] [stderr] 110 | } [INFO] [stderr] 111 | Err(ref a) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serialize.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | / match self { [INFO] [stderr] 127 | | &None => 0u8.encode_stream(s), [INFO] [stderr] 128 | | &Some(ref a) => { [INFO] [stderr] 129 | | try!(1u8.encode_stream(s)); [INFO] [stderr] 130 | | a.encode_stream(s) [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 126 | match *self { [INFO] [stderr] 127 | None => 0u8.encode_stream(s), [INFO] [stderr] 128 | Some(ref a) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.89s [INFO] running `"docker" "inspect" "2384713c8756dbffea553b1bf8fdd1bcb3e04e9355f298dbcc8b6ac9a57896bf"` [INFO] running `"docker" "rm" "-f" "2384713c8756dbffea553b1bf8fdd1bcb3e04e9355f298dbcc8b6ac9a57896bf"` [INFO] [stdout] 2384713c8756dbffea553b1bf8fdd1bcb3e04e9355f298dbcc8b6ac9a57896bf