[INFO] crate slice-pool 0.3.4 is already in cache [INFO] extracting crate slice-pool 0.3.4 into work/ex/clippy-test-run/sources/stable/reg/slice-pool/0.3.4 [INFO] extracting crate slice-pool 0.3.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slice-pool/0.3.4 [INFO] validating manifest of slice-pool-0.3.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of slice-pool-0.3.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing slice-pool-0.3.4 [INFO] finished frobbing slice-pool-0.3.4 [INFO] frobbed toml for slice-pool-0.3.4 written to work/ex/clippy-test-run/sources/stable/reg/slice-pool/0.3.4/Cargo.toml [INFO] started frobbing slice-pool-0.3.4 [INFO] finished frobbing slice-pool-0.3.4 [INFO] frobbed toml for slice-pool-0.3.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slice-pool/0.3.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting slice-pool-0.3.4 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/slice-pool/0.3.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9540a054787990711b9c1053f43e2379c363549a1ea1e8c6b2afaed8ff60fd26 [INFO] running `"docker" "start" "-a" "9540a054787990711b9c1053f43e2379c363549a1ea1e8c6b2afaed8ff60fd26"` [INFO] [stderr] Checking slice-pool v0.3.4 (/opt/crater/workdir) [INFO] [stderr] warning: item `owned::SlicePool` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/owned.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / impl SlicePool { [INFO] [stderr] 17 | | /// Takes ownership of a slice with a chunkable interface [INFO] [stderr] 18 | | pub fn new + 'static>(data: Data) -> Self { [INFO] [stderr] 19 | | SlicePool(Arc::new(Mutex::new(ChunkableInner { [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/owned.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / fn deref_mut<'b>(&'b mut self) -> &'b mut [T] { [INFO] [stderr] 70 | | self.data [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/owned.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | self.memory.deref().as_ref().as_ptr().offset(chunk.offset as isize) == slice.as_ptr() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.memory.deref().as_ref().as_ptr().add(chunk.offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: item `refd::SlicePoolRef<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/refd.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / impl<'a, T> SlicePoolRef<'a, T> { [INFO] [stderr] 12 | | /// Wraps a slice with a chunkable interface. [INFO] [stderr] 13 | | pub fn new(slice: &'a mut [T]) -> Self { [INFO] [stderr] 14 | | SlicePoolRef(Rc::new(RefCell::new(ChunkableInner { [INFO] [stderr] ... | [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/refd.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | (*self.0).borrow().memory.deref().as_ref().as_ptr() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `(*self.0).borrow().memory.deref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/refd.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / fn deref<'b>(&'b self) -> &'b Self::Target { [INFO] [stderr] 59 | | &self.data [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/refd.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / fn deref_mut<'b>(&'b mut self) -> &'b mut [T] { [INFO] [stderr] 65 | | self.data [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/refd.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | self.memory.as_ptr().offset(chunk.offset as isize) == slice.as_ptr() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.memory.as_ptr().add(chunk.offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: item `owned::SlicePool` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/owned.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / impl SlicePool { [INFO] [stderr] 17 | | /// Takes ownership of a slice with a chunkable interface [INFO] [stderr] 18 | | pub fn new + 'static>(data: Data) -> Self { [INFO] [stderr] 19 | | SlicePool(Arc::new(Mutex::new(ChunkableInner { [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/owned.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / fn deref_mut<'b>(&'b mut self) -> &'b mut [T] { [INFO] [stderr] 70 | | self.data [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/owned.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | self.memory.deref().as_ref().as_ptr().offset(chunk.offset as isize) == slice.as_ptr() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.memory.deref().as_ref().as_ptr().add(chunk.offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: item `refd::SlicePoolRef<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/refd.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / impl<'a, T> SlicePoolRef<'a, T> { [INFO] [stderr] 12 | | /// Wraps a slice with a chunkable interface. [INFO] [stderr] 13 | | pub fn new(slice: &'a mut [T]) -> Self { [INFO] [stderr] 14 | | SlicePoolRef(Rc::new(RefCell::new(ChunkableInner { [INFO] [stderr] ... | [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/refd.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | (*self.0).borrow().memory.deref().as_ref().as_ptr() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `(*self.0).borrow().memory.deref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/refd.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / fn deref<'b>(&'b self) -> &'b Self::Target { [INFO] [stderr] 59 | | &self.data [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/refd.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / fn deref_mut<'b>(&'b mut self) -> &'b mut [T] { [INFO] [stderr] 65 | | self.data [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/refd.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | self.memory.as_ptr().offset(chunk.offset as isize) == slice.as_ptr() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.memory.as_ptr().add(chunk.offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.98s [INFO] running `"docker" "inspect" "9540a054787990711b9c1053f43e2379c363549a1ea1e8c6b2afaed8ff60fd26"` [INFO] running `"docker" "rm" "-f" "9540a054787990711b9c1053f43e2379c363549a1ea1e8c6b2afaed8ff60fd26"` [INFO] [stdout] 9540a054787990711b9c1053f43e2379c363549a1ea1e8c6b2afaed8ff60fd26