[INFO] crate simplebase 0.2.5 is already in cache [INFO] extracting crate simplebase 0.2.5 into work/ex/clippy-test-run/sources/stable/reg/simplebase/0.2.5 [INFO] extracting crate simplebase 0.2.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simplebase/0.2.5 [INFO] validating manifest of simplebase-0.2.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of simplebase-0.2.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing simplebase-0.2.5 [INFO] finished frobbing simplebase-0.2.5 [INFO] frobbed toml for simplebase-0.2.5 written to work/ex/clippy-test-run/sources/stable/reg/simplebase/0.2.5/Cargo.toml [INFO] started frobbing simplebase-0.2.5 [INFO] finished frobbing simplebase-0.2.5 [INFO] frobbed toml for simplebase-0.2.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simplebase/0.2.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting simplebase-0.2.5 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simplebase/0.2.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 79e0a4fb719b397f2bc0adff8a5c743bdf96e3b1370c7e44b50b5dee5dce2a96 [INFO] running `"docker" "start" "-a" "79e0a4fb719b397f2bc0adff8a5c743bdf96e3b1370c7e44b50b5dee5dce2a96"` [INFO] [stderr] Checking simplebase v0.2.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine/mod.rs:405:13 [INFO] [stderr] | [INFO] [stderr] 405 | record_counter: record_counter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `record_counter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine/mod.rs:427:13 [INFO] [stderr] | [INFO] [stderr] 427 | record_counter: record_counter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `record_counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine/mod.rs:405:13 [INFO] [stderr] | [INFO] [stderr] 405 | record_counter: record_counter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `record_counter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/engine/mod.rs:427:13 [INFO] [stderr] | [INFO] [stderr] 427 | record_counter: record_counter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `record_counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/engine/mod.rs:99:58 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn save_hash_database(filename: &str, hash_to_save: &HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 99 | pub fn save_hash_database(filename: &str, hash_to_save: &HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/engine/mod.rs:305:5 [INFO] [stderr] | [INFO] [stderr] 305 | / match loaded_hash.get(&0) { [INFO] [stderr] 306 | | Some(first_record) => record_counter2 = first_record.record_id, //this is a special value for the first record [INFO] [stderr] 307 | | None => (), [INFO] [stderr] 308 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(first_record) = loaded_hash.get(&0) { record_counter2 = first_record.record_id }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/engine/mod.rs:99:58 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn save_hash_database(filename: &str, hash_to_save: &HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 99 | pub fn save_hash_database(filename: &str, hash_to_save: &HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/engine/mod.rs:305:5 [INFO] [stderr] | [INFO] [stderr] 305 | / match loaded_hash.get(&0) { [INFO] [stderr] 306 | | Some(first_record) => record_counter2 = first_record.record_id, //this is a special value for the first record [INFO] [stderr] 307 | | None => (), [INFO] [stderr] 308 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(first_record) = loaded_hash.get(&0) { record_counter2 = first_record.record_id }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.75s [INFO] running `"docker" "inspect" "79e0a4fb719b397f2bc0adff8a5c743bdf96e3b1370c7e44b50b5dee5dce2a96"` [INFO] running `"docker" "rm" "-f" "79e0a4fb719b397f2bc0adff8a5c743bdf96e3b1370c7e44b50b5dee5dce2a96"` [INFO] [stdout] 79e0a4fb719b397f2bc0adff8a5c743bdf96e3b1370c7e44b50b5dee5dce2a96