[INFO] crate simmons_rooms 0.1.1 is already in cache [INFO] extracting crate simmons_rooms 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/simmons_rooms/0.1.1 [INFO] extracting crate simmons_rooms 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simmons_rooms/0.1.1 [INFO] validating manifest of simmons_rooms-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of simmons_rooms-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing simmons_rooms-0.1.1 [INFO] finished frobbing simmons_rooms-0.1.1 [INFO] frobbed toml for simmons_rooms-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/simmons_rooms/0.1.1/Cargo.toml [INFO] started frobbing simmons_rooms-0.1.1 [INFO] finished frobbing simmons_rooms-0.1.1 [INFO] frobbed toml for simmons_rooms-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simmons_rooms/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting simmons_rooms-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simmons_rooms/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b8ecd55c1b73e706eacc042c6f47392188ea346b829fe6b692c0ba0ca8714acb [INFO] running `"docker" "start" "-a" "b8ecd55c1b73e706eacc042c6f47392188ea346b829fe6b692c0ba0ca8714acb"` [INFO] [stderr] Checking simmons_rooms v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/data/room_data.rs:320:26 [INFO] [stderr] | [INFO] [stderr] 320 | .expect(&format!( [INFO] [stderr] | __________________________^ [INFO] [stderr] 321 | | "Inconsistent data: room {:?} doesn't have a GRT!", [INFO] [stderr] 322 | | number)) [INFO] [stderr] | |________________________________________^ help: try this: `unwrap_or_else(|| panic!("Inconsistent data: room {:?} doesn't have a GRT!", number))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/data/room_data.rs:317:34 [INFO] [stderr] | [INFO] [stderr] 317 | grt_section: ::data::GRT_SECTIONS.values() [INFO] [stderr] | __________________________________^ [INFO] [stderr] 318 | | .filter(|section| section.numbers.contains(&number)) [INFO] [stderr] 319 | | .next() [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|section| section.numbers.contains(&number)).next()` with `find(|section| section.numbers.contains(&number))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/data/room_data.rs:345:31 [INFO] [stderr] | [INFO] [stderr] 345 | bathroom: ::data::BATHROOMS.iter() [INFO] [stderr] | _______________________________^ [INFO] [stderr] 346 | | .filter(|bathroom| bathroom.rooms.contains(number)) [INFO] [stderr] 347 | | .next() [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|bathroom| bathroom.rooms.contains(number)).next()` with `find(|bathroom| bathroom.rooms.contains(number))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/data/room_data.rs:320:26 [INFO] [stderr] | [INFO] [stderr] 320 | .expect(&format!( [INFO] [stderr] | __________________________^ [INFO] [stderr] 321 | | "Inconsistent data: room {:?} doesn't have a GRT!", [INFO] [stderr] 322 | | number)) [INFO] [stderr] | |________________________________________^ help: try this: `unwrap_or_else(|| panic!("Inconsistent data: room {:?} doesn't have a GRT!", number))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/data/room_data.rs:317:34 [INFO] [stderr] | [INFO] [stderr] 317 | grt_section: ::data::GRT_SECTIONS.values() [INFO] [stderr] | __________________________________^ [INFO] [stderr] 318 | | .filter(|section| section.numbers.contains(&number)) [INFO] [stderr] 319 | | .next() [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|section| section.numbers.contains(&number)).next()` with `find(|section| section.numbers.contains(&number))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/data/room_data.rs:345:31 [INFO] [stderr] | [INFO] [stderr] 345 | bathroom: ::data::BATHROOMS.iter() [INFO] [stderr] | _______________________________^ [INFO] [stderr] 346 | | .filter(|bathroom| bathroom.rooms.contains(number)) [INFO] [stderr] 347 | | .next() [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|bathroom| bathroom.rooms.contains(number)).next()` with `find(|bathroom| bathroom.rooms.contains(number))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.98s [INFO] running `"docker" "inspect" "b8ecd55c1b73e706eacc042c6f47392188ea346b829fe6b692c0ba0ca8714acb"` [INFO] running `"docker" "rm" "-f" "b8ecd55c1b73e706eacc042c6f47392188ea346b829fe6b692c0ba0ca8714acb"` [INFO] [stdout] b8ecd55c1b73e706eacc042c6f47392188ea346b829fe6b692c0ba0ca8714acb