[INFO] crate simble 0.1.2 is already in cache [INFO] extracting crate simble 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/simble/0.1.2 [INFO] extracting crate simble 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simble/0.1.2 [INFO] validating manifest of simble-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of simble-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing simble-0.1.2 [INFO] finished frobbing simble-0.1.2 [INFO] frobbed toml for simble-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/simble/0.1.2/Cargo.toml [INFO] started frobbing simble-0.1.2 [INFO] finished frobbing simble-0.1.2 [INFO] frobbed toml for simble-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simble/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting simble-0.1.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/simble/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 48872f147d11409c6cff00182da91b8c7794704d8f4e2f409959637e8109054c [INFO] running `"docker" "start" "-a" "48872f147d11409c6cff00182da91b8c7794704d8f4e2f409959637e8109054c"` [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking simble v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `len_without_is_empty` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:287:44 [INFO] [stderr] | [INFO] [stderr] 287 | #[cfg_attr(feature = "cargo-clippy", allow(len_without_is_empty))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::len_without_is_empty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `trivially_copy_pass_by_ref` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:318:48 [INFO] [stderr] | [INFO] [stderr] 318 | #[cfg_attr(feature = "cargo-clippy", allow(trivially_copy_pass_by_ref))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::trivially_copy_pass_by_ref` [INFO] [stderr] [INFO] [stderr] warning: lint name `trivially_copy_pass_by_ref` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:325:48 [INFO] [stderr] | [INFO] [stderr] 325 | #[cfg_attr(feature = "cargo-clippy", allow(trivially_copy_pass_by_ref))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::trivially_copy_pass_by_ref` [INFO] [stderr] [INFO] [stderr] warning: lint name `trivially_copy_pass_by_ref` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:333:48 [INFO] [stderr] | [INFO] [stderr] 333 | #[cfg_attr(feature = "cargo-clippy", allow(trivially_copy_pass_by_ref))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::trivially_copy_pass_by_ref` [INFO] [stderr] [INFO] [stderr] warning: lint name `len_without_is_empty` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:407:44 [INFO] [stderr] | [INFO] [stderr] 407 | #[cfg_attr(feature = "cargo-clippy", allow(len_without_is_empty))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::len_without_is_empty` [INFO] [stderr] [INFO] [stderr] warning: lint name `len_without_is_empty` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:287:44 [INFO] [stderr] | [INFO] [stderr] 287 | #[cfg_attr(feature = "cargo-clippy", allow(len_without_is_empty))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::len_without_is_empty` [INFO] [stderr] [INFO] [stderr] warning: lint name `len_without_is_empty` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:287:44 [INFO] [stderr] | [INFO] [stderr] 287 | #[cfg_attr(feature = "cargo-clippy", allow(len_without_is_empty))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::len_without_is_empty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `trivially_copy_pass_by_ref` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:318:48 [INFO] [stderr] | [INFO] [stderr] 318 | #[cfg_attr(feature = "cargo-clippy", allow(trivially_copy_pass_by_ref))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::trivially_copy_pass_by_ref` [INFO] [stderr] [INFO] [stderr] warning: lint name `trivially_copy_pass_by_ref` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:325:48 [INFO] [stderr] | [INFO] [stderr] 325 | #[cfg_attr(feature = "cargo-clippy", allow(trivially_copy_pass_by_ref))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::trivially_copy_pass_by_ref` [INFO] [stderr] [INFO] [stderr] warning: lint name `trivially_copy_pass_by_ref` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:333:48 [INFO] [stderr] | [INFO] [stderr] 333 | #[cfg_attr(feature = "cargo-clippy", allow(trivially_copy_pass_by_ref))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::trivially_copy_pass_by_ref` [INFO] [stderr] [INFO] [stderr] warning: lint name `len_without_is_empty` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:407:44 [INFO] [stderr] | [INFO] [stderr] 407 | #[cfg_attr(feature = "cargo-clippy", allow(len_without_is_empty))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::len_without_is_empty` [INFO] [stderr] [INFO] [stderr] warning: lint name `len_without_is_empty` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:287:44 [INFO] [stderr] | [INFO] [stderr] 287 | #[cfg_attr(feature = "cargo-clippy", allow(len_without_is_empty))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::len_without_is_empty` [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/lib.rs:576:13 [INFO] [stderr] | [INFO] [stderr] 576 | let foo: Lexical = "foo".parse().unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/lib.rs:577:13 [INFO] [stderr] | [INFO] [stderr] 577 | let bar: std::vec::Vec<_> = foo.bytes().collect(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:578:28 [INFO] [stderr] | [INFO] [stderr] 578 | assert_eq!(&bar, &['f' as u8, 'o' as u8, 'o' as u8]); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'f' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:578:39 [INFO] [stderr] | [INFO] [stderr] 578 | assert_eq!(&bar, &['f' as u8, 'o' as u8, 'o' as u8]); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'o' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:578:50 [INFO] [stderr] | [INFO] [stderr] 578 | assert_eq!(&bar, &['f' as u8, 'o' as u8, 'o' as u8]); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'o' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:597:22 [INFO] [stderr] | [INFO] [stderr] 597 | let array = ['f' as u8, 'o' as u8, 'o' as u8, 0u8, 0u8, 0u8, 0u8, 0u8]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'f' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:597:33 [INFO] [stderr] | [INFO] [stderr] 597 | let array = ['f' as u8, 'o' as u8, 'o' as u8, 0u8, 0u8, 0u8, 0u8, 0u8]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'o' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:597:44 [INFO] [stderr] | [INFO] [stderr] 597 | let array = ['f' as u8, 'o' as u8, 'o' as u8, 0u8, 0u8, 0u8, 0u8, 0u8]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'o' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.25s [INFO] running `"docker" "inspect" "48872f147d11409c6cff00182da91b8c7794704d8f4e2f409959637e8109054c"` [INFO] running `"docker" "rm" "-f" "48872f147d11409c6cff00182da91b8c7794704d8f4e2f409959637e8109054c"` [INFO] [stdout] 48872f147d11409c6cff00182da91b8c7794704d8f4e2f409959637e8109054c