[INFO] crate sid_vec 0.2.1 is already in cache
[INFO] extracting crate sid_vec 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/sid_vec/0.2.1
[INFO] extracting crate sid_vec 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sid_vec/0.2.1
[INFO] validating manifest of sid_vec-0.2.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of sid_vec-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing sid_vec-0.2.1
[INFO] finished frobbing sid_vec-0.2.1
[INFO] frobbed toml for sid_vec-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/sid_vec/0.2.1/Cargo.toml
[INFO] started frobbing sid_vec-0.2.1
[INFO] finished frobbing sid_vec-0.2.1
[INFO] frobbed toml for sid_vec-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sid_vec/0.2.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting sid_vec-0.2.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sid_vec/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 850ee6be0638893507cda9060a31e17850a54bf9600eceb49a12b6adc013e4f8
[INFO] running `"docker" "start" "-a" "850ee6be0638893507cda9060a31e17850a54bf9600eceb49a12b6adc013e4f8"`
[INFO] [stderr]     Checking sid_vec v0.2.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/id_vector.rs:141:13
[INFO] [stderr]     |
[INFO] [stderr] 141 |             slice: slice,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `slice`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/id_vector.rs:174:13
[INFO] [stderr]     |
[INFO] [stderr] 174 |             slice: slice,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `slice`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:84:42
[INFO] [stderr]    |
[INFO] [stderr] 84 |         IdRange { first: Id::new(first), count: count }
[INFO] [stderr]    |                                          ^^^^^^^^^^^^ help: replace it with: `count`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:160:81
[INFO] [stderr]     |
[INFO] [stderr] 160 |     pub fn new(range: IdRange<T, H>) -> ReverseIdRange<T, H> { ReverseIdRange { range: range } }
[INFO] [stderr]     |                                                                                 ^^^^^^^^^^^^ help: replace it with: `range`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/id_vector.rs:141:13
[INFO] [stderr]     |
[INFO] [stderr] 141 |             slice: slice,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `slice`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/id_vector.rs:174:13
[INFO] [stderr]     |
[INFO] [stderr] 174 |             slice: slice,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `slice`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:84:42
[INFO] [stderr]    |
[INFO] [stderr] 84 |         IdRange { first: Id::new(first), count: count }
[INFO] [stderr]    |                                          ^^^^^^^^^^^^ help: replace it with: `count`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:160:81
[INFO] [stderr]     |
[INFO] [stderr] 160 |     pub fn new(range: IdRange<T, H>) -> ReverseIdRange<T, H> { ReverseIdRange { range: range } }
[INFO] [stderr]     |                                                                                 ^^^^^^^^^^^^ help: replace it with: `range`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/id_vector.rs:65:9
[INFO] [stderr]    |
[INFO] [stderr] 65 |         return FromIndex::from_index(index);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `FromIndex::from_index(index)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/id_vector.rs:109:9
[INFO] [stderr]     |
[INFO] [stderr] 109 |         return result;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/id_list.rs:71:9
[INFO] [stderr]    |
[INFO] [stderr] 71 |         return new_id;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `new_id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/id_list.rs:93:9
[INFO] [stderr]    |
[INFO] [stderr] 93 |         return new_id;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `new_id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/id_list.rs:167:9
[INFO] [stderr]     |
[INFO] [stderr] 167 |         return if next == C::null_id() { None } else { Some(next) };
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if next == C::null_id() { None } else { Some(next) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/id_list.rs:174:9
[INFO] [stderr]     |
[INFO] [stderr] 174 |         return if prev == C::null_id() { None } else { Some(prev) };
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if prev == C::null_id() { None } else { Some(prev) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/id_list.rs:179:9
[INFO] [stderr]     |
[INFO] [stderr] 179 |         return if self.first == C::null_id() { None } else { Some(self.first) };
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if self.first == C::null_id() { None } else { Some(self.first) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:93:9
[INFO] [stderr]    |
[INFO] [stderr] 93 |         return Id { handle: self.first.handle + i, _marker: PhantomData };
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Id { handle: self.first.handle + i, _marker: PhantomData }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:101:9
[INFO] [stderr]     |
[INFO] [stderr] 101 | /         return Some(IdRange{
[INFO] [stderr] 102 | |             count: FromIndex::from_index(self.count.to_index() - 1),
[INFO] [stderr] 103 | |             first: FromIndex::from_index(self.first.to_index() + 1),
[INFO] [stderr] 104 | |         });
[INFO] [stderr]     | |___________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 101 |         Some(IdRange{
[INFO] [stderr] 102 |             count: FromIndex::from_index(self.count.to_index() - 1),
[INFO] [stderr] 103 |             first: FromIndex::from_index(self.first.to_index() + 1),
[INFO] [stderr] 104 |         })
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:112:9
[INFO] [stderr]     |
[INFO] [stderr] 112 | /         return Some(IdRange{
[INFO] [stderr] 113 | |             first: self.first,
[INFO] [stderr] 114 | |             count: FromIndex::from_index(self.count.to_index() - 1),
[INFO] [stderr] 115 | |         });
[INFO] [stderr]     | |___________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 112 |         Some(IdRange{
[INFO] [stderr] 113 |             first: self.first,
[INFO] [stderr] 114 |             count: FromIndex::from_index(self.count.to_index() - 1),
[INFO] [stderr] 115 |         })
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:128:9
[INFO] [stderr]     |
[INFO] [stderr] 128 |         return Some(res);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(res)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:132:9
[INFO] [stderr]     |
[INFO] [stderr] 132 |         return (self.count.to_index(), Some(self.count.to_index()));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.count.to_index(), Some(self.count.to_index()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:176:9
[INFO] [stderr]     |
[INFO] [stderr] 176 |         return Some(FromIndex::from_index(self.range.first.to_index() + self.range.count.to_index()));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(FromIndex::from_index(self.range.first.to_index() + self.range.count.to_index()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/id_vector.rs:65:9
[INFO] [stderr]    |
[INFO] [stderr] 65 |         return FromIndex::from_index(index);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `FromIndex::from_index(index)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/id_vector.rs:109:9
[INFO] [stderr]     |
[INFO] [stderr] 109 |         return result;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/id_list.rs:71:9
[INFO] [stderr]    |
[INFO] [stderr] 71 |         return new_id;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `new_id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/id_list.rs:93:9
[INFO] [stderr]    |
[INFO] [stderr] 93 |         return new_id;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `new_id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/id_list.rs:167:9
[INFO] [stderr]     |
[INFO] [stderr] 167 |         return if next == C::null_id() { None } else { Some(next) };
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if next == C::null_id() { None } else { Some(next) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/id_list.rs:174:9
[INFO] [stderr]     |
[INFO] [stderr] 174 |         return if prev == C::null_id() { None } else { Some(prev) };
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if prev == C::null_id() { None } else { Some(prev) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/id_list.rs:179:9
[INFO] [stderr]     |
[INFO] [stderr] 179 |         return if self.first == C::null_id() { None } else { Some(self.first) };
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if self.first == C::null_id() { None } else { Some(self.first) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/id_list.rs:220:30
[INFO] [stderr]     |
[INFO] [stderr] 220 |     fn null_id() -> TestId { return FromIndex::from_index(::std::u32::MAX as usize); }
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `FromIndex::from_index(::std::u32::MAX as usize)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:93:9
[INFO] [stderr]    |
[INFO] [stderr] 93 |         return Id { handle: self.first.handle + i, _marker: PhantomData };
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Id { handle: self.first.handle + i, _marker: PhantomData }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:101:9
[INFO] [stderr]     |
[INFO] [stderr] 101 | /         return Some(IdRange{
[INFO] [stderr] 102 | |             count: FromIndex::from_index(self.count.to_index() - 1),
[INFO] [stderr] 103 | |             first: FromIndex::from_index(self.first.to_index() + 1),
[INFO] [stderr] 104 | |         });
[INFO] [stderr]     | |___________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 101 |         Some(IdRange{
[INFO] [stderr] 102 |             count: FromIndex::from_index(self.count.to_index() - 1),
[INFO] [stderr] 103 |             first: FromIndex::from_index(self.first.to_index() + 1),
[INFO] [stderr] 104 |         })
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:112:9
[INFO] [stderr]     |
[INFO] [stderr] 112 | /         return Some(IdRange{
[INFO] [stderr] 113 | |             first: self.first,
[INFO] [stderr] 114 | |             count: FromIndex::from_index(self.count.to_index() - 1),
[INFO] [stderr] 115 | |         });
[INFO] [stderr]     | |___________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 112 |         Some(IdRange{
[INFO] [stderr] 113 |             first: self.first,
[INFO] [stderr] 114 |             count: FromIndex::from_index(self.count.to_index() - 1),
[INFO] [stderr] 115 |         })
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:128:9
[INFO] [stderr]     |
[INFO] [stderr] 128 |         return Some(res);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(res)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:132:9
[INFO] [stderr]     |
[INFO] [stderr] 132 |         return (self.count.to_index(), Some(self.count.to_index()));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.count.to_index(), Some(self.count.to_index()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:176:9
[INFO] [stderr]     |
[INFO] [stderr] 176 |         return Some(FromIndex::from_index(self.range.first.to_index() + self.range.count.to_index()));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(FromIndex::from_index(self.range.first.to_index() + self.range.count.to_index()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: item `id_vector::IdVec<ID, Data>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]   --> src/id_vector.rs:16:1
[INFO] [stderr]    |
[INFO] [stderr] 16 | / impl<ID:Identifier, Data> IdVec<ID, Data> {
[INFO] [stderr] 17 | |
[INFO] [stderr] 18 | |     /// Create an empty IdVec
[INFO] [stderr] 19 | |     pub fn new() -> IdVec<ID, Data> {
[INFO] [stderr] ...  |
[INFO] [stderr] 71 | |     }
[INFO] [stderr] 72 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `id_vector::IdVec<ID, Data>`
[INFO] [stderr]   --> src/id_vector.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | /     pub fn new() -> IdVec<ID, Data> {
[INFO] [stderr] 20 | |         IdVec {
[INFO] [stderr] 21 | |             data: Vec::new(),
[INFO] [stderr] 22 | |             _idtype: PhantomData
[INFO] [stderr] 23 | |         }
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 11 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/id_vector.rs:55:5
[INFO] [stderr]    |
[INFO] [stderr] 55 |     pub fn iter<'l>(&'l self) -> slice::Iter<'l, Data> { self.data.iter() }
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/id_vector.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 |     pub fn iter_mut<'l>(&'l mut self) -> slice::IterMut<'l, Data> { self.data.iter_mut() }
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/id_vector.rs:115:5
[INFO] [stderr]     |
[INFO] [stderr] 115 |     fn index<'l>(&'l self, id: ID) -> &'l Data { &self.data[id.to_index()] }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/id_vector.rs:119:5
[INFO] [stderr]     |
[INFO] [stderr] 119 |     fn index_mut<'l>(&'l mut self, id: ID) -> &'l mut Data { &mut self.data[id.to_index()] }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: item `id_vector::IdSlice<'l, ID, Data>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/id_vector.rs:138:1
[INFO] [stderr]     |
[INFO] [stderr] 138 | / impl<'l, Data, ID:Identifier> IdSlice<'l, ID, Data> where Data:'l {
[INFO] [stderr] 139 | |     pub fn new(slice: &'l[Data]) -> IdSlice<'l, ID, Data> {
[INFO] [stderr] 140 | |         IdSlice {
[INFO] [stderr] 141 | |             slice: slice,
[INFO] [stderr] ...   |
[INFO] [stderr] 156 | |     pub fn nth(&self, idx: usize) -> &Data { &self.slice[idx] }
[INFO] [stderr] 157 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/id_vector.rs:148:5
[INFO] [stderr]     |
[INFO] [stderr] 148 |     pub fn as_slice<'a>(&'a self) -> &'a[Data] { self.slice }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/id_vector.rs:150:5
[INFO] [stderr]     |
[INFO] [stderr] 150 |     pub fn iter<'a>(&'a self) -> slice::Iter<'a, Data> { self.slice.iter() }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/id_vector.rs:161:5
[INFO] [stderr]     |
[INFO] [stderr] 161 |     fn index<'a>(&'a self, id: ID) -> &'a Data { &self.slice[id.to_index()] }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/id_vector.rs:179:5
[INFO] [stderr]     |
[INFO] [stderr] 179 |     pub fn iter<'a>(&'a self) -> slice::Iter<'a, Data> { self.slice.iter() }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/id_vector.rs:180:5
[INFO] [stderr]     |
[INFO] [stderr] 180 |     pub fn iter_mut<'a>(&'a mut self) -> slice::IterMut<'a, Data> { self.slice.iter_mut() }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/id_vector.rs:197:5
[INFO] [stderr]     |
[INFO] [stderr] 197 |     fn index<'a>(&'a self, id: ID) -> &'a Data { &self.slice[id.to_index()] }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/id_vector.rs:201:5
[INFO] [stderr]     |
[INFO] [stderr] 201 |     fn index_mut<'a>(&'a mut self, id: ID) -> &'a mut Data { &mut self.slice[id.to_index()] }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `id_list::IdFreeList<ID, Data, C>`
[INFO] [stderr]   --> src/id_list.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 | /     pub fn new() -> IdFreeList<ID, Data, C> {
[INFO] [stderr] 28 | |         IdFreeList {
[INFO] [stderr] 29 | |             data: Vec::new(),
[INFO] [stderr] 30 | |             first: C::null_id(),
[INFO] [stderr] ...  |
[INFO] [stderr] 33 | |         }
[INFO] [stderr] 34 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 24 | impl Default for id_list::IdFreeList<ID, Data, C> {
[INFO] [stderr] 25 |     fn default() -> Self {
[INFO] [stderr] 26 |         Self::new()
[INFO] [stderr] 27 |     }
[INFO] [stderr] 28 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/id_list.rs:185:5
[INFO] [stderr]     |
[INFO] [stderr] 185 | /     fn index<'l>(&'l self, id: ID) -> &'l Data {
[INFO] [stderr] 186 | |         // Enabling assertion is very expensive
[INFO] [stderr] 187 | |         //debug_assert!(self.has_id(id));
[INFO] [stderr] 188 | |         &self.data[id.to_index()].payload
[INFO] [stderr] 189 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/id_list.rs:193:5
[INFO] [stderr]     |
[INFO] [stderr] 193 | /     fn index_mut<'l>(&'l mut self, id: ID) -> &'l mut Data {
[INFO] [stderr] 194 | |         // Enabling assertion is very expensive
[INFO] [stderr] 195 | |         //debug_assert!(self.has_id(id));
[INFO] [stderr] 196 | |         &mut self.data[id.to_index()].payload
[INFO] [stderr] 197 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:261:54
[INFO] [stderr]     |
[INFO] [stderr] 261 | impl Generation for u8  { fn get_gen(&self) -> u32 { *self as u32 } }
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^ help: try: `u32::from(*self)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:262:54
[INFO] [stderr]     |
[INFO] [stderr] 262 | impl Generation for u16 { fn get_gen(&self) -> u32 { *self as u32 } }
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^ help: try: `u32::from(*self)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: item `id_vector::IdVec<ID, Data>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]   --> src/id_vector.rs:16:1
[INFO] [stderr]    |
[INFO] [stderr] 16 | / impl<ID:Identifier, Data> IdVec<ID, Data> {
[INFO] [stderr] 17 | |
[INFO] [stderr] 18 | |     /// Create an empty IdVec
[INFO] [stderr] 19 | |     pub fn new() -> IdVec<ID, Data> {
[INFO] [stderr] ...  |
[INFO] [stderr] 71 | |     }
[INFO] [stderr] 72 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `id_vector::IdVec<ID, Data>`
[INFO] [stderr]   --> src/id_vector.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | /     pub fn new() -> IdVec<ID, Data> {
[INFO] [stderr] 20 | |         IdVec {
[INFO] [stderr] 21 | |             data: Vec::new(),
[INFO] [stderr] 22 | |             _idtype: PhantomData
[INFO] [stderr] 23 | |         }
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 11 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/id_vector.rs:55:5
[INFO] [stderr]    |
[INFO] [stderr] 55 |     pub fn iter<'l>(&'l self) -> slice::Iter<'l, Data> { self.data.iter() }
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/id_vector.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 |     pub fn iter_mut<'l>(&'l mut self) -> slice::IterMut<'l, Data> { self.data.iter_mut() }
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/id_vector.rs:115:5
[INFO] [stderr]     |
[INFO] [stderr] 115 |     fn index<'l>(&'l self, id: ID) -> &'l Data { &self.data[id.to_index()] }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/id_vector.rs:119:5
[INFO] [stderr]     |
[INFO] [stderr] 119 |     fn index_mut<'l>(&'l mut self, id: ID) -> &'l mut Data { &mut self.data[id.to_index()] }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: item `id_vector::IdSlice<'l, ID, Data>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/id_vector.rs:138:1
[INFO] [stderr]     |
[INFO] [stderr] 138 | / impl<'l, Data, ID:Identifier> IdSlice<'l, ID, Data> where Data:'l {
[INFO] [stderr] 139 | |     pub fn new(slice: &'l[Data]) -> IdSlice<'l, ID, Data> {
[INFO] [stderr] 140 | |         IdSlice {
[INFO] [stderr] 141 | |             slice: slice,
[INFO] [stderr] ...   |
[INFO] [stderr] 156 | |     pub fn nth(&self, idx: usize) -> &Data { &self.slice[idx] }
[INFO] [stderr] 157 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/id_vector.rs:148:5
[INFO] [stderr]     |
[INFO] [stderr] 148 |     pub fn as_slice<'a>(&'a self) -> &'a[Data] { self.slice }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/id_vector.rs:150:5
[INFO] [stderr]     |
[INFO] [stderr] 150 |     pub fn iter<'a>(&'a self) -> slice::Iter<'a, Data> { self.slice.iter() }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/id_vector.rs:161:5
[INFO] [stderr]     |
[INFO] [stderr] 161 |     fn index<'a>(&'a self, id: ID) -> &'a Data { &self.slice[id.to_index()] }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/id_vector.rs:179:5
[INFO] [stderr]     |
[INFO] [stderr] 179 |     pub fn iter<'a>(&'a self) -> slice::Iter<'a, Data> { self.slice.iter() }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/id_vector.rs:180:5
[INFO] [stderr]     |
[INFO] [stderr] 180 |     pub fn iter_mut<'a>(&'a mut self) -> slice::IterMut<'a, Data> { self.slice.iter_mut() }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/id_vector.rs:197:5
[INFO] [stderr]     |
[INFO] [stderr] 197 |     fn index<'a>(&'a self, id: ID) -> &'a Data { &self.slice[id.to_index()] }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/id_vector.rs:201:5
[INFO] [stderr]     |
[INFO] [stderr] 201 |     fn index_mut<'a>(&'a mut self, id: ID) -> &'a mut Data { &mut self.slice[id.to_index()] }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `id_list::IdFreeList<ID, Data, C>`
[INFO] [stderr]   --> src/id_list.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 | /     pub fn new() -> IdFreeList<ID, Data, C> {
[INFO] [stderr] 28 | |         IdFreeList {
[INFO] [stderr] 29 | |             data: Vec::new(),
[INFO] [stderr] 30 | |             first: C::null_id(),
[INFO] [stderr] ...  |
[INFO] [stderr] 33 | |         }
[INFO] [stderr] 34 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 24 | impl Default for id_list::IdFreeList<ID, Data, C> {
[INFO] [stderr] 25 |     fn default() -> Self {
[INFO] [stderr] 26 |         Self::new()
[INFO] [stderr] 27 |     }
[INFO] [stderr] 28 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/id_list.rs:185:5
[INFO] [stderr]     |
[INFO] [stderr] 185 | /     fn index<'l>(&'l self, id: ID) -> &'l Data {
[INFO] [stderr] 186 | |         // Enabling assertion is very expensive
[INFO] [stderr] 187 | |         //debug_assert!(self.has_id(id));
[INFO] [stderr] 188 | |         &self.data[id.to_index()].payload
[INFO] [stderr] 189 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/id_list.rs:193:5
[INFO] [stderr]     |
[INFO] [stderr] 193 | /     fn index_mut<'l>(&'l mut self, id: ID) -> &'l mut Data {
[INFO] [stderr] 194 | |         // Enabling assertion is very expensive
[INFO] [stderr] 195 | |         //debug_assert!(self.has_id(id));
[INFO] [stderr] 196 | |         &mut self.data[id.to_index()].payload
[INFO] [stderr] 197 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 36
[INFO] [stderr]    --> src/id_list.rs:227:1
[INFO] [stderr]     |
[INFO] [stderr] 227 | / fn vector_list() {
[INFO] [stderr] 228 | |     let mut list: TestIdFreeList = TestIdFreeList::with_capacity(10);
[INFO] [stderr] 229 | |     assert!(list.is_empty());
[INFO] [stderr] 230 | |     assert_eq!(list.count(), 0);
[INFO] [stderr] ...   |
[INFO] [stderr] 281 | |     assert!(list.first_id().is_none());
[INFO] [stderr] 282 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:261:54
[INFO] [stderr]     |
[INFO] [stderr] 261 | impl Generation for u8  { fn get_gen(&self) -> u32 { *self as u32 } }
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^ help: try: `u32::from(*self)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:262:54
[INFO] [stderr]     |
[INFO] [stderr] 262 | impl Generation for u16 { fn get_gen(&self) -> u32 { *self as u32 } }
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^ help: try: `u32::from(*self)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.95s
[INFO] running `"docker" "inspect" "850ee6be0638893507cda9060a31e17850a54bf9600eceb49a12b6adc013e4f8"`
[INFO] running `"docker" "rm" "-f" "850ee6be0638893507cda9060a31e17850a54bf9600eceb49a12b6adc013e4f8"`
[INFO] [stdout] 850ee6be0638893507cda9060a31e17850a54bf9600eceb49a12b6adc013e4f8