[INFO] crate shellexpand 1.0.0 is already in cache [INFO] extracting crate shellexpand 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/shellexpand/1.0.0 [INFO] extracting crate shellexpand 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shellexpand/1.0.0 [INFO] validating manifest of shellexpand-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shellexpand-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shellexpand-1.0.0 [INFO] finished frobbing shellexpand-1.0.0 [INFO] frobbed toml for shellexpand-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/shellexpand/1.0.0/Cargo.toml [INFO] started frobbing shellexpand-1.0.0 [INFO] finished frobbing shellexpand-1.0.0 [INFO] frobbed toml for shellexpand-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shellexpand/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shellexpand-1.0.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shellexpand/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0b9f0b43a42a5b52eb27b61d928423104b2ac220d68f1d7ca2248e8732936bd0 [INFO] running `"docker" "start" "-a" "0b9f0b43a42a5b52eb27b61d928423104b2ac220d68f1d7ca2248e8732936bd0"` [INFO] [stderr] Checking shellexpand v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:172:20 [INFO] [stderr] | [INFO] [stderr] 172 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 173 | | if let Cow::Owned(s) = tilde_with_context(&s, home_dir) { [INFO] [stderr] 174 | | s.into() [INFO] [stderr] 175 | | } else { [INFO] [stderr] 176 | | s.into() [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 172 | } else if let Cow::Owned(s) = tilde_with_context(&s, home_dir) { [INFO] [stderr] 173 | s.into() [INFO] [stderr] 174 | } else { [INFO] [stderr] 175 | s.into() [INFO] [stderr] 176 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:286:30 [INFO] [stderr] | [INFO] [stderr] 286 | full_with_context(input, std::env::home_dir, |s| std::env::var(s).map(Some)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:638:31 [INFO] [stderr] | [INFO] [stderr] 638 | tilde_with_context(input, std::env::home_dir) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:172:20 [INFO] [stderr] | [INFO] [stderr] 172 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 173 | | if let Cow::Owned(s) = tilde_with_context(&s, home_dir) { [INFO] [stderr] 174 | | s.into() [INFO] [stderr] 175 | | } else { [INFO] [stderr] 176 | | s.into() [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 172 | } else if let Cow::Owned(s) = tilde_with_context(&s, home_dir) { [INFO] [stderr] 173 | s.into() [INFO] [stderr] 174 | } else { [INFO] [stderr] 175 | s.into() [INFO] [stderr] 176 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:286:30 [INFO] [stderr] | [INFO] [stderr] 286 | full_with_context(input, std::env::home_dir, |s| std::env::var(s).map(Some)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:638:31 [INFO] [stderr] | [INFO] [stderr] 638 | tilde_with_context(input, std::env::home_dir) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:672:15 [INFO] [stderr] | [INFO] [stderr] 672 | match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:169:44 [INFO] [stderr] | [INFO] [stderr] 169 | if !input.as_ref().starts_with("~") && s.starts_with("~") { [INFO] [stderr] | ^^^ help: try using a char instead: `'~'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:169:66 [INFO] [stderr] | [INFO] [stderr] 169 | if !input.as_ref().starts_with("~") && s.starts_with("~") { [INFO] [stderr] | ^^^ help: try using a char instead: `'~'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:410:60 [INFO] [stderr] | [INFO] [stderr] 410 | fn find_dollar(s: &str) -> usize { s.find('$').unwrap_or(s.len()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| s.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:424:60 [INFO] [stderr] | [INFO] [stderr] 424 | result.push_str(&input_str[..closing_brace_idx+1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `..=closing_brace_idx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:595:30 [INFO] [stderr] | [INFO] [stderr] 595 | if input_str.starts_with("~") { [INFO] [stderr] | ^^^ help: try using a char instead: `'~'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:597:74 [INFO] [stderr] | [INFO] [stderr] 597 | if input_after_tilde.is_empty() || input_after_tilde.starts_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:169:44 [INFO] [stderr] | [INFO] [stderr] 169 | if !input.as_ref().starts_with("~") && s.starts_with("~") { [INFO] [stderr] | ^^^ help: try using a char instead: `'~'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:169:66 [INFO] [stderr] | [INFO] [stderr] 169 | if !input.as_ref().starts_with("~") && s.starts_with("~") { [INFO] [stderr] | ^^^ help: try using a char instead: `'~'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:410:60 [INFO] [stderr] | [INFO] [stderr] 410 | fn find_dollar(s: &str) -> usize { s.find('$').unwrap_or(s.len()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| s.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:424:60 [INFO] [stderr] | [INFO] [stderr] 424 | result.push_str(&input_str[..closing_brace_idx+1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `..=closing_brace_idx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:595:30 [INFO] [stderr] | [INFO] [stderr] 595 | if input_str.starts_with("~") { [INFO] [stderr] | ^^^ help: try using a char instead: `'~'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:597:74 [INFO] [stderr] | [INFO] [stderr] 597 | if input_after_tilde.is_empty() || input_after_tilde.starts_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.82s [INFO] running `"docker" "inspect" "0b9f0b43a42a5b52eb27b61d928423104b2ac220d68f1d7ca2248e8732936bd0"` [INFO] running `"docker" "rm" "-f" "0b9f0b43a42a5b52eb27b61d928423104b2ac220d68f1d7ca2248e8732936bd0"` [INFO] [stdout] 0b9f0b43a42a5b52eb27b61d928423104b2ac220d68f1d7ca2248e8732936bd0