[INFO] crate shelf 0.2.2 is already in cache [INFO] extracting crate shelf 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/shelf/0.2.2 [INFO] extracting crate shelf 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shelf/0.2.2 [INFO] validating manifest of shelf-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shelf-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shelf-0.2.2 [INFO] finished frobbing shelf-0.2.2 [INFO] frobbed toml for shelf-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/shelf/0.2.2/Cargo.toml [INFO] started frobbing shelf-0.2.2 [INFO] finished frobbing shelf-0.2.2 [INFO] frobbed toml for shelf-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shelf/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shelf-0.2.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shelf/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 33b50dc857a0be63cace54d89e1b079507a1cbfb4b6d62e23e7403c3ab1bbbc9 [INFO] running `"docker" "start" "-a" "33b50dc857a0be63cace54d89e1b079507a1cbfb4b6d62e23e7403c3ab1bbbc9"` [INFO] [stderr] Checking shelf v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/shelf.rs:21:45 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn set(&self, key: &str, value: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/shelf.rs:43:35 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn delete(&self, key: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/shelf.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | entry.write(value.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/shelf.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / match fs::remove_file(path) { [INFO] [stderr] 48 | | Err(why) => println!("{}", why), [INFO] [stderr] 49 | | Ok(_) => () [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = fs::remove_file(path) { println!("{}", why) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/shelf.rs:67:7 [INFO] [stderr] | [INFO] [stderr] 67 | / match self.get(&entry.unwrap().file_name().into_string().unwrap()) { [INFO] [stderr] 68 | | Some(value) => values.push(value), [INFO] [stderr] 69 | | None => () [INFO] [stderr] 70 | | } [INFO] [stderr] | |_______^ help: try this: `if let Some(value) = self.get(&entry.unwrap().file_name().into_string().unwrap()) { values.push(value) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `shelf`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/shelf.rs:21:45 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn set(&self, key: &str, value: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/shelf.rs:43:35 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn delete(&self, key: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/shelf.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | entry.write(value.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/shelf.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / match fs::remove_file(path) { [INFO] [stderr] 48 | | Err(why) => println!("{}", why), [INFO] [stderr] 49 | | Ok(_) => () [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = fs::remove_file(path) { println!("{}", why) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/shelf.rs:67:7 [INFO] [stderr] | [INFO] [stderr] 67 | / match self.get(&entry.unwrap().file_name().into_string().unwrap()) { [INFO] [stderr] 68 | | Some(value) => values.push(value), [INFO] [stderr] 69 | | None => () [INFO] [stderr] 70 | | } [INFO] [stderr] | |_______^ help: try this: `if let Some(value) = self.get(&entry.unwrap().file_name().into_string().unwrap()) { values.push(value) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `shelf`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "33b50dc857a0be63cace54d89e1b079507a1cbfb4b6d62e23e7403c3ab1bbbc9"` [INFO] running `"docker" "rm" "-f" "33b50dc857a0be63cace54d89e1b079507a1cbfb4b6d62e23e7403c3ab1bbbc9"` [INFO] [stdout] 33b50dc857a0be63cace54d89e1b079507a1cbfb4b6d62e23e7403c3ab1bbbc9