[INFO] crate shared_channel 0.2.0 is already in cache [INFO] extracting crate shared_channel 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/shared_channel/0.2.0 [INFO] extracting crate shared_channel 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shared_channel/0.2.0 [INFO] validating manifest of shared_channel-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shared_channel-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shared_channel-0.2.0 [INFO] finished frobbing shared_channel-0.2.0 [INFO] frobbed toml for shared_channel-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/shared_channel/0.2.0/Cargo.toml [INFO] started frobbing shared_channel-0.2.0 [INFO] finished frobbing shared_channel-0.2.0 [INFO] frobbed toml for shared_channel-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shared_channel/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shared_channel-0.2.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/shared_channel/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1f7bd55a9be03f8919061ae6a1cea249687b8a6964405477efdb81f9fd7237ad [INFO] running `"docker" "start" "-a" "1f7bd55a9be03f8919061ae6a1cea249687b8a6964405477efdb81f9fd7237ad"` [INFO] [stderr] Checking shared_channel v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:235:13 [INFO] [stderr] | [INFO] [stderr] 235 | / match rx.try_recv() { [INFO] [stderr] 236 | | Ok(..) => panic!(), [INFO] [stderr] 237 | | _ => {} [INFO] [stderr] 238 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Ok(..) = rx.try_recv() { panic!() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:309:26 [INFO] [stderr] | [INFO] [stderr] 309 | for i in 1..AMT + 1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=AMT` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:334:17 [INFO] [stderr] | [INFO] [stderr] 334 | / match rx.try_recv() { [INFO] [stderr] 335 | | Ok(i) => sum += i, [INFO] [stderr] 336 | | Err(_) => {} [INFO] [stderr] 337 | | }; [INFO] [stderr] | |_________________^ help: try this: `if let Ok(i) = rx.try_recv() { sum += i }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:343:18 [INFO] [stderr] | [INFO] [stderr] 343 | for i in 1..10 + 1 { [INFO] [stderr] | ^^^^^^^^^ help: use: `1..=10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:462:13 [INFO] [stderr] | [INFO] [stderr] 462 | / match rx.try_recv() { [INFO] [stderr] 463 | | Ok(..) => panic!(), [INFO] [stderr] 464 | | _ => {} [INFO] [stderr] 465 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Ok(..) = rx.try_recv() { panic!() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:536:26 [INFO] [stderr] | [INFO] [stderr] 536 | for i in 1..AMT + 1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=AMT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:561:17 [INFO] [stderr] | [INFO] [stderr] 561 | / match rx.try_recv() { [INFO] [stderr] 562 | | Ok(i) => sum += i, [INFO] [stderr] 563 | | Err(_) => {} [INFO] [stderr] 564 | | }; [INFO] [stderr] | |_________________^ help: try this: `if let Ok(i) = rx.try_recv() { sum += i }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:570:18 [INFO] [stderr] | [INFO] [stderr] 570 | for i in 1..10 + 1 { [INFO] [stderr] | ^^^^^^^^^ help: use: `1..=10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/hello_server.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / match line { [INFO] [stderr] 15 | | Ok(line) => { [INFO] [stderr] 16 | | if line.len() == 0 { [INFO] [stderr] 17 | | break; [INFO] [stderr] ... | [INFO] [stderr] 20 | | _ => {} [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | if let Ok(line) = line { [INFO] [stderr] 15 | if line.len() == 0 { [INFO] [stderr] 16 | break; [INFO] [stderr] 17 | } [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> examples/hello_server.rs:16:20 [INFO] [stderr] | [INFO] [stderr] 16 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.89s [INFO] running `"docker" "inspect" "1f7bd55a9be03f8919061ae6a1cea249687b8a6964405477efdb81f9fd7237ad"` [INFO] running `"docker" "rm" "-f" "1f7bd55a9be03f8919061ae6a1cea249687b8a6964405477efdb81f9fd7237ad"` [INFO] [stdout] 1f7bd55a9be03f8919061ae6a1cea249687b8a6964405477efdb81f9fd7237ad