[INFO] crate sharecart1000 1.0.0 is already in cache [INFO] extracting crate sharecart1000 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/sharecart1000/1.0.0 [INFO] extracting crate sharecart1000 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sharecart1000/1.0.0 [INFO] validating manifest of sharecart1000-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sharecart1000-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sharecart1000-1.0.0 [INFO] finished frobbing sharecart1000-1.0.0 [INFO] frobbed toml for sharecart1000-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/sharecart1000/1.0.0/Cargo.toml [INFO] started frobbing sharecart1000-1.0.0 [INFO] finished frobbing sharecart1000-1.0.0 [INFO] frobbed toml for sharecart1000-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sharecart1000/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sharecart1000-1.0.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sharecart1000/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b0e9bfeef47532bf927a5d36db98de7eb3764eedc31e33f148a221ccf6ce170f [INFO] running `"docker" "start" "-a" "b0e9bfeef47532bf927a5d36db98de7eb3764eedc31e33f148a221ccf6ce170f"` [INFO] [stderr] Checking rust-ini v0.11.0 [INFO] [stderr] Checking sharecart1000 v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:101:3 [INFO] [stderr] | [INFO] [stderr] 101 | / pub fn from_str>(buf: S) -> Self { [INFO] [stderr] 102 | | let buf_str = buf.as_ref(); [INFO] [stderr] 103 | | match ini::Ini::load_from_str(buf_str) { [INFO] [stderr] 104 | | Ok(i) => match i.section(Some("Main")).or(i.section(Some("main"))) { [INFO] [stderr] ... | [INFO] [stderr] 164 | | } [INFO] [stderr] 165 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:104:46 [INFO] [stderr] | [INFO] [stderr] 104 | Ok(i) => match i.section(Some("Main")).or(i.section(Some("main"))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| i.section(Some("main")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:101:3 [INFO] [stderr] | [INFO] [stderr] 101 | / pub fn from_str>(buf: S) -> Self { [INFO] [stderr] 102 | | let buf_str = buf.as_ref(); [INFO] [stderr] 103 | | match ini::Ini::load_from_str(buf_str) { [INFO] [stderr] 104 | | Ok(i) => match i.section(Some("Main")).or(i.section(Some("main"))) { [INFO] [stderr] ... | [INFO] [stderr] 164 | | } [INFO] [stderr] 165 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:104:46 [INFO] [stderr] | [INFO] [stderr] 104 | Ok(i) => match i.section(Some("Main")).or(i.section(Some("main"))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| i.section(Some("main")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.35s [INFO] running `"docker" "inspect" "b0e9bfeef47532bf927a5d36db98de7eb3764eedc31e33f148a221ccf6ce170f"` [INFO] running `"docker" "rm" "-f" "b0e9bfeef47532bf927a5d36db98de7eb3764eedc31e33f148a221ccf6ce170f"` [INFO] [stdout] b0e9bfeef47532bf927a5d36db98de7eb3764eedc31e33f148a221ccf6ce170f