[INFO] crate semver 0.9.0 is already in cache [INFO] extracting crate semver 0.9.0 into work/ex/clippy-test-run/sources/stable/reg/semver/0.9.0 [INFO] extracting crate semver 0.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/semver/0.9.0 [INFO] validating manifest of semver-0.9.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of semver-0.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing semver-0.9.0 [INFO] finished frobbing semver-0.9.0 [INFO] frobbed toml for semver-0.9.0 written to work/ex/clippy-test-run/sources/stable/reg/semver/0.9.0/Cargo.toml [INFO] started frobbing semver-0.9.0 [INFO] finished frobbing semver-0.9.0 [INFO] frobbed toml for semver-0.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/semver/0.9.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting semver-0.9.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/semver/0.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 144b1e5e5ee55d4293c0db606308a3de84a0cf6f5a52ed4cf4fdff7cc58b06f6 [INFO] running `"docker" "start" "-a" "144b1e5e5ee55d4293c0db606308a3de84a0cf6f5a52ed4cf4fdff7cc58b06f6"` [INFO] [stderr] Compiling cc v1.0.28 [INFO] [stderr] Compiling pkg-config v0.3.14 [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Compiling proc-macro2 v0.4.26 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling serde v1.0.85 [INFO] [stderr] Compiling ryu v0.2.7 [INFO] [stderr] Checking semver v0.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | major: major, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `major` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | minor: minor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | patch: patch, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `patch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `unicode-xid`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `proc-macro2`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `serde`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `std::result` [INFO] [stderr] --> src/version_req.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use std::result; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/version_req.rs:251:9 [INFO] [stderr] | [INFO] [stderr] 251 | / return match VersionReq::parse_deprecated(input) { [INFO] [stderr] 252 | | Some(v) => { [INFO] [stderr] 253 | | Err(ReqParseError::DeprecatedVersionRequirement(v)) [INFO] [stderr] 254 | | } [INFO] [stderr] 255 | | None => Err(From::from(res.err().unwrap())), [INFO] [stderr] 256 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 251 | match VersionReq::parse_deprecated(input) { [INFO] [stderr] 252 | Some(v) => { [INFO] [stderr] 253 | Err(ReqParseError::DeprecatedVersionRequirement(v)) [INFO] [stderr] 254 | } [INFO] [stderr] 255 | None => Err(From::from(res.err().unwrap())), [INFO] [stderr] 256 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/version_req.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | / return match version { [INFO] [stderr] 261 | | ".*" => Some(VersionReq::any()), [INFO] [stderr] 262 | | "0.1.0." => Some(VersionReq::parse("0.1.0").unwrap()), [INFO] [stderr] 263 | | "0.3.1.3" => Some(VersionReq::parse("0.3.13").unwrap()), [INFO] [stderr] ... | [INFO] [stderr] 266 | | _ => None, [INFO] [stderr] 267 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 260 | match version { [INFO] [stderr] 261 | ".*" => Some(VersionReq::any()), [INFO] [stderr] 262 | "0.1.0." => Some(VersionReq::parse("0.1.0").unwrap()), [INFO] [stderr] 263 | "0.3.1.3" => Some(VersionReq::parse("0.3.13").unwrap()), [INFO] [stderr] 264 | "0.2*" => Some(VersionReq::parse("0.2.*").unwrap()), [INFO] [stderr] 265 | "*.0" => Some(VersionReq::any()), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `ryu`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `libc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `pkg-config`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/version.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | / match self { [INFO] [stderr] 182 | | &SemVerError::ParseError(ref m) => write!(f, "{}", m), [INFO] [stderr] 183 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 181 | match *self { [INFO] [stderr] 182 | SemVerError::ParseError(ref m) => write!(f, "{}", m), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/version.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | / match self { [INFO] [stderr] 190 | | &SemVerError::ParseError(ref m) => m, [INFO] [stderr] 191 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 189 | match *self { [INFO] [stderr] 190 | SemVerError::ParseError(ref m) => m, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/version_req.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | / match self { [INFO] [stderr] 172 | | &InvalidVersionRequirement => "the given version requirement is invalid", [INFO] [stderr] 173 | | &OpAlreadySet => { [INFO] [stderr] 174 | | "you have already provided an operation, such as =, ~, or ^; only use one" [INFO] [stderr] ... | [INFO] [stderr] 183 | | &DeprecatedVersionRequirement(_) => "This requirement is deprecated", [INFO] [stderr] 184 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 171 | match *self { [INFO] [stderr] 172 | InvalidVersionRequirement => "the given version requirement is invalid", [INFO] [stderr] 173 | OpAlreadySet => { [INFO] [stderr] 174 | "you have already provided an operation, such as =, ~, or ^; only use one" [INFO] [stderr] 175 | }, [INFO] [stderr] 176 | InvalidSigil => "the sigil you have written is not correct", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/version_req.rs:522:17 [INFO] [stderr] | [INFO] [stderr] 522 | / match self.minor { [INFO] [stderr] 523 | | Some(v) => try!(write!(fmt, ".{}", v)), [INFO] [stderr] 524 | | None => (), [INFO] [stderr] 525 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(v) = self.minor { try!(write!(fmt, ".{}", v)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/version_req.rs:527:17 [INFO] [stderr] | [INFO] [stderr] 527 | / match self.patch { [INFO] [stderr] 528 | | Some(v) => try!(write!(fmt, ".{}", v)), [INFO] [stderr] 529 | | None => (), [INFO] [stderr] 530 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(v) = self.patch { try!(write!(fmt, ".{}", v)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `cc`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "144b1e5e5ee55d4293c0db606308a3de84a0cf6f5a52ed4cf4fdff7cc58b06f6"` [INFO] running `"docker" "rm" "-f" "144b1e5e5ee55d4293c0db606308a3de84a0cf6f5a52ed4cf4fdff7cc58b06f6"` [INFO] [stdout] 144b1e5e5ee55d4293c0db606308a3de84a0cf6f5a52ed4cf4fdff7cc58b06f6