[INFO] crate sea-canal 0.3.0 is already in cache [INFO] extracting crate sea-canal 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/sea-canal/0.3.0 [INFO] extracting crate sea-canal 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sea-canal/0.3.0 [INFO] validating manifest of sea-canal-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sea-canal-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sea-canal-0.3.0 [INFO] finished frobbing sea-canal-0.3.0 [INFO] frobbed toml for sea-canal-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/sea-canal/0.3.0/Cargo.toml [INFO] started frobbing sea-canal-0.3.0 [INFO] finished frobbing sea-canal-0.3.0 [INFO] frobbed toml for sea-canal-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sea-canal/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sea-canal-0.3.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/sea-canal/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c6ecfccf4cce2b73dd6b6000cfd6a6efa175e94fae5665c2fa2f9d4c44cd7da6 [INFO] running `"docker" "start" "-a" "c6ecfccf4cce2b73dd6b6000cfd6a6efa175e94fae5665c2fa2f9d4c44cd7da6"` [INFO] [stderr] Checking sea-canal v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stepper.rs:9:19 [INFO] [stderr] | [INFO] [stderr] 9 | Stepper { start: start, end: end, step: step } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stepper.rs:9:33 [INFO] [stderr] | [INFO] [stderr] 9 | Stepper { start: start, end: end, step: step } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stepper.rs:9:43 [INFO] [stderr] | [INFO] [stderr] 9 | Stepper { start: start, end: end, step: step } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pattern.rs:58:29 [INFO] [stderr] | [INFO] [stderr] 58 | CustomPatternElem { check: check, repr: String::from(repr) } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `check` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analyzer.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | meta: meta, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/meta.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | MetaAnalyzer { choices: choices } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `choices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stepper.rs:9:19 [INFO] [stderr] | [INFO] [stderr] 9 | Stepper { start: start, end: end, step: step } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stepper.rs:9:33 [INFO] [stderr] | [INFO] [stderr] 9 | Stepper { start: start, end: end, step: step } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stepper.rs:9:43 [INFO] [stderr] | [INFO] [stderr] 9 | Stepper { start: start, end: end, step: step } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pattern.rs:58:29 [INFO] [stderr] | [INFO] [stderr] 58 | CustomPatternElem { check: check, repr: String::from(repr) } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `check` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/analyzer.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | meta: meta, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/meta.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | MetaAnalyzer { choices: choices } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `choices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/analyzer.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/analyzer.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/analyzer.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/analyzer.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/pattern.rs:68:19 [INFO] [stderr] | [INFO] [stderr] 68 | fn fmt(&self, mut fmt: &mut Formatter) -> Result<(), Error> { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/pattern.rs:160:19 [INFO] [stderr] | [INFO] [stderr] 160 | fn fmt(&self, mut fmt: &mut Formatter) -> Result<(), Error> { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/analyzer.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | for i in 1..max + 1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/analyzer.rs:98:18 [INFO] [stderr] | [INFO] [stderr] 98 | for i in 1..max + 1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/analyzer.rs:120:15 [INFO] [stderr] | [INFO] [stderr] 120 | slice.into_iter().fold(base, |set, choice| set.intersection(&choice.0).cloned().collect()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/analyzer.rs:127:55 [INFO] [stderr] | [INFO] [stderr] 127 | meta_analyzer.find_patterns().into_iter().map(|pat| PatternElem::Meta(pat)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PatternElem::Meta` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/repeat.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | if !chunk.iter().zip(first.iter()).into_iter().all(|(x, y)| is_match(x, y)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `chunk.iter().zip(first.iter())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/pattern.rs:68:19 [INFO] [stderr] | [INFO] [stderr] 68 | fn fmt(&self, mut fmt: &mut Formatter) -> Result<(), Error> { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/pattern.rs:160:19 [INFO] [stderr] | [INFO] [stderr] 160 | fn fmt(&self, mut fmt: &mut Formatter) -> Result<(), Error> { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/analyzer.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | for i in 1..max + 1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/analyzer.rs:98:18 [INFO] [stderr] | [INFO] [stderr] 98 | for i in 1..max + 1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/analyzer.rs:120:15 [INFO] [stderr] | [INFO] [stderr] 120 | slice.into_iter().fold(base, |set, choice| set.intersection(&choice.0).cloned().collect()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/analyzer.rs:127:55 [INFO] [stderr] | [INFO] [stderr] 127 | meta_analyzer.find_patterns().into_iter().map(|pat| PatternElem::Meta(pat)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PatternElem::Meta` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/repeat.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | if !chunk.iter().zip(first.iter()).into_iter().all(|(x, y)| is_match(x, y)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `chunk.iter().zip(first.iter())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: for loop over `analyzer.find_any_pattern(3)`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/bin/scnl.rs:39:16 [INFO] [stderr] | [INFO] [stderr] 39 | for pat in analyzer.find_any_pattern(3) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_option)] on by default [INFO] [stderr] = help: consider replacing `for pat in analyzer.find_any_pattern(3)` with `if let Some(pat) = analyzer.find_any_pattern(3)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] error: for loop over `analyzer.find_any_pattern_of_length(1)`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/bin/scnl.rs:56:16 [INFO] [stderr] | [INFO] [stderr] 56 | for pat in analyzer.find_any_pattern_of_length(1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for pat in analyzer.find_any_pattern_of_length(1)` with `if let Some(pat) = analyzer.find_any_pattern_of_length(1)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sea-canal`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: for loop over `analyzer.find_any_pattern(3)`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/bin/scnl.rs:39:16 [INFO] [stderr] | [INFO] [stderr] 39 | for pat in analyzer.find_any_pattern(3) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_option)] on by default [INFO] [stderr] = help: consider replacing `for pat in analyzer.find_any_pattern(3)` with `if let Some(pat) = analyzer.find_any_pattern(3)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] error: for loop over `analyzer.find_any_pattern_of_length(1)`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/bin/scnl.rs:56:16 [INFO] [stderr] | [INFO] [stderr] 56 | for pat in analyzer.find_any_pattern_of_length(1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for pat in analyzer.find_any_pattern_of_length(1)` with `if let Some(pat) = analyzer.find_any_pattern_of_length(1)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sea-canal`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "c6ecfccf4cce2b73dd6b6000cfd6a6efa175e94fae5665c2fa2f9d4c44cd7da6"` [INFO] running `"docker" "rm" "-f" "c6ecfccf4cce2b73dd6b6000cfd6a6efa175e94fae5665c2fa2f9d4c44cd7da6"` [INFO] [stdout] c6ecfccf4cce2b73dd6b6000cfd6a6efa175e94fae5665c2fa2f9d4c44cd7da6