[INFO] crate screenshot-rs 0.1.2 is already in cache [INFO] extracting crate screenshot-rs 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/screenshot-rs/0.1.2 [INFO] extracting crate screenshot-rs 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/screenshot-rs/0.1.2 [INFO] validating manifest of screenshot-rs-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of screenshot-rs-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing screenshot-rs-0.1.2 [INFO] finished frobbing screenshot-rs-0.1.2 [INFO] frobbed toml for screenshot-rs-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/screenshot-rs/0.1.2/Cargo.toml [INFO] started frobbing screenshot-rs-0.1.2 [INFO] finished frobbing screenshot-rs-0.1.2 [INFO] frobbed toml for screenshot-rs-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/screenshot-rs/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting screenshot-rs-0.1.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/screenshot-rs/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9d59c0b78c46d89dbef29571379a7ee43c6bc3220d876e8c02702513aec96800 [INFO] running `"docker" "start" "-a" "9d59c0b78c46d89dbef29571379a7ee43c6bc3220d876e8c02702513aec96800"` [INFO] [stderr] Checking screenshot-rs v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / return match env::var("XDG_SESSION_TYPE") { [INFO] [stderr] 28 | | Ok(ok) => match ok.to_lowercase().as_ref() { [INFO] [stderr] 29 | | "wayland" => SessionKind::Wayland, [INFO] [stderr] 30 | | _ => SessionKind::X11, [INFO] [stderr] 31 | | }, [INFO] [stderr] 32 | | Err(_) => SessionKind::X11, [INFO] [stderr] 33 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 27 | match env::var("XDG_SESSION_TYPE") { [INFO] [stderr] 28 | Ok(ok) => match ok.to_lowercase().as_ref() { [INFO] [stderr] 29 | "wayland" => SessionKind::Wayland, [INFO] [stderr] 30 | _ => SessionKind::X11, [INFO] [stderr] 31 | }, [INFO] [stderr] 32 | Err(_) => SessionKind::X11, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / return match session { [INFO] [stderr] 38 | | SessionKind::Wayland => match Command::new("gnome-screenshot").arg("--version").spawn() { [INFO] [stderr] 39 | | Ok(_) => DesktopKind::GNOME, [INFO] [stderr] 40 | | Err(_) => match Command::new("spectacle").arg("--version").spawn() { [INFO] [stderr] ... | [INFO] [stderr] 54 | | }, [INFO] [stderr] 55 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 37 | match session { [INFO] [stderr] 38 | SessionKind::Wayland => match Command::new("gnome-screenshot").arg("--version").spawn() { [INFO] [stderr] 39 | Ok(_) => DesktopKind::GNOME, [INFO] [stderr] 40 | Err(_) => match Command::new("spectacle").arg("--version").spawn() { [INFO] [stderr] 41 | Ok(_) => DesktopKind::KDE, [INFO] [stderr] 42 | Err(_) => panic!("Uncompatible Wayland desktop"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / return match env::var("XDG_SESSION_TYPE") { [INFO] [stderr] 28 | | Ok(ok) => match ok.to_lowercase().as_ref() { [INFO] [stderr] 29 | | "wayland" => SessionKind::Wayland, [INFO] [stderr] 30 | | _ => SessionKind::X11, [INFO] [stderr] 31 | | }, [INFO] [stderr] 32 | | Err(_) => SessionKind::X11, [INFO] [stderr] 33 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 27 | match env::var("XDG_SESSION_TYPE") { [INFO] [stderr] 28 | Ok(ok) => match ok.to_lowercase().as_ref() { [INFO] [stderr] 29 | "wayland" => SessionKind::Wayland, [INFO] [stderr] 30 | _ => SessionKind::X11, [INFO] [stderr] 31 | }, [INFO] [stderr] 32 | Err(_) => SessionKind::X11, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / return match session { [INFO] [stderr] 38 | | SessionKind::Wayland => match Command::new("gnome-screenshot").arg("--version").spawn() { [INFO] [stderr] 39 | | Ok(_) => DesktopKind::GNOME, [INFO] [stderr] 40 | | Err(_) => match Command::new("spectacle").arg("--version").spawn() { [INFO] [stderr] ... | [INFO] [stderr] 54 | | }, [INFO] [stderr] 55 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 37 | match session { [INFO] [stderr] 38 | SessionKind::Wayland => match Command::new("gnome-screenshot").arg("--version").spawn() { [INFO] [stderr] 39 | Ok(_) => DesktopKind::GNOME, [INFO] [stderr] 40 | Err(_) => match Command::new("spectacle").arg("--version").spawn() { [INFO] [stderr] 41 | Ok(_) => DesktopKind::KDE, [INFO] [stderr] 42 | Err(_) => panic!("Uncompatible Wayland desktop"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | Err(_) => panic!("Uncompatible Wayland desktop"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | Err(_) => panic!("Uncompatible X11 desktop (install scrot)"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | Err(_) => panic!("Uncompatible Wayland desktop"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | Err(_) => panic!("Uncompatible X11 desktop (install scrot)"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.81s [INFO] running `"docker" "inspect" "9d59c0b78c46d89dbef29571379a7ee43c6bc3220d876e8c02702513aec96800"` [INFO] running `"docker" "rm" "-f" "9d59c0b78c46d89dbef29571379a7ee43c6bc3220d876e8c02702513aec96800"` [INFO] [stdout] 9d59c0b78c46d89dbef29571379a7ee43c6bc3220d876e8c02702513aec96800