[INFO] crate scanlex 0.1.2 is already in cache [INFO] extracting crate scanlex 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/scanlex/0.1.2 [INFO] extracting crate scanlex 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/scanlex/0.1.2 [INFO] validating manifest of scanlex-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of scanlex-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing scanlex-0.1.2 [INFO] finished frobbing scanlex-0.1.2 [INFO] frobbed toml for scanlex-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/scanlex/0.1.2/Cargo.toml [INFO] started frobbing scanlex-0.1.2 [INFO] finished frobbing scanlex-0.1.2 [INFO] frobbed toml for scanlex-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/scanlex/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting scanlex-0.1.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/scanlex/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5410e35ed555d6e7db3e471498a97892a5b23440899feb73c2cc06392b0ec7b4 [INFO] running `"docker" "start" "-a" "5410e35ed555d6e7db3e471498a97892a5b23440899feb73c2cc06392b0ec7b4"` [INFO] [stderr] Checking scanlex v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:357:13 [INFO] [stderr] | [INFO] [stderr] 357 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:359:13 [INFO] [stderr] | [INFO] [stderr] 359 | lineno: lineno, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `lineno` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:357:13 [INFO] [stderr] | [INFO] [stderr] 357 | iter: iter, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:359:13 [INFO] [stderr] | [INFO] [stderr] 359 | lineno: lineno, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `lineno` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/lib.rs:167:10 [INFO] [stderr] | [INFO] [stderr] 167 | } else [INFO] [stderr] | __________^ [INFO] [stderr] 168 | | if num > I::max_value() { [INFO] [stderr] | |________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:496:17 [INFO] [stderr] | [INFO] [stderr] 496 | / return match f64::from_str(&s) { [INFO] [stderr] 497 | | Ok(x) => Num(x), [INFO] [stderr] 498 | | Err(e) => self.token_error(&format!("bad floating-point number {:?}",s),Some(&e)) [INFO] [stderr] 499 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 496 | match f64::from_str(&s) { [INFO] [stderr] 497 | Ok(x) => Num(x), [INFO] [stderr] 498 | Err(e) => self.token_error(&format!("bad floating-point number {:?}",s),Some(&e)) [INFO] [stderr] 499 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:504:17 [INFO] [stderr] | [INFO] [stderr] 504 | / return match i64::from_str(&s) { [INFO] [stderr] 505 | | Ok(x) => Int(x), [INFO] [stderr] 506 | | Err(e) => [INFO] [stderr] 507 | | self.token_error(&format!("bad integer {:?}",s),Some(&e)) [INFO] [stderr] 508 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 504 | match i64::from_str(&s) { [INFO] [stderr] 505 | Ok(x) => Int(x), [INFO] [stderr] 506 | Err(e) => [INFO] [stderr] 507 | self.token_error(&format!("bad integer {:?}",s),Some(&e)) [INFO] [stderr] 508 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/lib.rs:510:10 [INFO] [stderr] | [INFO] [stderr] 510 | } else [INFO] [stderr] | __________^ [INFO] [stderr] 511 | | if self.ch == '\'' || self.ch == '\"' { [INFO] [stderr] | |________^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/lib.rs:461:22 [INFO] [stderr] | [INFO] [stderr] 461 | } else [INFO] [stderr] | ______________________^ [INFO] [stderr] 462 | | if ! self.is_digit() { // false alarm, wuz just a char... [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/lib.rs:518:10 [INFO] [stderr] | [INFO] [stderr] 518 | } else [INFO] [stderr] | __________^ [INFO] [stderr] 519 | | if self.ch.is_alphabetic() { [INFO] [stderr] | |________^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/lib.rs:167:10 [INFO] [stderr] | [INFO] [stderr] 167 | } else [INFO] [stderr] | __________^ [INFO] [stderr] 168 | | if num > I::max_value() { [INFO] [stderr] | |________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:496:17 [INFO] [stderr] | [INFO] [stderr] 496 | / return match f64::from_str(&s) { [INFO] [stderr] 497 | | Ok(x) => Num(x), [INFO] [stderr] 498 | | Err(e) => self.token_error(&format!("bad floating-point number {:?}",s),Some(&e)) [INFO] [stderr] 499 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 496 | match f64::from_str(&s) { [INFO] [stderr] 497 | Ok(x) => Num(x), [INFO] [stderr] 498 | Err(e) => self.token_error(&format!("bad floating-point number {:?}",s),Some(&e)) [INFO] [stderr] 499 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:504:17 [INFO] [stderr] | [INFO] [stderr] 504 | / return match i64::from_str(&s) { [INFO] [stderr] 505 | | Ok(x) => Int(x), [INFO] [stderr] 506 | | Err(e) => [INFO] [stderr] 507 | | self.token_error(&format!("bad integer {:?}",s),Some(&e)) [INFO] [stderr] 508 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 504 | match i64::from_str(&s) { [INFO] [stderr] 505 | Ok(x) => Int(x), [INFO] [stderr] 506 | Err(e) => [INFO] [stderr] 507 | self.token_error(&format!("bad integer {:?}",s),Some(&e)) [INFO] [stderr] 508 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/lib.rs:510:10 [INFO] [stderr] | [INFO] [stderr] 510 | } else [INFO] [stderr] | __________^ [INFO] [stderr] 511 | | if self.ch == '\'' || self.ch == '\"' { [INFO] [stderr] | |________^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/lib.rs:461:22 [INFO] [stderr] | [INFO] [stderr] 461 | } else [INFO] [stderr] | ______________________^ [INFO] [stderr] 462 | | if ! self.is_digit() { // false alarm, wuz just a char... [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/lib.rs:518:10 [INFO] [stderr] | [INFO] [stderr] 518 | } else [INFO] [stderr] | __________^ [INFO] [stderr] 519 | | if self.ch.is_alphabetic() { [INFO] [stderr] | |________^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:737:35 [INFO] [stderr] | [INFO] [stderr] 737 | assert_eq!(scan.get(),Num(2000000.0)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `2_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/int.rs:15:31 [INFO] [stderr] | [INFO] [stderr] 15 | $t::min_value() as i64 [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from())` [INFO] [stderr] ... [INFO] [stderr] 33 | impl_int!(i8); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/int.rs:19:31 [INFO] [stderr] | [INFO] [stderr] 19 | $t::max_value() as i64 [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from())` [INFO] [stderr] ... [INFO] [stderr] 33 | impl_int!(i8); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/int.rs:15:31 [INFO] [stderr] | [INFO] [stderr] 15 | $t::min_value() as i64 [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from())` [INFO] [stderr] ... [INFO] [stderr] 34 | impl_int!(i16); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/int.rs:19:31 [INFO] [stderr] | [INFO] [stderr] 19 | $t::max_value() as i64 [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from())` [INFO] [stderr] ... [INFO] [stderr] 34 | impl_int!(i16); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/int.rs:15:31 [INFO] [stderr] | [INFO] [stderr] 15 | $t::min_value() as i64 [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from())` [INFO] [stderr] ... [INFO] [stderr] 35 | impl_int!(i32); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/int.rs:19:31 [INFO] [stderr] | [INFO] [stderr] 19 | $t::max_value() as i64 [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from())` [INFO] [stderr] ... [INFO] [stderr] 35 | impl_int!(i32); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/int.rs:15:31 [INFO] [stderr] | [INFO] [stderr] 15 | $t::min_value() as i64 [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from())` [INFO] [stderr] ... [INFO] [stderr] 38 | impl_int!(u8); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/int.rs:19:31 [INFO] [stderr] | [INFO] [stderr] 19 | $t::max_value() as i64 [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from())` [INFO] [stderr] ... [INFO] [stderr] 38 | impl_int!(u8); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/int.rs:15:31 [INFO] [stderr] | [INFO] [stderr] 15 | $t::min_value() as i64 [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from())` [INFO] [stderr] ... [INFO] [stderr] 39 | impl_int!(u16); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/int.rs:19:31 [INFO] [stderr] | [INFO] [stderr] 19 | $t::max_value() as i64 [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from())` [INFO] [stderr] ... [INFO] [stderr] 39 | impl_int!(u16); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/int.rs:15:31 [INFO] [stderr] | [INFO] [stderr] 15 | $t::min_value() as i64 [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from())` [INFO] [stderr] ... [INFO] [stderr] 40 | impl_int!(u32); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/int.rs:19:31 [INFO] [stderr] | [INFO] [stderr] 19 | $t::max_value() as i64 [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from())` [INFO] [stderr] ... [INFO] [stderr] 40 | impl_int!(u32); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:123:21 [INFO] [stderr] | [INFO] [stderr] 123 | pub fn to_float(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:131:28 [INFO] [stderr] | [INFO] [stderr] 131 | pub fn to_float_result(self) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:147:23 [INFO] [stderr] | [INFO] [stderr] 147 | pub fn to_integer(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:155:30 [INFO] [stderr] | [INFO] [stderr] 155 | pub fn to_integer_result(self) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:163:34 [INFO] [stderr] | [INFO] [stderr] 163 | pub fn to_int_result(self) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:183:22 [INFO] [stderr] | [INFO] [stderr] 183 | pub fn to_number(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:192:29 [INFO] [stderr] | [INFO] [stderr] 192 | pub fn to_number_result(self) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:209:22 [INFO] [stderr] | [INFO] [stderr] 209 | pub fn to_string(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:225:29 [INFO] [stderr] | [INFO] [stderr] 225 | pub fn to_string_result(self) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:241:20 [INFO] [stderr] | [INFO] [stderr] 241 | pub fn to_iden(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:258:27 [INFO] [stderr] | [INFO] [stderr] 258 | pub fn to_iden_result(self) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:274:20 [INFO] [stderr] | [INFO] [stderr] 274 | pub fn to_char(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:290:27 [INFO] [stderr] | [INFO] [stderr] 290 | pub fn to_char_result(self) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:306:21 [INFO] [stderr] | [INFO] [stderr] 306 | pub fn to_error(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib.rs:408:9 [INFO] [stderr] | [INFO] [stderr] 408 | if self.ch == '\0' {false} else {true} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!(self.ch == '\0')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:693:5 [INFO] [stderr] | [INFO] [stderr] 693 | / pub fn next(&'a mut self) -> Option>> { [INFO] [stderr] 694 | | self.line.clear(); [INFO] [stderr] 695 | | match self.rdr.read_line(&mut self.line) { [INFO] [stderr] 696 | | Ok(nbytes) => if nbytes == 0 { [INFO] [stderr] ... | [INFO] [stderr] 702 | | Some(Ok(Scanner::new_ex(&self.line,self.lineno))) [INFO] [stderr] 703 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/scan.rs:5:48 [INFO] [stderr] | [INFO] [stderr] 5 | let text = std::env::args().skip(1).next().unwrap_or(def.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| def.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> examples/scan.rs:5:16 [INFO] [stderr] | [INFO] [stderr] 5 | let text = std::env::args().skip(1).next().unwrap_or(def.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> tests/json.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | } else [INFO] [stderr] | ______________^ [INFO] [stderr] 45 | | if c == '{' { [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/int.rs:15:31 [INFO] [stderr] | [INFO] [stderr] 15 | $t::min_value() as i64 [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from())` [INFO] [stderr] ... [INFO] [stderr] 33 | impl_int!(i8); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/int.rs:19:31 [INFO] [stderr] | [INFO] [stderr] 19 | $t::max_value() as i64 [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from())` [INFO] [stderr] ... [INFO] [stderr] 33 | impl_int!(i8); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/int.rs:15:31 [INFO] [stderr] | [INFO] [stderr] 15 | $t::min_value() as i64 [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from())` [INFO] [stderr] ... [INFO] [stderr] 34 | impl_int!(i16); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/int.rs:19:31 [INFO] [stderr] | [INFO] [stderr] 19 | $t::max_value() as i64 [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from())` [INFO] [stderr] ... [INFO] [stderr] 34 | impl_int!(i16); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/int.rs:15:31 [INFO] [stderr] | [INFO] [stderr] 15 | $t::min_value() as i64 [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from())` [INFO] [stderr] ... [INFO] [stderr] 35 | impl_int!(i32); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/int.rs:19:31 [INFO] [stderr] | [INFO] [stderr] 19 | $t::max_value() as i64 [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from())` [INFO] [stderr] ... [INFO] [stderr] 35 | impl_int!(i32); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/int.rs:15:31 [INFO] [stderr] | [INFO] [stderr] 15 | $t::min_value() as i64 [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from())` [INFO] [stderr] ... [INFO] [stderr] 38 | impl_int!(u8); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/int.rs:19:31 [INFO] [stderr] | [INFO] [stderr] 19 | $t::max_value() as i64 [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from())` [INFO] [stderr] ... [INFO] [stderr] 38 | impl_int!(u8); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/int.rs:15:31 [INFO] [stderr] | [INFO] [stderr] 15 | $t::min_value() as i64 [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from())` [INFO] [stderr] ... [INFO] [stderr] 39 | impl_int!(u16); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/int.rs:19:31 [INFO] [stderr] | [INFO] [stderr] 19 | $t::max_value() as i64 [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from())` [INFO] [stderr] ... [INFO] [stderr] 39 | impl_int!(u16); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/int.rs:15:31 [INFO] [stderr] | [INFO] [stderr] 15 | $t::min_value() as i64 [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from())` [INFO] [stderr] ... [INFO] [stderr] 40 | impl_int!(u32); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/int.rs:19:31 [INFO] [stderr] | [INFO] [stderr] 19 | $t::max_value() as i64 [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from())` [INFO] [stderr] ... [INFO] [stderr] 40 | impl_int!(u32); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:123:21 [INFO] [stderr] | [INFO] [stderr] 123 | pub fn to_float(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:131:28 [INFO] [stderr] | [INFO] [stderr] 131 | pub fn to_float_result(self) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:147:23 [INFO] [stderr] | [INFO] [stderr] 147 | pub fn to_integer(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:155:30 [INFO] [stderr] | [INFO] [stderr] 155 | pub fn to_integer_result(self) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:163:34 [INFO] [stderr] | [INFO] [stderr] 163 | pub fn to_int_result(self) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:183:22 [INFO] [stderr] | [INFO] [stderr] 183 | pub fn to_number(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:192:29 [INFO] [stderr] | [INFO] [stderr] 192 | pub fn to_number_result(self) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:209:22 [INFO] [stderr] | [INFO] [stderr] 209 | pub fn to_string(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:225:29 [INFO] [stderr] | [INFO] [stderr] 225 | pub fn to_string_result(self) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:241:20 [INFO] [stderr] | [INFO] [stderr] 241 | pub fn to_iden(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:258:27 [INFO] [stderr] | [INFO] [stderr] 258 | pub fn to_iden_result(self) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:274:20 [INFO] [stderr] | [INFO] [stderr] 274 | pub fn to_char(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:290:27 [INFO] [stderr] | [INFO] [stderr] 290 | pub fn to_char_result(self) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:306:21 [INFO] [stderr] | [INFO] [stderr] 306 | pub fn to_error(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib.rs:408:9 [INFO] [stderr] | [INFO] [stderr] 408 | if self.ch == '\0' {false} else {true} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!(self.ch == '\0')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:693:5 [INFO] [stderr] | [INFO] [stderr] 693 | / pub fn next(&'a mut self) -> Option>> { [INFO] [stderr] 694 | | self.line.clear(); [INFO] [stderr] 695 | | match self.rdr.read_line(&mut self.line) { [INFO] [stderr] 696 | | Ok(nbytes) => if nbytes == 0 { [INFO] [stderr] ... | [INFO] [stderr] 702 | | Some(Ok(Scanner::new_ex(&self.line,self.lineno))) [INFO] [stderr] 703 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:728:9 [INFO] [stderr] | [INFO] [stderr] 728 | assert_eq!(scan.get_number().unwrap(), 42.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:728:9 [INFO] [stderr] | [INFO] [stderr] 728 | assert_eq!(scan.get_number().unwrap(), 42.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `scanlex`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5410e35ed555d6e7db3e471498a97892a5b23440899feb73c2cc06392b0ec7b4"` [INFO] running `"docker" "rm" "-f" "5410e35ed555d6e7db3e471498a97892a5b23440899feb73c2cc06392b0ec7b4"` [INFO] [stdout] 5410e35ed555d6e7db3e471498a97892a5b23440899feb73c2cc06392b0ec7b4