[INFO] crate ruuvi-sensor-protocol 0.2.0 is already in cache [INFO] extracting crate ruuvi-sensor-protocol 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/ruuvi-sensor-protocol/0.2.0 [INFO] extracting crate ruuvi-sensor-protocol 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ruuvi-sensor-protocol/0.2.0 [INFO] validating manifest of ruuvi-sensor-protocol-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ruuvi-sensor-protocol-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ruuvi-sensor-protocol-0.2.0 [INFO] finished frobbing ruuvi-sensor-protocol-0.2.0 [INFO] frobbed toml for ruuvi-sensor-protocol-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/ruuvi-sensor-protocol/0.2.0/Cargo.toml [INFO] started frobbing ruuvi-sensor-protocol-0.2.0 [INFO] finished frobbing ruuvi-sensor-protocol-0.2.0 [INFO] frobbed toml for ruuvi-sensor-protocol-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ruuvi-sensor-protocol/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ruuvi-sensor-protocol-0.2.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ruuvi-sensor-protocol/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e358987cfb7d0c58c6729c7fb5ffd50cc8297d0e7f7790f994ef47832ce47071 [INFO] running `"docker" "start" "-a" "e358987cfb7d0c58c6729c7fb5ffd50cc8297d0e7f7790f994ef47832ce47071"` [INFO] [stderr] Checking ruuvi-sensor-protocol v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/formats/generic.rs:47:28 [INFO] [stderr] | [INFO] [stderr] 47 | if id == 0x0499 && value.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/formats/generic.rs:59:19 [INFO] [stderr] | [INFO] [stderr] 59 | } else if value.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/formats/v3.rs:52:6 [INFO] [stderr] | [INFO] [stderr] 52 | ((b1 as u16) << 8) | b2 as u16 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(b1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/formats/v3.rs:52:26 [INFO] [stderr] | [INFO] [stderr] 52 | ((b1 as u16) << 8) | b2 as u16 [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(b2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/formats/generic.rs:47:28 [INFO] [stderr] | [INFO] [stderr] 47 | if id == 0x0499 && value.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/formats/generic.rs:59:19 [INFO] [stderr] | [INFO] [stderr] 59 | } else if value.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/formats/v3.rs:52:6 [INFO] [stderr] | [INFO] [stderr] 52 | ((b1 as u16) << 8) | b2 as u16 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(b1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/formats/v3.rs:52:26 [INFO] [stderr] | [INFO] [stderr] 52 | ((b1 as u16) << 8) | b2 as u16 [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(b2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.83s [INFO] running `"docker" "inspect" "e358987cfb7d0c58c6729c7fb5ffd50cc8297d0e7f7790f994ef47832ce47071"` [INFO] running `"docker" "rm" "-f" "e358987cfb7d0c58c6729c7fb5ffd50cc8297d0e7f7790f994ef47832ce47071"` [INFO] [stdout] e358987cfb7d0c58c6729c7fb5ffd50cc8297d0e7f7790f994ef47832ce47071