[INFO] crate rusty_crc16 0.1.1 is already in cache [INFO] extracting crate rusty_crc16 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/rusty_crc16/0.1.1 [INFO] extracting crate rusty_crc16 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty_crc16/0.1.1 [INFO] validating manifest of rusty_crc16-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rusty_crc16-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rusty_crc16-0.1.1 [INFO] finished frobbing rusty_crc16-0.1.1 [INFO] frobbed toml for rusty_crc16-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/rusty_crc16/0.1.1/Cargo.toml [INFO] started frobbing rusty_crc16-0.1.1 [INFO] finished frobbing rusty_crc16-0.1.1 [INFO] frobbed toml for rusty_crc16-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty_crc16/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rusty_crc16-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rusty_crc16/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0609d8d8495ac193ad00efc9da1450a6ccf8e00019dff8b28165a59c37309ef7 [INFO] running `"docker" "start" "-a" "0609d8d8495ac193ad00efc9da1450a6ccf8e00019dff8b28165a59c37309ef7"` [INFO] [stderr] Checking rusty_crc16 v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crc.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | return self.calculate(bytes) == 0u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.calculate(bytes) == 0u16` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/crc.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | value = value << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `value <<= 8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/crc.rs:25:21 [INFO] [stderr] | [INFO] [stderr] 25 | value = value << 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `value <<= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/crc.rs:56:26 [INFO] [stderr] | [INFO] [stderr] 56 | reflect(i as u16, 8) as u8 [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/crc.rs:61:50 [INFO] [stderr] | [INFO] [stderr] 61 | value = self.table[((value >> 8 ) ^ current_byte as u16) as usize] ^ (value << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(current_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crc.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | return self.calculate(bytes) == 0u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.calculate(bytes) == 0u16` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/crc.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | value = value << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `value <<= 8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/crc.rs:25:21 [INFO] [stderr] | [INFO] [stderr] 25 | value = value << 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `value <<= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/crc.rs:56:26 [INFO] [stderr] | [INFO] [stderr] 56 | reflect(i as u16, 8) as u8 [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/crc.rs:61:50 [INFO] [stderr] | [INFO] [stderr] 61 | value = self.table[((value >> 8 ) ^ current_byte as u16) as usize] ^ (value << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(current_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test.rs:14:32 [INFO] [stderr] | [INFO] [stderr] 14 | let raw_bytes: &[u8] = "123456789".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"123456789"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test.rs:26:32 [INFO] [stderr] | [INFO] [stderr] 26 | let raw_bytes: &[u8] = "123456789".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"123456789"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | let mut res = crc.calculate("12345".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"12345"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test.rs:40:37 [INFO] [stderr] | [INFO] [stderr] 40 | res = crc.calculate_rolling("6789".as_bytes(), res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"6789"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.36s [INFO] running `"docker" "inspect" "0609d8d8495ac193ad00efc9da1450a6ccf8e00019dff8b28165a59c37309ef7"` [INFO] running `"docker" "rm" "-f" "0609d8d8495ac193ad00efc9da1450a6ccf8e00019dff8b28165a59c37309ef7"` [INFO] [stdout] 0609d8d8495ac193ad00efc9da1450a6ccf8e00019dff8b28165a59c37309ef7