[INFO] crate rustplotlib 0.0.4 is already in cache [INFO] extracting crate rustplotlib 0.0.4 into work/ex/clippy-test-run/sources/stable/reg/rustplotlib/0.0.4 [INFO] extracting crate rustplotlib 0.0.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustplotlib/0.0.4 [INFO] validating manifest of rustplotlib-0.0.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustplotlib-0.0.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustplotlib-0.0.4 [INFO] finished frobbing rustplotlib-0.0.4 [INFO] frobbed toml for rustplotlib-0.0.4 written to work/ex/clippy-test-run/sources/stable/reg/rustplotlib/0.0.4/Cargo.toml [INFO] started frobbing rustplotlib-0.0.4 [INFO] finished frobbing rustplotlib-0.0.4 [INFO] frobbed toml for rustplotlib-0.0.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustplotlib/0.0.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustplotlib-0.0.4 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustplotlib/0.0.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3533b2a8f6d61b7df3c4eb52726a3bb91df56fffd15428b05b2ba9eeffa0230f [INFO] running `"docker" "start" "-a" "3533b2a8f6d61b7df3c4eb52726a3bb91df56fffd15428b05b2ba9eeffa0230f"` [INFO] [stderr] Checking rustplotlib v0.0.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/mpl.rs:19:32 [INFO] [stderr] | [INFO] [stderr] 19 | let mut mpl = Matplotlib { child: child }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `child` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/mpl.rs:19:32 [INFO] [stderr] | [INFO] [stderr] 19 | let mut mpl = Matplotlib { child: child }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `child` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name [INFO] [stderr] --> src/axes2d.rs:25:3 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn add>>(mut self, p: P) -> Self { [INFO] [stderr] 26 | | self.plot_data.push(p.into()); [INFO] [stderr] 27 | | self [INFO] [stderr] 28 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/axes2d.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | for ref plot in &self.plot_data { [INFO] [stderr] | ^^^^^^^^ --------------- help: try: `let plot = &&self.plot_data;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/figure.rs:30:24 [INFO] [stderr] | [INFO] [stderr] 30 | self.axes.extend((0..remains).into_iter().map(|_| None)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..remains)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name [INFO] [stderr] --> src/axes2d.rs:25:3 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn add>>(mut self, p: P) -> Self { [INFO] [stderr] 26 | | self.plot_data.push(p.into()); [INFO] [stderr] 27 | | self [INFO] [stderr] 28 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/figure.rs:38:7 [INFO] [stderr] | [INFO] [stderr] 38 | / if let &Some(ref axes) = axes { [INFO] [stderr] 39 | | mpl.subplot(self.rows, self.cols, (i + 1) as u32)?; [INFO] [stderr] 40 | | axes.apply(mpl)?; [INFO] [stderr] 41 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 38 | if let Some(ref axes) = *axes { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/axes2d.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | for ref plot in &self.plot_data { [INFO] [stderr] | ^^^^^^^^ --------------- help: try: `let plot = &&self.plot_data;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/backend/mpl.rs:32:11 [INFO] [stderr] | [INFO] [stderr] 32 | let ref mut stdin = self.child.stdin.as_mut().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^-------------------------------------- help: try: `let stdin = &mut self.child.stdin.as_mut().unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/figure.rs:30:24 [INFO] [stderr] | [INFO] [stderr] 30 | self.axes.extend((0..remains).into_iter().map(|_| None)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..remains)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/figure.rs:38:7 [INFO] [stderr] | [INFO] [stderr] 38 | / if let &Some(ref axes) = axes { [INFO] [stderr] 39 | | mpl.subplot(self.rows, self.cols, (i + 1) as u32)?; [INFO] [stderr] 40 | | axes.apply(mpl)?; [INFO] [stderr] 41 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 38 | if let Some(ref axes) = *axes { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend/mpl.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / if let &Some(ref label) = label { [INFO] [stderr] 94 | | code += &format!("label='{}', ", label); [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 93 | if let Some(ref label) = *label { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend/mpl.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | / if let &Some(ref color) = color { [INFO] [stderr] 97 | | code += &format!("color='{}', ", color); [INFO] [stderr] 98 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 96 | if let Some(ref color) = *color { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend/mpl.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | / if let &Some(ref marker) = marker { [INFO] [stderr] 100 | | code += &format!("marker='{}', ", marker); [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 99 | if let Some(ref marker) = *marker { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/backend/mpl.rs:32:11 [INFO] [stderr] | [INFO] [stderr] 32 | let ref mut stdin = self.child.stdin.as_mut().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^-------------------------------------- help: try: `let stdin = &mut self.child.stdin.as_mut().unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend/mpl.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | / if let &Some(ref label) = label { [INFO] [stderr] 117 | | code += &format!("label='{}', ", label); [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 116 | if let Some(ref label) = *label { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend/mpl.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | / if let &Some(ref color) = color { [INFO] [stderr] 120 | | code += &format!("color='{}', ", color); [INFO] [stderr] 121 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 119 | if let Some(ref color) = *color { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend/mpl.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | / if let &Some(ref marker) = marker { [INFO] [stderr] 123 | | code += &format!("marker='{}', ", marker); [INFO] [stderr] 124 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 122 | if let Some(ref marker) = *marker { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend/mpl.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | / if let &Some(ref ls) = linestyle { [INFO] [stderr] 126 | | code += &format!("linestyle='{}', ", ls); [INFO] [stderr] 127 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 125 | if let Some(ref ls) = *linestyle { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend/mpl.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | / if let &Some(ref lw) = linewidth { [INFO] [stderr] 129 | | code += &format!("linewidth='{}', ", lw); [INFO] [stderr] 130 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 128 | if let Some(ref lw) = *linewidth { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend/mpl.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | / if let &Some(ref where_) = where_ { [INFO] [stderr] 148 | | code += &format!("where='{}', ", to_pyvec(where_)); [INFO] [stderr] 149 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 147 | if let Some(ref where_) = *where_ { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend/mpl.rs:151:5 [INFO] [stderr] | [INFO] [stderr] 151 | / if let &Some(ref step) = step { [INFO] [stderr] 152 | | code += &format!("step='{}', ", step); [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 151 | if let Some(ref step) = *step { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/backend/mod.rs:22:3 [INFO] [stderr] | [INFO] [stderr] 22 | / fn plot(&mut self, [INFO] [stderr] 23 | | xdata: &[f64], [INFO] [stderr] 24 | | ydata: &[f64], [INFO] [stderr] 25 | | label: &Option, [INFO] [stderr] ... | [INFO] [stderr] 29 | | linewidth: &Option) [INFO] [stderr] 30 | | -> io::Result<&mut Self>; [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend/mpl.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / if let &Some(ref label) = label { [INFO] [stderr] 94 | | code += &format!("label='{}', ", label); [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 93 | if let Some(ref label) = *label { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend/mpl.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | / if let &Some(ref color) = color { [INFO] [stderr] 97 | | code += &format!("color='{}', ", color); [INFO] [stderr] 98 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 96 | if let Some(ref color) = *color { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend/mpl.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | / if let &Some(ref marker) = marker { [INFO] [stderr] 100 | | code += &format!("marker='{}', ", marker); [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 99 | if let Some(ref marker) = *marker { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend/mpl.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | / if let &Some(ref label) = label { [INFO] [stderr] 117 | | code += &format!("label='{}', ", label); [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 116 | if let Some(ref label) = *label { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend/mpl.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | / if let &Some(ref color) = color { [INFO] [stderr] 120 | | code += &format!("color='{}', ", color); [INFO] [stderr] 121 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 119 | if let Some(ref color) = *color { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend/mpl.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | / if let &Some(ref marker) = marker { [INFO] [stderr] 123 | | code += &format!("marker='{}', ", marker); [INFO] [stderr] 124 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 122 | if let Some(ref marker) = *marker { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend/mpl.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | / if let &Some(ref ls) = linestyle { [INFO] [stderr] 126 | | code += &format!("linestyle='{}', ", ls); [INFO] [stderr] 127 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 125 | if let Some(ref ls) = *linestyle { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend/mpl.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | / if let &Some(ref lw) = linewidth { [INFO] [stderr] 129 | | code += &format!("linewidth='{}', ", lw); [INFO] [stderr] 130 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 128 | if let Some(ref lw) = *linewidth { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend/mpl.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | / if let &Some(ref where_) = where_ { [INFO] [stderr] 148 | | code += &format!("where='{}', ", to_pyvec(where_)); [INFO] [stderr] 149 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 147 | if let Some(ref where_) = *where_ { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend/mpl.rs:151:5 [INFO] [stderr] | [INFO] [stderr] 151 | / if let &Some(ref step) = step { [INFO] [stderr] 152 | | code += &format!("step='{}', ", step); [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 151 | if let Some(ref step) = *step { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/backend/mod.rs:22:3 [INFO] [stderr] | [INFO] [stderr] 22 | / fn plot(&mut self, [INFO] [stderr] 23 | | xdata: &[f64], [INFO] [stderr] 24 | | ydata: &[f64], [INFO] [stderr] 25 | | label: &Option, [INFO] [stderr] ... | [INFO] [stderr] 29 | | linewidth: &Option) [INFO] [stderr] 30 | | -> io::Result<&mut Self>; [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> examples/simple.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | let x: Vec = (0..40).into_iter().map(|i| (i as f64) * 0.08 * PI).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..40)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/simple.rs:56:49 [INFO] [stderr] | [INFO] [stderr] 56 | let x: Vec = (0..40).into_iter().map(|i| (i as f64) * 0.08 * PI).collect(); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.44s [INFO] running `"docker" "inspect" "3533b2a8f6d61b7df3c4eb52726a3bb91df56fffd15428b05b2ba9eeffa0230f"` [INFO] running `"docker" "rm" "-f" "3533b2a8f6d61b7df3c4eb52726a3bb91df56fffd15428b05b2ba9eeffa0230f"` [INFO] [stdout] 3533b2a8f6d61b7df3c4eb52726a3bb91df56fffd15428b05b2ba9eeffa0230f