[INFO] crate rustotp 0.1.0 is already in cache [INFO] extracting crate rustotp 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rustotp/0.1.0 [INFO] extracting crate rustotp 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustotp/0.1.0 [INFO] validating manifest of rustotp-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustotp-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustotp-0.1.0 [INFO] finished frobbing rustotp-0.1.0 [INFO] frobbed toml for rustotp-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rustotp/0.1.0/Cargo.toml [INFO] started frobbing rustotp-0.1.0 [INFO] finished frobbing rustotp-0.1.0 [INFO] frobbed toml for rustotp-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustotp/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustotp-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustotp/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9aeafdc216ef6b8d0d2ff1ba25638fb885d156284ee30d6ee208853c93ff7cdc [INFO] running `"docker" "start" "-a" "9aeafdc216ef6b8d0d2ff1ba25638fb885d156284ee30d6ee208853c93ff7cdc"` [INFO] [stderr] Checking hmac-sha1 v0.1.3 [INFO] [stderr] Checking rusthotp v0.1.0 [INFO] [stderr] Checking rustotp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: the loop variable `byte_index` is used to index `temp` [INFO] [stderr] --> src/lib.rs:7:23 [INFO] [stderr] | [INFO] [stderr] 7 | for byte_index in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 7 | for (byte_index, ) in temp.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `byte_index` is used to index `temp` [INFO] [stderr] --> src/lib.rs:7:23 [INFO] [stderr] | [INFO] [stderr] 7 | for byte_index in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 7 | for (byte_index, ) in temp.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test_main.rs:8:16 [INFO] [stderr] | [INFO] [stderr] 8 | assert_eq!(94287082, totp_value.code); [INFO] [stderr] | ^^^^^^^^ help: consider: `94_287_082` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_main.rs:5:15 [INFO] [stderr] | [INFO] [stderr] 5 | let key = "12345678901234567890".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"12345678901234567890"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.36s [INFO] running `"docker" "inspect" "9aeafdc216ef6b8d0d2ff1ba25638fb885d156284ee30d6ee208853c93ff7cdc"` [INFO] running `"docker" "rm" "-f" "9aeafdc216ef6b8d0d2ff1ba25638fb885d156284ee30d6ee208853c93ff7cdc"` [INFO] [stdout] 9aeafdc216ef6b8d0d2ff1ba25638fb885d156284ee30d6ee208853c93ff7cdc