[INFO] crate rustogram 0.1.4 is already in cache
[INFO] extracting crate rustogram 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/rustogram/0.1.4
[INFO] extracting crate rustogram 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustogram/0.1.4
[INFO] validating manifest of rustogram-0.1.4 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rustogram-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rustogram-0.1.4
[INFO] finished frobbing rustogram-0.1.4
[INFO] frobbed toml for rustogram-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/rustogram/0.1.4/Cargo.toml
[INFO] started frobbing rustogram-0.1.4
[INFO] finished frobbing rustogram-0.1.4
[INFO] frobbed toml for rustogram-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustogram/0.1.4/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rustogram-0.1.4 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rustogram/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 110ccaa9d8ca02fe69dc462db59738bb1b2fc003728f0471f95ff47b1da3198e
[INFO] running `"docker" "start" "-a" "110ccaa9d8ca02fe69dc462db59738bb1b2fc003728f0471f95ff47b1da3198e"`
[INFO] [stderr]     Checking rustogram v0.1.4 (/opt/crater/workdir)
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/histogram.rs:68:16
[INFO] [stderr]    |
[INFO] [stderr] 68 |     if cookie != (0x1c849303i32 | 0x10i32) {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^ help: consider: `0x1c84_9303i32`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/histogram.rs:179:9
[INFO] [stderr]     |
[INFO] [stderr] 179 |         return total_value / self.total_count as f64;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `total_value / self.total_count as f64`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/histogram.rs:346:14
[INFO] [stderr]     |
[INFO] [stderr] 346 |         put_i32(0x1c849303i32 | 0x10i32, target_buffer);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^ help: consider: `0x1c84_9303i32`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around method argument
[INFO] [stderr]    --> src/iter.rs:166:50
[INFO] [stderr]     |
[INFO] [stderr] 166 | /                                                  (self.total_count_to_current_index -
[INFO] [stderr] 167 | |                                                   self.total_count_to_prev_index),
[INFO] [stderr]     | |_________________________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 166 |                                                  self.total_count_to_current_index -
[INFO] [stderr] 167 |                                                   self.total_count_to_prev_index,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around method argument
[INFO] [stderr]    --> src/iter.rs:170:50
[INFO] [stderr]     |
[INFO] [stderr] 170 | /                                                  ((100.0f64 *
[INFO] [stderr] 171 | |                                                    self.total_count_to_current_index as f64) /
[INFO] [stderr] 172 | |                                                   (self.array_total_count as f64)),
[INFO] [stderr]     | |__________________________________________________________________________________^
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 170 |                                                  (100.0f64 *
[INFO] [stderr] 171 |                                                    self.total_count_to_current_index as f64) /
[INFO] [stderr] 172 |                                                   (self.array_total_count as f64),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/encoding.rs:53:2
[INFO] [stderr]    |
[INFO] [stderr] 53 |     result
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/encoding.rs:52:15
[INFO] [stderr]    |
[INFO] [stderr] 52 |     let result = sign_preserving_shift(input_value, shift) == 0;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/histogram.rs:68:16
[INFO] [stderr]    |
[INFO] [stderr] 68 |     if cookie != (0x1c849303i32 | 0x10i32) {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^ help: consider: `0x1c84_9303i32`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/histogram.rs:179:9
[INFO] [stderr]     |
[INFO] [stderr] 179 |         return total_value / self.total_count as f64;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `total_value / self.total_count as f64`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/histogram.rs:346:14
[INFO] [stderr]     |
[INFO] [stderr] 346 |         put_i32(0x1c849303i32 | 0x10i32, target_buffer);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^ help: consider: `0x1c84_9303i32`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around method argument
[INFO] [stderr]    --> src/iter.rs:166:50
[INFO] [stderr]     |
[INFO] [stderr] 166 | /                                                  (self.total_count_to_current_index -
[INFO] [stderr] 167 | |                                                   self.total_count_to_prev_index),
[INFO] [stderr]     | |_________________________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 166 |                                                  self.total_count_to_current_index -
[INFO] [stderr] 167 |                                                   self.total_count_to_prev_index,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around method argument
[INFO] [stderr]    --> src/iter.rs:170:50
[INFO] [stderr]     |
[INFO] [stderr] 170 | /                                                  ((100.0f64 *
[INFO] [stderr] 171 | |                                                    self.total_count_to_current_index as f64) /
[INFO] [stderr] 172 | |                                                   (self.array_total_count as f64)),
[INFO] [stderr]     | |__________________________________________________________________________________^
[INFO] [stderr] help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr] 170 |                                                  (100.0f64 *
[INFO] [stderr] 171 |                                                    self.total_count_to_current_index as f64) /
[INFO] [stderr] 172 |                                                   (self.array_total_count as f64),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/encoding.rs:53:2
[INFO] [stderr]    |
[INFO] [stderr] 53 |     result
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/encoding.rs:52:15
[INFO] [stderr]    |
[INFO] [stderr] 52 |     let result = sign_preserving_shift(input_value, shift) == 0;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/histogram.rs:33:29
[INFO] [stderr]    |
[INFO] [stderr] 33 |     let _sub_bucket_mask = ((_sub_bucket_count as i64) - 1) << _unit_magnitude;
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(_sub_bucket_count)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/histogram.rs:66:42
[INFO] [stderr]    |
[INFO] [stderr] 66 | pub fn deserialise_histogram(byte_array: &Vec<u8>, offset: i32) -> Option<Histogram> {
[INFO] [stderr]    |                                          ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/histogram.rs:214:18
[INFO] [stderr]     |
[INFO] [stderr] 214 |         for i in 0..(target_index + 1) {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=target_index`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/histogram.rs:225:18
[INFO] [stderr]     |
[INFO] [stderr] 225 |         for i in low_index..(high_index + 1) {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `low_index..=high_index`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/histogram.rs:427:71
[INFO] [stderr]     |
[INFO] [stderr] 427 |     fn fill_counts_array_from_source_buffer(&mut self, source_buffer: &Vec<u8>, offset: i32, length_in_bytes: i32, word_size_in_bytes: i32) -> i32 {
[INFO] [stderr]     |                                                                       ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]    --> src/histogram.rs:444:11
[INFO] [stderr]     |
[INFO] [stderr] 444 |                 if zc > std::i64::MAX {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::absurd_extreme_comparisons)] on by default
[INFO] [stderr]     = help: because std::i64::MAX is the maximum value for this type, this comparison is always false
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/histogram.rs:494:10
[INFO] [stderr]     |
[INFO] [stderr] 494 |         (self.leading_zero_count_base as i64 -
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.leading_zero_count_base)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/histogram.rs:495:10
[INFO] [stderr]     |
[INFO] [stderr] 495 |          (value | self.sub_bucket_mask as i64).leading_zeros() as i64) as i32
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((value | self.sub_bucket_mask as i64).leading_zeros())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/histogram.rs:517:9
[INFO] [stderr]     |
[INFO] [stderr] 517 |         (sub_bucket_index as i64) << (bucket_index + self.unit_magnitude)
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(sub_bucket_index)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/histogram.rs:579:43
[INFO] [stderr]     |
[INFO] [stderr] 579 |     let mut smallest_untrackable_value = ((sub_bucket_count as i64) << unit_magnitude) as i64;
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(sub_bucket_count)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `iter::HistogramIterationValue`
[INFO] [stderr]   --> src/iter.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 | /     pub fn new() -> HistogramIterationValue {
[INFO] [stderr] 18 | |         HistogramIterationValue {
[INFO] [stderr] 19 | |             value_iterated_to: 0,
[INFO] [stderr] 20 | |             value_iterated_from: 0,
[INFO] [stderr] ...  |
[INFO] [stderr] 27 | |         }
[INFO] [stderr] 28 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 5  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (9/7)
[INFO] [stderr]   --> src/iter.rs:30:5
[INFO] [stderr]    |
[INFO] [stderr] 30 | /     fn set(&mut self,
[INFO] [stderr] 31 | |            _value_iterated_to: i64,
[INFO] [stderr] 32 | |            _value_iterated_from: i64,
[INFO] [stderr] 33 | |            _count_at_value_iterated_to: i64,
[INFO] [stderr] ...  |
[INFO] [stderr] 46 | |         self.percentile_level_iterated_to = _percentile_level_iterated_to;
[INFO] [stderr] 47 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/iter.rs:192:1
[INFO] [stderr]     |
[INFO] [stderr] 192 | / pub fn new_all_values_iterator<'a>(_histogram: &'a Histogram) -> AllValuesIterator {
[INFO] [stderr] 193 | |     AllValuesIterator {
[INFO] [stderr] 194 | |         histogram: _histogram,
[INFO] [stderr] 195 | |         state: IteratorSharedState {
[INFO] [stderr] ...   |
[INFO] [stderr] 210 | |     }
[INFO] [stderr] 211 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/iter.rs:222:5
[INFO] [stderr]     |
[INFO] [stderr] 222 | /     pub fn next(&mut self) -> &HistogramIterationValue {
[INFO] [stderr] 223 | |         self.state.next(self.histogram, |iterator_state: &mut IteratorSharedState, _histogram: &Histogram| {
[INFO] [stderr] 224 | |                 iterator_state.visited_index != iterator_state.current_index
[INFO] [stderr] 225 | |         })
[INFO] [stderr] 226 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/iter.rs:235:1
[INFO] [stderr]     |
[INFO] [stderr] 235 | / pub fn new_iterator<'a>(_histogram: &'a Histogram) -> RecordedValuesIterator {
[INFO] [stderr] 236 | |     RecordedValuesIterator {
[INFO] [stderr] 237 | |         histogram: _histogram,
[INFO] [stderr] 238 | |         state: IteratorSharedState {
[INFO] [stderr] ...   |
[INFO] [stderr] 253 | |     }
[INFO] [stderr] 254 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/iter.rs:265:5
[INFO] [stderr]     |
[INFO] [stderr] 265 | /     pub fn next(&mut self) -> &HistogramIterationValue {
[INFO] [stderr] 266 | |         self.state.next(self.histogram, |iterator_state: &mut IteratorSharedState, histogram: &Histogram| {
[INFO] [stderr] 267 | |             let current_count = histogram.get_count_at_index(iterator_state.current_index);
[INFO] [stderr] 268 | |             (current_count != 0) && (iterator_state.visited_index != iterator_state.current_index)
[INFO] [stderr] 269 | |         })
[INFO] [stderr] 270 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/encoding.rs:16:24
[INFO] [stderr]    |
[INFO] [stderr] 16 | pub fn get_i32(buffer: &Vec<u8>, offset: i32) -> i32 {
[INFO] [stderr]    |                        ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/encoding.rs:18:11
[INFO] [stderr]    |
[INFO] [stderr] 18 |     let i0 = (buffer[offset] as i32) << 24;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(buffer[offset])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/encoding.rs:19:11
[INFO] [stderr]    |
[INFO] [stderr] 19 |     let i1 = (buffer[offset + 1] as i32) << 16;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(buffer[offset + 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/encoding.rs:20:11
[INFO] [stderr]    |
[INFO] [stderr] 20 |     let i2 = (buffer[offset + 2] as i32) << 8;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(buffer[offset + 2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/encoding.rs:21:11
[INFO] [stderr]    |
[INFO] [stderr] 21 |     let i3 = buffer[offset + 3] as i32;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(buffer[offset + 3])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/encoding.rs:37:24
[INFO] [stderr]    |
[INFO] [stderr] 37 | pub fn get_i64(buffer: &Vec<u8>, offset: i32) -> i64 {
[INFO] [stderr]    |                        ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/encoding.rs:39:11
[INFO] [stderr]    |
[INFO] [stderr] 39 |     let i0 = (buffer[offset] as i64) << 56;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/encoding.rs:40:11
[INFO] [stderr]    |
[INFO] [stderr] 40 |     let i1 = (buffer[offset + 1] as i64) << 48;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/encoding.rs:41:11
[INFO] [stderr]    |
[INFO] [stderr] 41 |     let i2 = (buffer[offset + 2] as i64) << 40;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/encoding.rs:42:11
[INFO] [stderr]    |
[INFO] [stderr] 42 |     let i3 = (buffer[offset + 3] as i64) << 32;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 3])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/encoding.rs:43:11
[INFO] [stderr]    |
[INFO] [stderr] 43 |     let i4 = (buffer[offset + 4] as i64) << 24;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 4])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/encoding.rs:44:11
[INFO] [stderr]    |
[INFO] [stderr] 44 |     let i5 = (buffer[offset + 5] as i64) << 16;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 5])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/encoding.rs:45:11
[INFO] [stderr]    |
[INFO] [stderr] 45 |     let i6 = (buffer[offset + 6] as i64) << 8;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 6])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/encoding.rs:46:11
[INFO] [stderr]    |
[INFO] [stderr] 46 |     let i7 = buffer[offset + 7] as i64;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 7])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/encoding.rs:105:23
[INFO] [stderr]     |
[INFO] [stderr] 105 | pub fn decode(buffer: &Vec<u8>, input_offset: i32) -> (i64, i32) {
[INFO] [stderr]     |                       ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/encoding.rs:107:22
[INFO] [stderr]     |
[INFO] [stderr] 107 |     let mut v: i64 = buffer[offset] as i64;
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/encoding.rs:111:13
[INFO] [stderr]     |
[INFO] [stderr] 111 |         v = buffer[offset + 1] as i64;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/encoding.rs:115:17
[INFO] [stderr]     |
[INFO] [stderr] 115 |             v = buffer[offset + 2] as i64;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 2])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/encoding.rs:119:21
[INFO] [stderr]     |
[INFO] [stderr] 119 |                 v = buffer[offset + 3] as i64;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 3])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/encoding.rs:123:25
[INFO] [stderr]     |
[INFO] [stderr] 123 |                     v = buffer[offset + 4] as i64;
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 4])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/encoding.rs:127:29
[INFO] [stderr]     |
[INFO] [stderr] 127 |                         v = buffer[offset + 5] as i64;
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 5])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/encoding.rs:131:33
[INFO] [stderr]     |
[INFO] [stderr] 131 |                             v = buffer[offset + 6] as i64;
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 6])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/encoding.rs:135:37
[INFO] [stderr]     |
[INFO] [stderr] 135 |                                 v = buffer[offset + 7] as i64;
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 7])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/encoding.rs:139:41
[INFO] [stderr]     |
[INFO] [stderr] 139 |                                     v = buffer[offset + 8] as i64;
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 8])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rustogram`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/histogram.rs:33:29
[INFO] [stderr]    |
[INFO] [stderr] 33 |     let _sub_bucket_mask = ((_sub_bucket_count as i64) - 1) << _unit_magnitude;
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(_sub_bucket_count)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/histogram.rs:66:42
[INFO] [stderr]    |
[INFO] [stderr] 66 | pub fn deserialise_histogram(byte_array: &Vec<u8>, offset: i32) -> Option<Histogram> {
[INFO] [stderr]    |                                          ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/histogram.rs:214:18
[INFO] [stderr]     |
[INFO] [stderr] 214 |         for i in 0..(target_index + 1) {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=target_index`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/histogram.rs:225:18
[INFO] [stderr]     |
[INFO] [stderr] 225 |         for i in low_index..(high_index + 1) {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `low_index..=high_index`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/histogram.rs:427:71
[INFO] [stderr]     |
[INFO] [stderr] 427 |     fn fill_counts_array_from_source_buffer(&mut self, source_buffer: &Vec<u8>, offset: i32, length_in_bytes: i32, word_size_in_bytes: i32) -> i32 {
[INFO] [stderr]     |                                                                       ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]    --> src/histogram.rs:444:11
[INFO] [stderr]     |
[INFO] [stderr] 444 |                 if zc > std::i64::MAX {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::absurd_extreme_comparisons)] on by default
[INFO] [stderr]     = help: because std::i64::MAX is the maximum value for this type, this comparison is always false
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/histogram.rs:494:10
[INFO] [stderr]     |
[INFO] [stderr] 494 |         (self.leading_zero_count_base as i64 -
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.leading_zero_count_base)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/histogram.rs:495:10
[INFO] [stderr]     |
[INFO] [stderr] 495 |          (value | self.sub_bucket_mask as i64).leading_zeros() as i64) as i32
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((value | self.sub_bucket_mask as i64).leading_zeros())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/histogram.rs:517:9
[INFO] [stderr]     |
[INFO] [stderr] 517 |         (sub_bucket_index as i64) << (bucket_index + self.unit_magnitude)
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(sub_bucket_index)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/histogram.rs:579:43
[INFO] [stderr]     |
[INFO] [stderr] 579 |     let mut smallest_untrackable_value = ((sub_bucket_count as i64) << unit_magnitude) as i64;
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(sub_bucket_count)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `iter::HistogramIterationValue`
[INFO] [stderr]   --> src/iter.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 | /     pub fn new() -> HistogramIterationValue {
[INFO] [stderr] 18 | |         HistogramIterationValue {
[INFO] [stderr] 19 | |             value_iterated_to: 0,
[INFO] [stderr] 20 | |             value_iterated_from: 0,
[INFO] [stderr] ...  |
[INFO] [stderr] 27 | |         }
[INFO] [stderr] 28 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 5  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (9/7)
[INFO] [stderr]   --> src/iter.rs:30:5
[INFO] [stderr]    |
[INFO] [stderr] 30 | /     fn set(&mut self,
[INFO] [stderr] 31 | |            _value_iterated_to: i64,
[INFO] [stderr] 32 | |            _value_iterated_from: i64,
[INFO] [stderr] 33 | |            _count_at_value_iterated_to: i64,
[INFO] [stderr] ...  |
[INFO] [stderr] 46 | |         self.percentile_level_iterated_to = _percentile_level_iterated_to;
[INFO] [stderr] 47 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/iter.rs:192:1
[INFO] [stderr]     |
[INFO] [stderr] 192 | / pub fn new_all_values_iterator<'a>(_histogram: &'a Histogram) -> AllValuesIterator {
[INFO] [stderr] 193 | |     AllValuesIterator {
[INFO] [stderr] 194 | |         histogram: _histogram,
[INFO] [stderr] 195 | |         state: IteratorSharedState {
[INFO] [stderr] ...   |
[INFO] [stderr] 210 | |     }
[INFO] [stderr] 211 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/iter.rs:222:5
[INFO] [stderr]     |
[INFO] [stderr] 222 | /     pub fn next(&mut self) -> &HistogramIterationValue {
[INFO] [stderr] 223 | |         self.state.next(self.histogram, |iterator_state: &mut IteratorSharedState, _histogram: &Histogram| {
[INFO] [stderr] 224 | |                 iterator_state.visited_index != iterator_state.current_index
[INFO] [stderr] 225 | |         })
[INFO] [stderr] 226 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/iter.rs:235:1
[INFO] [stderr]     |
[INFO] [stderr] 235 | / pub fn new_iterator<'a>(_histogram: &'a Histogram) -> RecordedValuesIterator {
[INFO] [stderr] 236 | |     RecordedValuesIterator {
[INFO] [stderr] 237 | |         histogram: _histogram,
[INFO] [stderr] 238 | |         state: IteratorSharedState {
[INFO] [stderr] ...   |
[INFO] [stderr] 253 | |     }
[INFO] [stderr] 254 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/iter.rs:265:5
[INFO] [stderr]     |
[INFO] [stderr] 265 | /     pub fn next(&mut self) -> &HistogramIterationValue {
[INFO] [stderr] 266 | |         self.state.next(self.histogram, |iterator_state: &mut IteratorSharedState, histogram: &Histogram| {
[INFO] [stderr] 267 | |             let current_count = histogram.get_count_at_index(iterator_state.current_index);
[INFO] [stderr] 268 | |             (current_count != 0) && (iterator_state.visited_index != iterator_state.current_index)
[INFO] [stderr] 269 | |         })
[INFO] [stderr] 270 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/encoding.rs:16:24
[INFO] [stderr]    |
[INFO] [stderr] 16 | pub fn get_i32(buffer: &Vec<u8>, offset: i32) -> i32 {
[INFO] [stderr]    |                        ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/encoding.rs:18:11
[INFO] [stderr]    |
[INFO] [stderr] 18 |     let i0 = (buffer[offset] as i32) << 24;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(buffer[offset])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/encoding.rs:19:11
[INFO] [stderr]    |
[INFO] [stderr] 19 |     let i1 = (buffer[offset + 1] as i32) << 16;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(buffer[offset + 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/encoding.rs:20:11
[INFO] [stderr]    |
[INFO] [stderr] 20 |     let i2 = (buffer[offset + 2] as i32) << 8;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(buffer[offset + 2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/encoding.rs:21:11
[INFO] [stderr]    |
[INFO] [stderr] 21 |     let i3 = buffer[offset + 3] as i32;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(buffer[offset + 3])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/encoding.rs:37:24
[INFO] [stderr]    |
[INFO] [stderr] 37 | pub fn get_i64(buffer: &Vec<u8>, offset: i32) -> i64 {
[INFO] [stderr]    |                        ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/encoding.rs:39:11
[INFO] [stderr]    |
[INFO] [stderr] 39 |     let i0 = (buffer[offset] as i64) << 56;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/encoding.rs:40:11
[INFO] [stderr]    |
[INFO] [stderr] 40 |     let i1 = (buffer[offset + 1] as i64) << 48;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/encoding.rs:41:11
[INFO] [stderr]    |
[INFO] [stderr] 41 |     let i2 = (buffer[offset + 2] as i64) << 40;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/encoding.rs:42:11
[INFO] [stderr]    |
[INFO] [stderr] 42 |     let i3 = (buffer[offset + 3] as i64) << 32;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 3])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/encoding.rs:43:11
[INFO] [stderr]    |
[INFO] [stderr] 43 |     let i4 = (buffer[offset + 4] as i64) << 24;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 4])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/encoding.rs:44:11
[INFO] [stderr]    |
[INFO] [stderr] 44 |     let i5 = (buffer[offset + 5] as i64) << 16;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 5])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/encoding.rs:45:11
[INFO] [stderr]    |
[INFO] [stderr] 45 |     let i6 = (buffer[offset + 6] as i64) << 8;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 6])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/encoding.rs:46:11
[INFO] [stderr]    |
[INFO] [stderr] 46 |     let i7 = buffer[offset + 7] as i64;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 7])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/encoding.rs:105:23
[INFO] [stderr]     |
[INFO] [stderr] 105 | pub fn decode(buffer: &Vec<u8>, input_offset: i32) -> (i64, i32) {
[INFO] [stderr]     |                       ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/encoding.rs:107:22
[INFO] [stderr]     |
[INFO] [stderr] 107 |     let mut v: i64 = buffer[offset] as i64;
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/encoding.rs:111:13
[INFO] [stderr]     |
[INFO] [stderr] 111 |         v = buffer[offset + 1] as i64;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/encoding.rs:115:17
[INFO] [stderr]     |
[INFO] [stderr] 115 |             v = buffer[offset + 2] as i64;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 2])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/encoding.rs:119:21
[INFO] [stderr]     |
[INFO] [stderr] 119 |                 v = buffer[offset + 3] as i64;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 3])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/encoding.rs:123:25
[INFO] [stderr]     |
[INFO] [stderr] 123 |                     v = buffer[offset + 4] as i64;
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 4])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/encoding.rs:127:29
[INFO] [stderr]     |
[INFO] [stderr] 127 |                         v = buffer[offset + 5] as i64;
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 5])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/encoding.rs:131:33
[INFO] [stderr]     |
[INFO] [stderr] 131 |                             v = buffer[offset + 6] as i64;
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 6])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/encoding.rs:135:37
[INFO] [stderr]     |
[INFO] [stderr] 135 |                                 v = buffer[offset + 7] as i64;
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 7])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/encoding.rs:139:41
[INFO] [stderr]     |
[INFO] [stderr] 139 |                                     v = buffer[offset + 8] as i64;
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(buffer[offset + 8])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rustogram`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "110ccaa9d8ca02fe69dc462db59738bb1b2fc003728f0471f95ff47b1da3198e"`
[INFO] running `"docker" "rm" "-f" "110ccaa9d8ca02fe69dc462db59738bb1b2fc003728f0471f95ff47b1da3198e"`
[INFO] [stdout] 110ccaa9d8ca02fe69dc462db59738bb1b2fc003728f0471f95ff47b1da3198e