[INFO] crate rust_combinatorics 0.1.0 is already in cache [INFO] extracting crate rust_combinatorics 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rust_combinatorics/0.1.0 [INFO] extracting crate rust_combinatorics 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust_combinatorics/0.1.0 [INFO] validating manifest of rust_combinatorics-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust_combinatorics-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust_combinatorics-0.1.0 [INFO] finished frobbing rust_combinatorics-0.1.0 [INFO] frobbed toml for rust_combinatorics-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rust_combinatorics/0.1.0/Cargo.toml [INFO] started frobbing rust_combinatorics-0.1.0 [INFO] finished frobbing rust_combinatorics-0.1.0 [INFO] frobbed toml for rust_combinatorics-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust_combinatorics/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust_combinatorics-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust_combinatorics/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6f0f5976f09311796b88db7356eafd6d353421e8c07624e2385ed93df451c203 [INFO] running `"docker" "start" "-a" "6f0f5976f09311796b88db7356eafd6d353421e8c07624e2385ed93df451c203"` [INFO] [stderr] Checking rust_combinatorics v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinatorics/binomial.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | list: list, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `list` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinatorics/binomial.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | k: k, [INFO] [stderr] | ^^^^ help: replace it with: `k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinatorics/binomial.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | list: list, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `list` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinatorics/binomial.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | k: k, [INFO] [stderr] | ^^^^ help: replace it with: `k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/combinatorics/binomial.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | fn from_indices(&self) -> Vec<&'t T> { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/combinatorics/binomial.rs:27:28 [INFO] [stderr] | [INFO] [stderr] 27 | let to_increment = (0..self.k) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 28 | | .rev() [INFO] [stderr] 29 | | .filter(|&i| { [INFO] [stderr] 30 | | let max_allowed = self.n() - self.k + i; [INFO] [stderr] 31 | | self.indices[i] < max_allowed [INFO] [stderr] 32 | | }) [INFO] [stderr] 33 | | .next(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/combinatorics/binomial.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | fn from_indices(&self) -> Vec<&'t T> { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/combinatorics/binomial.rs:27:28 [INFO] [stderr] | [INFO] [stderr] 27 | let to_increment = (0..self.k) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 28 | | .rev() [INFO] [stderr] 29 | | .filter(|&i| { [INFO] [stderr] 30 | | let max_allowed = self.n() - self.k + i; [INFO] [stderr] 31 | | self.indices[i] < max_allowed [INFO] [stderr] 32 | | }) [INFO] [stderr] 33 | | .next(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.57s [INFO] running `"docker" "inspect" "6f0f5976f09311796b88db7356eafd6d353421e8c07624e2385ed93df451c203"` [INFO] running `"docker" "rm" "-f" "6f0f5976f09311796b88db7356eafd6d353421e8c07624e2385ed93df451c203"` [INFO] [stdout] 6f0f5976f09311796b88db7356eafd6d353421e8c07624e2385ed93df451c203