[INFO] crate rust-embed-impl 4.2.0 is already in cache [INFO] extracting crate rust-embed-impl 4.2.0 into work/ex/clippy-test-run/sources/stable/reg/rust-embed-impl/4.2.0 [INFO] extracting crate rust-embed-impl 4.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-embed-impl/4.2.0 [INFO] validating manifest of rust-embed-impl-4.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust-embed-impl-4.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust-embed-impl-4.2.0 [INFO] finished frobbing rust-embed-impl-4.2.0 [INFO] frobbed toml for rust-embed-impl-4.2.0 written to work/ex/clippy-test-run/sources/stable/reg/rust-embed-impl/4.2.0/Cargo.toml [INFO] started frobbing rust-embed-impl-4.2.0 [INFO] finished frobbing rust-embed-impl-4.2.0 [INFO] frobbed toml for rust-embed-impl-4.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-embed-impl/4.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust-embed-impl-4.2.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-embed-impl/4.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3ea6e6e270d40bf8d87b904ac870bf61666745fbfe0a3e9f1f092bb796b0454a [INFO] running `"docker" "start" "-a" "3ea6e6e270d40bf8d87b904ac870bf61666745fbfe0a3e9f1f092bb796b0454a"` [INFO] [stderr] Checking rust-embed-impl v4.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:93:31 [INFO] [stderr] | [INFO] [stderr] 93 | Body::Struct(ref data) => match data { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 94 | | &VariantData::Struct(_) => help(), [INFO] [stderr] 95 | | _ => {} [INFO] [stderr] 96 | | }, [INFO] [stderr] | |_____^ help: try this: `if let &VariantData::Struct(_) = data { help() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:93:31 [INFO] [stderr] | [INFO] [stderr] 93 | Body::Struct(ref data) => match data { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 94 | | &VariantData::Struct(_) => help(), [INFO] [stderr] 95 | | _ => {} [INFO] [stderr] 96 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 93 | Body::Struct(ref data) => match *data { [INFO] [stderr] 94 | VariantData::Struct(_) => help(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:99:6 [INFO] [stderr] | [INFO] [stderr] 99 | if ast.attrs.len() == 0 || ast.attrs.len() > 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ast.attrs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:103:23 [INFO] [stderr] | [INFO] [stderr] 103 | let literal_value = match value { [INFO] [stderr] | _______________________^ [INFO] [stderr] 104 | | &MetaItem::NameValue(ref attr_name, ref value) => { [INFO] [stderr] 105 | | if attr_name == "folder" { [INFO] [stderr] 106 | | value [INFO] [stderr] ... | [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | }; [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 103 | let literal_value = match *value { [INFO] [stderr] 104 | MetaItem::NameValue(ref attr_name, ref value) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:115:21 [INFO] [stderr] | [INFO] [stderr] 115 | let folder_path = match literal_value { [INFO] [stderr] | _____________________^ [INFO] [stderr] 116 | | &Lit::Str(ref val, _) => val.clone(), [INFO] [stderr] 117 | | _ => { [INFO] [stderr] 118 | | panic!("#[derive(RustEmbed)] attribute value must be a string literal"); [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | }; [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 115 | let folder_path = match *literal_value { [INFO] [stderr] 116 | Lit::Str(ref val, _) => val.clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:93:31 [INFO] [stderr] | [INFO] [stderr] 93 | Body::Struct(ref data) => match data { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 94 | | &VariantData::Struct(_) => help(), [INFO] [stderr] 95 | | _ => {} [INFO] [stderr] 96 | | }, [INFO] [stderr] | |_____^ help: try this: `if let &VariantData::Struct(_) = data { help() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:93:31 [INFO] [stderr] | [INFO] [stderr] 93 | Body::Struct(ref data) => match data { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 94 | | &VariantData::Struct(_) => help(), [INFO] [stderr] 95 | | _ => {} [INFO] [stderr] 96 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 93 | Body::Struct(ref data) => match *data { [INFO] [stderr] 94 | VariantData::Struct(_) => help(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:99:6 [INFO] [stderr] | [INFO] [stderr] 99 | if ast.attrs.len() == 0 || ast.attrs.len() > 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ast.attrs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:103:23 [INFO] [stderr] | [INFO] [stderr] 103 | let literal_value = match value { [INFO] [stderr] | _______________________^ [INFO] [stderr] 104 | | &MetaItem::NameValue(ref attr_name, ref value) => { [INFO] [stderr] 105 | | if attr_name == "folder" { [INFO] [stderr] 106 | | value [INFO] [stderr] ... | [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | }; [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 103 | let literal_value = match *value { [INFO] [stderr] 104 | MetaItem::NameValue(ref attr_name, ref value) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:115:21 [INFO] [stderr] | [INFO] [stderr] 115 | let folder_path = match literal_value { [INFO] [stderr] | _____________________^ [INFO] [stderr] 116 | | &Lit::Str(ref val, _) => val.clone(), [INFO] [stderr] 117 | | _ => { [INFO] [stderr] 118 | | panic!("#[derive(RustEmbed)] attribute value must be a string literal"); [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | }; [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 115 | let folder_path = match *literal_value { [INFO] [stderr] 116 | Lit::Str(ref val, _) => val.clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.97s [INFO] running `"docker" "inspect" "3ea6e6e270d40bf8d87b904ac870bf61666745fbfe0a3e9f1f092bb796b0454a"` [INFO] running `"docker" "rm" "-f" "3ea6e6e270d40bf8d87b904ac870bf61666745fbfe0a3e9f1f092bb796b0454a"` [INFO] [stdout] 3ea6e6e270d40bf8d87b904ac870bf61666745fbfe0a3e9f1f092bb796b0454a