[INFO] crate rust-bmfont 0.1.4 is already in cache [INFO] extracting crate rust-bmfont 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/rust-bmfont/0.1.4 [INFO] extracting crate rust-bmfont 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-bmfont/0.1.4 [INFO] validating manifest of rust-bmfont-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust-bmfont-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust-bmfont-0.1.4 [INFO] finished frobbing rust-bmfont-0.1.4 [INFO] frobbed toml for rust-bmfont-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/rust-bmfont/0.1.4/Cargo.toml [INFO] started frobbing rust-bmfont-0.1.4 [INFO] finished frobbing rust-bmfont-0.1.4 [INFO] frobbed toml for rust-bmfont-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-bmfont/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust-bmfont-0.1.4 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rust-bmfont/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8cb1658aa3ede5abd2e40f2a9daeb0e51a6667b019ba18987eb436ae61f5e0c9 [INFO] running `"docker" "start" "-a" "8cb1658aa3ede5abd2e40f2a9daeb0e51a6667b019ba18987eb436ae61f5e0c9"` [INFO] [stderr] Checking rust-bmfont v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:152:14 [INFO] [stderr] | [INFO] [stderr] 152 | BmFont { pages: pages, chars: chars } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `pages` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:152:28 [INFO] [stderr] | [INFO] [stderr] 152 | BmFont { pages: pages, chars: chars } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:152:14 [INFO] [stderr] | [INFO] [stderr] 152 | BmFont { pages: pages, chars: chars } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `pages` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:152:28 [INFO] [stderr] | [INFO] [stderr] 152 | BmFont { pages: pages, chars: chars } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `BmChar` [INFO] [stderr] --> src/lib.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> Self { [INFO] [stderr] 25 | | BmChar { [INFO] [stderr] 26 | | id: 0, [INFO] [stderr] 27 | | page: 0, [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `BmPage` [INFO] [stderr] --> src/lib.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn new() -> Self { [INFO] [stderr] 48 | | BmPage { [INFO] [stderr] 49 | | id: 0, [INFO] [stderr] 50 | | file: PathBuf::new() [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | / match &name.local_name.as_ref() { [INFO] [stderr] 98 | | &"char" => { [INFO] [stderr] 99 | | let mut chr: BmChar = BmChar::new(); [INFO] [stderr] 100 | | [INFO] [stderr] ... | [INFO] [stderr] 139 | | _ => { } [INFO] [stderr] 140 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 97 | match name.local_name.as_ref() { [INFO] [stderr] 98 | "char" => { [INFO] [stderr] 99 | let mut chr: BmChar = BmChar::new(); [INFO] [stderr] 100 | [INFO] [stderr] 101 | for attr in attributes { [INFO] [stderr] 102 | let name = attr.name.local_name; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:105:29 [INFO] [stderr] | [INFO] [stderr] 105 | / match &name.as_ref() { [INFO] [stderr] 106 | | &"id" => chr.id = value.parse::().unwrap(), [INFO] [stderr] 107 | | &"page" => chr.page = value.parse::().unwrap(), [INFO] [stderr] 108 | | &"x" => chr.x = value.parse::().unwrap(), [INFO] [stderr] ... | [INFO] [stderr] 116 | | _ => {} [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 105 | match name.as_ref() { [INFO] [stderr] 106 | "id" => chr.id = value.parse::().unwrap(), [INFO] [stderr] 107 | "page" => chr.page = value.parse::().unwrap(), [INFO] [stderr] 108 | "x" => chr.x = value.parse::().unwrap(), [INFO] [stderr] 109 | "y" => chr.y = value.parse::().unwrap(), [INFO] [stderr] 110 | "xoffset" => chr.xoffset = value.parse::().unwrap(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:127:29 [INFO] [stderr] | [INFO] [stderr] 127 | / match &name.as_ref() { [INFO] [stderr] 128 | | &"id" => page.id = value.parse::().unwrap(), [INFO] [stderr] 129 | | &"file" => { [INFO] [stderr] 130 | | page.file = fontdescriptorpath.with_file_name(value); [INFO] [stderr] 131 | | }, [INFO] [stderr] 132 | | _ => {} [INFO] [stderr] 133 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 127 | match name.as_ref() { [INFO] [stderr] 128 | "id" => page.id = value.parse::().unwrap(), [INFO] [stderr] 129 | "file" => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `BmChar` [INFO] [stderr] --> src/lib.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> Self { [INFO] [stderr] 25 | | BmChar { [INFO] [stderr] 26 | | id: 0, [INFO] [stderr] 27 | | page: 0, [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `BmPage` [INFO] [stderr] --> src/lib.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn new() -> Self { [INFO] [stderr] 48 | | BmPage { [INFO] [stderr] 49 | | id: 0, [INFO] [stderr] 50 | | file: PathBuf::new() [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | / match &name.local_name.as_ref() { [INFO] [stderr] 98 | | &"char" => { [INFO] [stderr] 99 | | let mut chr: BmChar = BmChar::new(); [INFO] [stderr] 100 | | [INFO] [stderr] ... | [INFO] [stderr] 139 | | _ => { } [INFO] [stderr] 140 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 97 | match name.local_name.as_ref() { [INFO] [stderr] 98 | "char" => { [INFO] [stderr] 99 | let mut chr: BmChar = BmChar::new(); [INFO] [stderr] 100 | [INFO] [stderr] 101 | for attr in attributes { [INFO] [stderr] 102 | let name = attr.name.local_name; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:105:29 [INFO] [stderr] | [INFO] [stderr] 105 | / match &name.as_ref() { [INFO] [stderr] 106 | | &"id" => chr.id = value.parse::().unwrap(), [INFO] [stderr] 107 | | &"page" => chr.page = value.parse::().unwrap(), [INFO] [stderr] 108 | | &"x" => chr.x = value.parse::().unwrap(), [INFO] [stderr] ... | [INFO] [stderr] 116 | | _ => {} [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 105 | match name.as_ref() { [INFO] [stderr] 106 | "id" => chr.id = value.parse::().unwrap(), [INFO] [stderr] 107 | "page" => chr.page = value.parse::().unwrap(), [INFO] [stderr] 108 | "x" => chr.x = value.parse::().unwrap(), [INFO] [stderr] 109 | "y" => chr.y = value.parse::().unwrap(), [INFO] [stderr] 110 | "xoffset" => chr.xoffset = value.parse::().unwrap(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:127:29 [INFO] [stderr] | [INFO] [stderr] 127 | / match &name.as_ref() { [INFO] [stderr] 128 | | &"id" => page.id = value.parse::().unwrap(), [INFO] [stderr] 129 | | &"file" => { [INFO] [stderr] 130 | | page.file = fontdescriptorpath.with_file_name(value); [INFO] [stderr] 131 | | }, [INFO] [stderr] 132 | | _ => {} [INFO] [stderr] 133 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 127 | match name.as_ref() { [INFO] [stderr] 128 | "id" => page.id = value.parse::().unwrap(), [INFO] [stderr] 129 | "file" => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> examples/parse.rs:9:31 [INFO] [stderr] | [INFO] [stderr] 9 | let assetspath: PathBuf = PathBuf::from(cwd).join(Path::new("examples/assets")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `cwd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.73s [INFO] running `"docker" "inspect" "8cb1658aa3ede5abd2e40f2a9daeb0e51a6667b019ba18987eb436ae61f5e0c9"` [INFO] running `"docker" "rm" "-f" "8cb1658aa3ede5abd2e40f2a9daeb0e51a6667b019ba18987eb436ae61f5e0c9"` [INFO] [stdout] 8cb1658aa3ede5abd2e40f2a9daeb0e51a6667b019ba18987eb436ae61f5e0c9