[INFO] crate rtti-derive 0.4.0 is already in cache [INFO] extracting crate rtti-derive 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/rtti-derive/0.4.0 [INFO] extracting crate rtti-derive 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rtti-derive/0.4.0 [INFO] validating manifest of rtti-derive-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rtti-derive-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rtti-derive-0.4.0 [INFO] finished frobbing rtti-derive-0.4.0 [INFO] frobbed toml for rtti-derive-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/rtti-derive/0.4.0/Cargo.toml [INFO] started frobbing rtti-derive-0.4.0 [INFO] finished frobbing rtti-derive-0.4.0 [INFO] frobbed toml for rtti-derive-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rtti-derive/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rtti-derive-0.4.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rtti-derive/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f48338063e98a89e3e8375efc81d8499f79975ec7d35d91c186a68cc87f391a0 [INFO] running `"docker" "start" "-a" "f48338063e98a89e3e8375efc81d8499f79975ec7d35d91c186a68cc87f391a0"` [INFO] [stderr] Checking rtti-derive v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:93:63 [INFO] [stderr] | [INFO] [stderr] 93 | let indices: Vec<_> = (0..visibilities.len()).map(|x| syn::Index::from(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `syn::Index::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:231:5 [INFO] [stderr] | [INFO] [stderr] 231 | / match vis { [INFO] [stderr] 232 | | &syn::Visibility::Public(_) => syn::Ident::from("Public"), [INFO] [stderr] 233 | | &syn::Visibility::Crate(_) => syn::Ident::from("Crate"), [INFO] [stderr] 234 | | &syn::Visibility::Restricted(_) => syn::Ident::from("Restricted"), [INFO] [stderr] 235 | | &syn::Visibility::Inherited => syn::Ident::from("Inherited"), [INFO] [stderr] 236 | | _ => syn::Ident::from("Unknown"), [INFO] [stderr] 237 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 231 | match *vis { [INFO] [stderr] 232 | syn::Visibility::Public(_) => syn::Ident::from("Public"), [INFO] [stderr] 233 | syn::Visibility::Crate(_) => syn::Ident::from("Crate"), [INFO] [stderr] 234 | syn::Visibility::Restricted(_) => syn::Ident::from("Restricted"), [INFO] [stderr] 235 | syn::Visibility::Inherited => syn::Ident::from("Inherited"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:240:27 [INFO] [stderr] | [INFO] [stderr] 240 | fn parse_attr_hint(attrs: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[syn::Attribute]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:258:29 [INFO] [stderr] | [INFO] [stderr] 258 | fn parse_attr_ignore(attrs: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[syn::Attribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:93:63 [INFO] [stderr] | [INFO] [stderr] 93 | let indices: Vec<_> = (0..visibilities.len()).map(|x| syn::Index::from(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `syn::Index::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:231:5 [INFO] [stderr] | [INFO] [stderr] 231 | / match vis { [INFO] [stderr] 232 | | &syn::Visibility::Public(_) => syn::Ident::from("Public"), [INFO] [stderr] 233 | | &syn::Visibility::Crate(_) => syn::Ident::from("Crate"), [INFO] [stderr] 234 | | &syn::Visibility::Restricted(_) => syn::Ident::from("Restricted"), [INFO] [stderr] 235 | | &syn::Visibility::Inherited => syn::Ident::from("Inherited"), [INFO] [stderr] 236 | | _ => syn::Ident::from("Unknown"), [INFO] [stderr] 237 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 231 | match *vis { [INFO] [stderr] 232 | syn::Visibility::Public(_) => syn::Ident::from("Public"), [INFO] [stderr] 233 | syn::Visibility::Crate(_) => syn::Ident::from("Crate"), [INFO] [stderr] 234 | syn::Visibility::Restricted(_) => syn::Ident::from("Restricted"), [INFO] [stderr] 235 | syn::Visibility::Inherited => syn::Ident::from("Inherited"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:240:27 [INFO] [stderr] | [INFO] [stderr] 240 | fn parse_attr_hint(attrs: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[syn::Attribute]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:258:29 [INFO] [stderr] | [INFO] [stderr] 258 | fn parse_attr_ignore(attrs: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[syn::Attribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.35s [INFO] running `"docker" "inspect" "f48338063e98a89e3e8375efc81d8499f79975ec7d35d91c186a68cc87f391a0"` [INFO] running `"docker" "rm" "-f" "f48338063e98a89e3e8375efc81d8499f79975ec7d35d91c186a68cc87f391a0"` [INFO] [stdout] f48338063e98a89e3e8375efc81d8499f79975ec7d35d91c186a68cc87f391a0