[INFO] crate rslogic 0.1.0 is already in cache [INFO] extracting crate rslogic 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rslogic/0.1.0 [INFO] extracting crate rslogic 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rslogic/0.1.0 [INFO] validating manifest of rslogic-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rslogic-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rslogic-0.1.0 [INFO] finished frobbing rslogic-0.1.0 [INFO] frobbed toml for rslogic-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rslogic/0.1.0/Cargo.toml [INFO] started frobbing rslogic-0.1.0 [INFO] finished frobbing rslogic-0.1.0 [INFO] frobbed toml for rslogic-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rslogic/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rslogic-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rslogic/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b12fabc614cdb4709af04e10a397579777255006ca2dbf0f37e1ab2d576d9f63 [INFO] running `"docker" "start" "-a" "b12fabc614cdb4709af04e10a397579777255006ca2dbf0f37e1ab2d576d9f63"` [INFO] [stderr] Checking rslogic v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/btmap.rs:76:29 [INFO] [stderr] | [INFO] [stderr] 76 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/btmap.rs:85:29 [INFO] [stderr] | [INFO] [stderr] 85 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/btmap.rs:97:25 [INFO] [stderr] | [INFO] [stderr] 97 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/goal.rs:46:27 [INFO] [stderr] | [INFO] [stderr] 46 | UnifyVal { var: *var, val: val } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/goal.rs:91:19 [INFO] [stderr] | [INFO] [stderr] 91 | Conjunction { a: a, b: b, _m: PhantomData } [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/goal.rs:91:25 [INFO] [stderr] | [INFO] [stderr] 91 | Conjunction { a: a, b: b, _m: PhantomData } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/goal.rs:123:19 [INFO] [stderr] | [INFO] [stderr] 123 | Disjunction { a: a, b: b, _m: PhantomData } [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/goal.rs:123:25 [INFO] [stderr] | [INFO] [stderr] 123 | Disjunction { a: a, b: b, _m: PhantomData } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/goal.rs:146:17 [INFO] [stderr] | [INFO] [stderr] 146 | Predicate { f: f, _m: PhantomData } [INFO] [stderr] | ^^^^ help: replace it with: `f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/btmap.rs:76:29 [INFO] [stderr] | [INFO] [stderr] 76 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/btmap.rs:85:29 [INFO] [stderr] | [INFO] [stderr] 85 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/btmap.rs:97:25 [INFO] [stderr] | [INFO] [stderr] 97 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/goal.rs:46:27 [INFO] [stderr] | [INFO] [stderr] 46 | UnifyVal { var: *var, val: val } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/goal.rs:91:19 [INFO] [stderr] | [INFO] [stderr] 91 | Conjunction { a: a, b: b, _m: PhantomData } [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/goal.rs:91:25 [INFO] [stderr] | [INFO] [stderr] 91 | Conjunction { a: a, b: b, _m: PhantomData } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/goal.rs:123:19 [INFO] [stderr] | [INFO] [stderr] 123 | Disjunction { a: a, b: b, _m: PhantomData } [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/goal.rs:123:25 [INFO] [stderr] | [INFO] [stderr] 123 | Disjunction { a: a, b: b, _m: PhantomData } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/goal.rs:146:17 [INFO] [stderr] | [INFO] [stderr] 146 | Predicate { f: f, _m: PhantomData } [INFO] [stderr] | ^^^^ help: replace it with: `f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/goal.rs:45:26 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn unify_val(var: &Var, val: T) -> UnifyVal where T: PartialEq + Unif { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Var` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/goal.rs:64:26 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn unify_vars(v1: &Var, v2: &Var) -> UnifyVar where T: PartialEq + Unif { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Var` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/goal.rs:64:36 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn unify_vars(v1: &Var, v2: &Var) -> UnifyVar where T: PartialEq + Unif { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Var` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/goal.rs:145:1 [INFO] [stderr] | [INFO] [stderr] 145 | / pub fn pred<'a, T, F>(f: &'a F) -> Predicate<'a, T, F> where T: PartialEq + Unif, F: Fn(&State) -> bool { [INFO] [stderr] 146 | | Predicate { f: f, _m: PhantomData } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/goal.rs:45:26 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn unify_val(var: &Var, val: T) -> UnifyVal where T: PartialEq + Unif { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Var` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/goal.rs:64:26 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn unify_vars(v1: &Var, v2: &Var) -> UnifyVar where T: PartialEq + Unif { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Var` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/goal.rs:64:36 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn unify_vars(v1: &Var, v2: &Var) -> UnifyVar where T: PartialEq + Unif { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Var` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/goal.rs:145:1 [INFO] [stderr] | [INFO] [stderr] 145 | / pub fn pred<'a, T, F>(f: &'a F) -> Predicate<'a, T, F> where T: PartialEq + Unif, F: Fn(&State) -> bool { [INFO] [stderr] 146 | | Predicate { f: f, _m: PhantomData } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/state.rs:49:34 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn binds_var(&self, var: &Var) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Var` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/state.rs:58:35 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn get<'a>(&'a self, var: &Var) -> Option<&'a T> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Var` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/state.rs:68:34 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn unify_val(&self, var: &Var, val: T) -> PossibleStates { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Var` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/state.rs:99:33 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn unify_var(&self, v1: &Var, v2: &Var) -> PossibleStates { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Var` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/state.rs:99:43 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn unify_var(&self, v1: &Var, v2: &Var) -> PossibleStates { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Var` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/state.rs:49:34 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn binds_var(&self, var: &Var) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Var` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/state.rs:58:35 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn get<'a>(&'a self, var: &Var) -> Option<&'a T> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Var` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/state.rs:68:34 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn unify_val(&self, var: &Var, val: T) -> PossibleStates { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Var` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/state.rs:99:33 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn unify_var(&self, v1: &Var, v2: &Var) -> PossibleStates { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Var` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/state.rs:99:43 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn unify_var(&self, v1: &Var, v2: &Var) -> PossibleStates { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Var` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.71s [INFO] running `"docker" "inspect" "b12fabc614cdb4709af04e10a397579777255006ca2dbf0f37e1ab2d576d9f63"` [INFO] running `"docker" "rm" "-f" "b12fabc614cdb4709af04e10a397579777255006ca2dbf0f37e1ab2d576d9f63"` [INFO] [stdout] b12fabc614cdb4709af04e10a397579777255006ca2dbf0f37e1ab2d576d9f63