[INFO] crate rs_algo 0.1.7 is already in cache [INFO] extracting crate rs_algo 0.1.7 into work/ex/clippy-test-run/sources/stable/reg/rs_algo/0.1.7 [INFO] extracting crate rs_algo 0.1.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rs_algo/0.1.7 [INFO] validating manifest of rs_algo-0.1.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rs_algo-0.1.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rs_algo-0.1.7 [INFO] finished frobbing rs_algo-0.1.7 [INFO] frobbed toml for rs_algo-0.1.7 written to work/ex/clippy-test-run/sources/stable/reg/rs_algo/0.1.7/Cargo.toml [INFO] started frobbing rs_algo-0.1.7 [INFO] finished frobbing rs_algo-0.1.7 [INFO] frobbed toml for rs_algo-0.1.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rs_algo/0.1.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rs_algo-0.1.7 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rs_algo/0.1.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2812862123b21ccc87118ca6f2a0a5c23c9dfe76a38c8740147169864ab32fa4 [INFO] running `"docker" "start" "-a" "2812862123b21ccc87118ca6f2a0a5c23c9dfe76a38c8740147169864ab32fa4"` [INFO] [stderr] Checking rs_algo v0.1.7 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/compare/subsequence.rs:94:14 [INFO] [stderr] | [INFO] [stderr] 94 | } else { [INFO] [stderr] | ______________^ [INFO] [stderr] 95 | | if self.grid[i - 1][j] >= self.grid[i][j - 1] { [INFO] [stderr] 96 | | i -= 1; [INFO] [stderr] 97 | | } else { [INFO] [stderr] 98 | | j -= 1; [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 94 | } else if self.grid[i - 1][j] >= self.grid[i][j - 1] { [INFO] [stderr] 95 | i -= 1; [INFO] [stderr] 96 | } else { [INFO] [stderr] 97 | j -= 1; [INFO] [stderr] 98 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | return (a, b); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `(a, b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math/mod.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | return (b, a); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `(b, a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math/mod.rs:56:3 [INFO] [stderr] | [INFO] [stderr] 56 | return gcd(a, b) == Ok(1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `gcd(a, b) == Ok(1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/compare/subsequence.rs:94:14 [INFO] [stderr] | [INFO] [stderr] 94 | } else { [INFO] [stderr] | ______________^ [INFO] [stderr] 95 | | if self.grid[i - 1][j] >= self.grid[i][j - 1] { [INFO] [stderr] 96 | | i -= 1; [INFO] [stderr] 97 | | } else { [INFO] [stderr] 98 | | j -= 1; [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 94 | } else if self.grid[i - 1][j] >= self.grid[i][j - 1] { [INFO] [stderr] 95 | i -= 1; [INFO] [stderr] 96 | } else { [INFO] [stderr] 97 | j -= 1; [INFO] [stderr] 98 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | return (a, b); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `(a, b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math/mod.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | return (b, a); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `(b, a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math/mod.rs:56:3 [INFO] [stderr] | [INFO] [stderr] 56 | return gcd(a, b) == Ok(1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `gcd(a, b) == Ok(1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math/mod.rs:106:27 [INFO] [stderr] | [INFO] [stderr] 106 | assert_eq!(Ok(2), gcd(22123322, 4223234)); [INFO] [stderr] | ^^^^^^^^ help: consider: `22_123_322` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math/mod.rs:106:37 [INFO] [stderr] | [INFO] [stderr] 106 | assert_eq!(Ok(2), gcd(22123322, 4223234)); [INFO] [stderr] | ^^^^^^^ help: consider: `4_223_234` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sort/merge.rs:4:19 [INFO] [stderr] | [INFO] [stderr] 4 | fn merge(left: &Vec, right: &Vec, array: &mut Vec) [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sort/merge.rs:4:36 [INFO] [stderr] | [INFO] [stderr] 4 | fn merge(left: &Vec, right: &Vec, array: &mut Vec) [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `array`. [INFO] [stderr] --> src/sort/merge.rs:46:14 [INFO] [stderr] | [INFO] [stderr] 46 | for i in 0..mid { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 46 | for in array.iter().take(mid) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `array`. [INFO] [stderr] --> src/sort/merge.rs:49:14 [INFO] [stderr] | [INFO] [stderr] 49 | for i in mid..len { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 49 | for in array.iter().take(len).skip(mid) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `array` manually [INFO] [stderr] --> src/sort/quick.rs:7:3 [INFO] [stderr] | [INFO] [stderr] 7 | / let temp = array[j]; [INFO] [stderr] 8 | | array[j] = array[k]; [INFO] [stderr] 9 | | array[k] = temp; [INFO] [stderr] | |_________________^ help: try: `array.swap(j, k)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `array` manually [INFO] [stderr] --> src/sort/bubble.rs:7:3 [INFO] [stderr] | [INFO] [stderr] 7 | / let temp = array[i]; [INFO] [stderr] 8 | | array[i] = array[j]; [INFO] [stderr] 9 | | array[j] = temp; [INFO] [stderr] | |_________________^ help: try: `array.swap(i, j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/compare/subsequence.rs:60:14 [INFO] [stderr] | [INFO] [stderr] 60 | for i in 1..left_len + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `1..=left_len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/compare/subsequence.rs:61:16 [INFO] [stderr] | [INFO] [stderr] 61 | for j in 1..right_len + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `1..=right_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/compare/substring.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | for i in 1..left_len + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `1..=left_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/compare/substring.rs:63:16 [INFO] [stderr] | [INFO] [stderr] 63 | for j in 1..right_len + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `1..=right_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/search/binary.rs:18:38 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn index_of(target: T, array: &Vec) -> Option [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/search/binary.rs:60:36 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn search(target: T, array: &Vec) -> Option [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/math/mod.rs:79:12 [INFO] [stderr] | [INFO] [stderr] 79 | for i in 2..limit + 1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `2..=limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sort/merge.rs:4:19 [INFO] [stderr] | [INFO] [stderr] 4 | fn merge(left: &Vec, right: &Vec, array: &mut Vec) [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sort/merge.rs:4:36 [INFO] [stderr] | [INFO] [stderr] 4 | fn merge(left: &Vec, right: &Vec, array: &mut Vec) [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `array`. [INFO] [stderr] --> src/sort/merge.rs:46:14 [INFO] [stderr] | [INFO] [stderr] 46 | for i in 0..mid { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 46 | for in array.iter().take(mid) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `array`. [INFO] [stderr] --> src/sort/merge.rs:49:14 [INFO] [stderr] | [INFO] [stderr] 49 | for i in mid..len { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 49 | for in array.iter().take(len).skip(mid) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `array` manually [INFO] [stderr] --> src/sort/quick.rs:7:3 [INFO] [stderr] | [INFO] [stderr] 7 | / let temp = array[j]; [INFO] [stderr] 8 | | array[j] = array[k]; [INFO] [stderr] 9 | | array[k] = temp; [INFO] [stderr] | |_________________^ help: try: `array.swap(j, k)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `array` manually [INFO] [stderr] --> src/sort/bubble.rs:7:3 [INFO] [stderr] | [INFO] [stderr] 7 | / let temp = array[i]; [INFO] [stderr] 8 | | array[i] = array[j]; [INFO] [stderr] 9 | | array[j] = temp; [INFO] [stderr] | |_________________^ help: try: `array.swap(i, j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/compare/subsequence.rs:60:14 [INFO] [stderr] | [INFO] [stderr] 60 | for i in 1..left_len + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `1..=left_len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/compare/subsequence.rs:61:16 [INFO] [stderr] | [INFO] [stderr] 61 | for j in 1..right_len + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `1..=right_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/compare/substring.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | for i in 1..left_len + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `1..=left_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/compare/substring.rs:63:16 [INFO] [stderr] | [INFO] [stderr] 63 | for j in 1..right_len + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `1..=right_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/search/binary.rs:18:38 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn index_of(target: T, array: &Vec) -> Option [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/search/binary.rs:60:36 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn search(target: T, array: &Vec) -> Option [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/math/mod.rs:79:12 [INFO] [stderr] | [INFO] [stderr] 79 | for i in 2..limit + 1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `2..=limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.59s [INFO] running `"docker" "inspect" "2812862123b21ccc87118ca6f2a0a5c23c9dfe76a38c8740147169864ab32fa4"` [INFO] running `"docker" "rm" "-f" "2812862123b21ccc87118ca6f2a0a5c23c9dfe76a38c8740147169864ab32fa4"` [INFO] [stdout] 2812862123b21ccc87118ca6f2a0a5c23c9dfe76a38c8740147169864ab32fa4