[INFO] crate route-recognizer 0.1.12 is already in cache [INFO] extracting crate route-recognizer 0.1.12 into work/ex/clippy-test-run/sources/stable/reg/route-recognizer/0.1.12 [INFO] extracting crate route-recognizer 0.1.12 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/route-recognizer/0.1.12 [INFO] validating manifest of route-recognizer-0.1.12 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of route-recognizer-0.1.12 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing route-recognizer-0.1.12 [INFO] finished frobbing route-recognizer-0.1.12 [INFO] frobbed toml for route-recognizer-0.1.12 written to work/ex/clippy-test-run/sources/stable/reg/route-recognizer/0.1.12/Cargo.toml [INFO] started frobbing route-recognizer-0.1.12 [INFO] finished frobbing route-recognizer-0.1.12 [INFO] frobbed toml for route-recognizer-0.1.12 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/route-recognizer/0.1.12/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting route-recognizer-0.1.12 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/route-recognizer/0.1.12:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] adec46aff4d5d4348e21c2488bc9e524ca229673e48c5f8193ae06d344ac217b [INFO] running `"docker" "start" "-a" "adec46aff4d5d4348e21c2488bc9e524ca229673e48c5f8193ae06d344ac217b"` [INFO] [stderr] Checking route-recognizer v0.1.12 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nfa.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nfa.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | chars: chars, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nfa.rs:192:16 [INFO] [stderr] | [INFO] [stderr] 192 | Match{ state: state, captures: captures } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nfa.rs:192:30 [INFO] [stderr] | [INFO] [stderr] 192 | Match{ state: state, captures: captures } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `captures` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:126:16 [INFO] [stderr] | [INFO] [stderr] 126 | Match{ handler: handler, params: params } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:126:34 [INFO] [stderr] | [INFO] [stderr] 126 | Match{ handler: handler, params: params } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nfa.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nfa.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | chars: chars, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nfa.rs:192:16 [INFO] [stderr] | [INFO] [stderr] 192 | Match{ state: state, captures: captures } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nfa.rs:192:30 [INFO] [stderr] | [INFO] [stderr] 192 | Match{ state: state, captures: captures } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `captures` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:126:16 [INFO] [stderr] | [INFO] [stderr] 126 | Match{ handler: handler, params: params } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:126:34 [INFO] [stderr] | [INFO] [stderr] 126 | Match{ handler: handler, params: params } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/nfa.rs:26:23 [INFO] [stderr] | [INFO] [stderr] 26 | let bit = 1 << val - 64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1 << (val - 64)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/nfa.rs:40:23 [INFO] [stderr] | [INFO] [stderr] 40 | let bit = 1 << val - 64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1 << (val - 64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/nfa.rs:75:19 [INFO] [stderr] | [INFO] [stderr] 75 | Ascii(1 << val - 64, 0, false) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1 << (val - 64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/nfa.rs:87:31 [INFO] [stderr] | [INFO] [stderr] 87 | Ascii(u64::MAX ^ (1 << val - 64), u64::MAX, true) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1 << (val - 64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> src/lib.rs:1:19 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(test, feature(test))] [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `route-recognizer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `nfa::CharSet` [INFO] [stderr] --> src/nfa.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> CharSet { [INFO] [stderr] 17 | | CharSet{ low_mask: 0, high_mask: 0, non_ascii: HashSet::new() } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/nfa.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | self.high_mask = self.high_mask | bit; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.high_mask |= bit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/nfa.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | self.low_mask = self.low_mask | bit; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.low_mask |= bit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `nfa::NFA` [INFO] [stderr] --> src/nfa.rs:205:5 [INFO] [stderr] | [INFO] [stderr] 205 | / pub fn new() -> NFA { [INFO] [stderr] 206 | | let root = State::new(0, CharacterClass::any()); [INFO] [stderr] 207 | | NFA { [INFO] [stderr] 208 | | states: vec![root], [INFO] [stderr] ... | [INFO] [stderr] 212 | | } [INFO] [stderr] 213 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 197 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/nfa.rs:259:21 [INFO] [stderr] | [INFO] [stderr] 259 | fn process_char<'a>(&self, threads: Vec, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Params` [INFO] [stderr] --> src/lib.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | / pub fn new() -> Params { [INFO] [stderr] 69 | | Params{ map: BTreeMap::new() } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 63 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / pub fn iter<'a>(&'a self) -> Iter<'a> { [INFO] [stderr] 81 | | Iter(self.map.iter()) [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Router` [INFO] [stderr] --> src/lib.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | / pub fn new() -> Router { [INFO] [stderr] 138 | | Router{ nfa: NFA::new(), handlers: BTreeMap::new() } [INFO] [stderr] 139 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 136 | impl Default for Router { [INFO] [stderr] 137 | fn default() -> Self { [INFO] [stderr] 138 | Self::new() [INFO] [stderr] 139 | } [INFO] [stderr] 140 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:142:12 [INFO] [stderr] | [INFO] [stderr] 142 | if route.len() != 0 && route.as_bytes()[0] == b'/' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!route.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:153:16 [INFO] [stderr] | [INFO] [stderr] 153 | if segment.len() > 0 && segment.as_bytes()[0] == b':' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!segment.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | } else if segment.len() > 0 && segment.as_bytes()[0] == b'*' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!segment.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:173:12 [INFO] [stderr] | [INFO] [stderr] 173 | if path.len() != 0 && path.as_bytes()[0] == b'/' { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:191:31 [INFO] [stderr] | [INFO] [stderr] 191 | let handler = self.handlers.get(&nfa_match.state).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.handlers[&nfa_match.state]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "adec46aff4d5d4348e21c2488bc9e524ca229673e48c5f8193ae06d344ac217b"` [INFO] running `"docker" "rm" "-f" "adec46aff4d5d4348e21c2488bc9e524ca229673e48c5f8193ae06d344ac217b"` [INFO] [stdout] adec46aff4d5d4348e21c2488bc9e524ca229673e48c5f8193ae06d344ac217b