[INFO] crate rlibc 1.0.0 is already in cache
[INFO] extracting crate rlibc 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/rlibc/1.0.0
[INFO] extracting crate rlibc 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rlibc/1.0.0
[INFO] validating manifest of rlibc-1.0.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rlibc-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rlibc-1.0.0
[INFO] finished frobbing rlibc-1.0.0
[INFO] frobbed toml for rlibc-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/rlibc/1.0.0/Cargo.toml
[INFO] started frobbing rlibc-1.0.0
[INFO] finished frobbing rlibc-1.0.0
[INFO] frobbed toml for rlibc-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rlibc/1.0.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rlibc-1.0.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rlibc/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 674e635696ef1f70b579d476f476cafc531658eb59020ad9f37729ac6519fee5
[INFO] running `"docker" "start" "-a" "674e635696ef1f70b579d476f476cafc531658eb59020ad9f37729ac6519fee5"`
[INFO] [stderr]     Checking rlibc v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:37:5
[INFO] [stderr]    |
[INFO] [stderr] 37 |     return dest;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `dest`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:56:5
[INFO] [stderr]    |
[INFO] [stderr] 56 |     return dest;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `dest`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:66:5
[INFO] [stderr]    |
[INFO] [stderr] 66 |     return s;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 |     return 0;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/lib.rs:34:37
[INFO] [stderr]    |
[INFO] [stderr] 34 |         *dest.offset(i as isize) = *src.offset(i as isize);
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^ help: try: `src.add(i)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_offset_with_cast)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/lib.rs:34:10
[INFO] [stderr]    |
[INFO] [stderr] 34 |         *dest.offset(i as isize) = *src.offset(i as isize);
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dest.add(i)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/lib.rs:47:41
[INFO] [stderr]    |
[INFO] [stderr] 47 |             *dest.offset(i as isize) = *src.offset(i as isize);
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^^^ help: try: `src.add(i)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/lib.rs:47:14
[INFO] [stderr]    |
[INFO] [stderr] 47 |             *dest.offset(i as isize) = *src.offset(i as isize);
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dest.add(i)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/lib.rs:52:41
[INFO] [stderr]    |
[INFO] [stderr] 52 |             *dest.offset(i as isize) = *src.offset(i as isize);
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^^^ help: try: `src.add(i)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/lib.rs:52:14
[INFO] [stderr]    |
[INFO] [stderr] 52 |             *dest.offset(i as isize) = *src.offset(i as isize);
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dest.add(i)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/lib.rs:63:10
[INFO] [stderr]    |
[INFO] [stderr] 63 |         *s.offset(i as isize) = c as u8;
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^ help: try: `s.add(i)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/lib.rs:73:18
[INFO] [stderr]    |
[INFO] [stderr] 73 |         let a = *s1.offset(i as isize);
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^ help: try: `s1.add(i)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/lib.rs:74:18
[INFO] [stderr]    |
[INFO] [stderr] 74 |         let b = *s2.offset(i as isize);
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^ help: try: `s2.add(i)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:76:20
[INFO] [stderr]    |
[INFO] [stderr] 76 |             return a as i32 - b as i32
[INFO] [stderr]    |                    ^^^^^^^^ help: try: `i32::from(a)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:76:31
[INFO] [stderr]    |
[INFO] [stderr] 76 |             return a as i32 - b as i32
[INFO] [stderr]    |                               ^^^^^^^^ help: try: `i32::from(b)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:37:5
[INFO] [stderr]    |
[INFO] [stderr] 37 |     return dest;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `dest`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:56:5
[INFO] [stderr]    |
[INFO] [stderr] 56 |     return dest;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `dest`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:66:5
[INFO] [stderr]    |
[INFO] [stderr] 66 |     return s;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 |     return 0;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/lib.rs:34:37
[INFO] [stderr]    |
[INFO] [stderr] 34 |         *dest.offset(i as isize) = *src.offset(i as isize);
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^ help: try: `src.add(i)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_offset_with_cast)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/lib.rs:34:10
[INFO] [stderr]    |
[INFO] [stderr] 34 |         *dest.offset(i as isize) = *src.offset(i as isize);
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dest.add(i)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/lib.rs:47:41
[INFO] [stderr]    |
[INFO] [stderr] 47 |             *dest.offset(i as isize) = *src.offset(i as isize);
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^^^ help: try: `src.add(i)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/lib.rs:47:14
[INFO] [stderr]    |
[INFO] [stderr] 47 |             *dest.offset(i as isize) = *src.offset(i as isize);
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dest.add(i)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/lib.rs:52:41
[INFO] [stderr]    |
[INFO] [stderr] 52 |             *dest.offset(i as isize) = *src.offset(i as isize);
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^^^ help: try: `src.add(i)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/lib.rs:52:14
[INFO] [stderr]    |
[INFO] [stderr] 52 |             *dest.offset(i as isize) = *src.offset(i as isize);
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dest.add(i)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/lib.rs:63:10
[INFO] [stderr]    |
[INFO] [stderr] 63 |         *s.offset(i as isize) = c as u8;
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^ help: try: `s.add(i)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/lib.rs:73:18
[INFO] [stderr]    |
[INFO] [stderr] 73 |         let a = *s1.offset(i as isize);
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^ help: try: `s1.add(i)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]   --> src/lib.rs:74:18
[INFO] [stderr]    |
[INFO] [stderr] 74 |         let b = *s2.offset(i as isize);
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^ help: try: `s2.add(i)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:76:20
[INFO] [stderr]    |
[INFO] [stderr] 76 |             return a as i32 - b as i32
[INFO] [stderr]    |                    ^^^^^^^^ help: try: `i32::from(a)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:76:31
[INFO] [stderr]    |
[INFO] [stderr] 76 |             return a as i32 - b as i32
[INFO] [stderr]    |                               ^^^^^^^^ help: try: `i32::from(b)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:133:41
[INFO] [stderr]     |
[INFO] [stderr] 133 |             memset(buffer.as_mut_ptr(), b'#' as i32, buffer.len());
[INFO] [stderr]     |                                         ^^^^^^^^^^^ help: try: `i32::from(b'#')`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in b"0123012345".iter().enumerate()` or similar iterators
[INFO] [stderr]    --> src/lib.rs:155:29
[INFO] [stderr]     |
[INFO] [stderr] 155 |                 for byte in b"0123012345".iter() {
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in b"4567896789".iter().enumerate()` or similar iterators
[INFO] [stderr]    --> src/lib.rs:166:29
[INFO] [stderr]     |
[INFO] [stderr] 166 |                 for byte in b"4567896789".iter() {
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.28s
[INFO] running `"docker" "inspect" "674e635696ef1f70b579d476f476cafc531658eb59020ad9f37729ac6519fee5"`
[INFO] running `"docker" "rm" "-f" "674e635696ef1f70b579d476f476cafc531658eb59020ad9f37729ac6519fee5"`
[INFO] [stdout] 674e635696ef1f70b579d476f476cafc531658eb59020ad9f37729ac6519fee5