[INFO] crate riff-wave 0.1.2 is already in cache [INFO] extracting crate riff-wave 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/riff-wave/0.1.2 [INFO] extracting crate riff-wave 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/riff-wave/0.1.2 [INFO] validating manifest of riff-wave-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of riff-wave-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing riff-wave-0.1.2 [INFO] finished frobbing riff-wave-0.1.2 [INFO] frobbed toml for riff-wave-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/riff-wave/0.1.2/Cargo.toml [INFO] started frobbing riff-wave-0.1.2 [INFO] finished frobbing riff-wave-0.1.2 [INFO] frobbed toml for riff-wave-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/riff-wave/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting riff-wave-0.1.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/riff-wave/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 90545283d633529b891f7d7b597eb322efead7dc4b02cc96ee4f290b748fad2a [INFO] running `"docker" "start" "-a" "90545283d633529b891f7d7b597eb322efead7dc4b02cc96ee4f290b748fad2a"` [INFO] [stderr] Checking decibel v0.1.2 [INFO] [stderr] Checking riff-wave v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | num_channels: num_channels, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_channels` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | sample_rate: sample_rate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sample_rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | bits_per_sample: bits_per_sample, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bits_per_sample` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:279:13 [INFO] [stderr] | [INFO] [stderr] 279 | pcm_format: pcm_format, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pcm_format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | num_channels: num_channels, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_channels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | sample_rate: sample_rate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sample_rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | bits_per_sample: bits_per_sample, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bits_per_sample` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | pcm_format: pcm_format, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pcm_format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:165:33 [INFO] [stderr] | [INFO] [stderr] 165 | pub const MIN_I24_VALUE: i32 = -8388608; [INFO] [stderr] | ^^^^^^^ help: consider: `8_388_608` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:166:32 [INFO] [stderr] | [INFO] [stderr] 166 | pub const MAX_I24_VALUE: i32 = 8388607; [INFO] [stderr] | ^^^^^^^ help: consider: `8_388_607` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | num_channels: num_channels, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_channels` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | sample_rate: sample_rate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sample_rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | bits_per_sample: bits_per_sample, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bits_per_sample` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:279:13 [INFO] [stderr] | [INFO] [stderr] 279 | pcm_format: pcm_format, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pcm_format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | num_channels: num_channels, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_channels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | sample_rate: sample_rate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sample_rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | bits_per_sample: bits_per_sample, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bits_per_sample` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | pcm_format: pcm_format, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pcm_format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/reader.rs:221:46 [INFO] [stderr] | [INFO] [stderr] 221 | fn validate_tag(&mut self, expected_tag: &[u8; 4], err_kind: ReadErrorKind) -> ReadResult<()> { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/reader.rs:229:53 [INFO] [stderr] | [INFO] [stderr] 229 | fn skip_until_subchunk(&mut self, matching_tag: &[u8; 4]) -> ReadResult { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/writer.rs:110:25 [INFO] [stderr] | [INFO] [stderr] 110 | let byte_rate = block_align as u32 * sample_rate; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(block_align)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/writer.rs:195:46 [INFO] [stderr] | [INFO] [stderr] 195 | writer.write_int::(clamp(sample, MIN_I24_VALUE, MAX_I24_VALUE) as i64, 3) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(clamp(sample, MIN_I24_VALUE, MAX_I24_VALUE))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/writer.rs:221:28 [INFO] [stderr] | [INFO] [stderr] 221 | let num_channels = self.pcm_format.num_channels as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.pcm_format.num_channels)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/writer.rs:247:9 [INFO] [stderr] | [INFO] [stderr] 247 | self.pcm_format.bits_per_sample as u32 / 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.pcm_format.bits_per_sample)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader.rs:850:34 [INFO] [stderr] | [INFO] [stderr] 850 | let expected_results = [ 50462976, [INFO] [stderr] | ^^^^^^^^ help: consider: `50_462_976` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader.rs:851:33 [INFO] [stderr] | [INFO] [stderr] 851 | 117835012, [INFO] [stderr] | ^^^^^^^^^ help: consider: `117_835_012` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader.rs:852:33 [INFO] [stderr] | [INFO] [stderr] 852 | 185207048, [INFO] [stderr] | ^^^^^^^^^ help: consider: `185_207_048` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reader.rs:853:33 [INFO] [stderr] | [INFO] [stderr] 853 | 252579084]; [INFO] [stderr] | ^^^^^^^^^ help: consider: `252_579_084` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer.rs:535:79 [INFO] [stderr] | [INFO] [stderr] 535 | |wave_writer, x| wave_writer.write_sample_i32(x as i32 * 8000000), [INFO] [stderr] | ^^^^^^^ help: consider: `8_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/writer.rs:536:92 [INFO] [stderr] | [INFO] [stderr] 536 | |wave_reader, x| wave_reader.read_sample_i32().unwrap() == x as i32 * 8000000); [INFO] [stderr] | ^^^^^^^ help: consider: `8_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:165:33 [INFO] [stderr] | [INFO] [stderr] 165 | pub const MIN_I24_VALUE: i32 = -8388608; [INFO] [stderr] | ^^^^^^^ help: consider: `8_388_608` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:166:32 [INFO] [stderr] | [INFO] [stderr] 166 | pub const MAX_I24_VALUE: i32 = 8388607; [INFO] [stderr] | ^^^^^^^ help: consider: `8_388_607` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> examples/playback.rs:23:37 [INFO] [stderr] | [INFO] [stderr] 23 | use std::io::{BufReader, BufWriter, Read, Seek, Write}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `WaveReader` [INFO] [stderr] --> examples/playback.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | use riff_wave::{WaveReader, WaveWriter}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_temporary_file_path` [INFO] [stderr] --> examples/playback.rs:80:1 [INFO] [stderr] | [INFO] [stderr] 80 | fn get_temporary_file_path(name: &str) -> PathBuf { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_buffered_reader_for_path` [INFO] [stderr] --> examples/playback.rs:86:1 [INFO] [stderr] | [INFO] [stderr] 86 | fn get_buffered_reader_for_path(path: &Path) -> io::Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_buffered_writer_for_path` [INFO] [stderr] --> examples/playback.rs:92:1 [INFO] [stderr] | [INFO] [stderr] 92 | fn get_buffered_writer_for_path(path: &Path) -> io::Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `write_test_sine_wave` [INFO] [stderr] --> examples/playback.rs:98:1 [INFO] [stderr] | [INFO] [stderr] 98 | fn write_test_sine_wave(writer: T, hz: u32, scale: DecibelRatio) where T: Write + Seek { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `sine_wave` [INFO] [stderr] --> examples/playback.rs:108:1 [INFO] [stderr] | [INFO] [stderr] 108 | fn sine_wave(n: u32, hz: u32, scale: DecibelRatio, sample_rate: u32) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/reader.rs:221:46 [INFO] [stderr] | [INFO] [stderr] 221 | fn validate_tag(&mut self, expected_tag: &[u8; 4], err_kind: ReadErrorKind) -> ReadResult<()> { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/reader.rs:229:53 [INFO] [stderr] | [INFO] [stderr] 229 | fn skip_until_subchunk(&mut self, matching_tag: &[u8; 4]) -> ReadResult { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `65536 * 2 + 256 + 1` [INFO] [stderr] --> src/reader.rs:832:33 [INFO] [stderr] | [INFO] [stderr] 832 | let expected_results = [65536 * 2 + 256 + 1 + 0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:911:29 [INFO] [stderr] | [INFO] [stderr] 911 | let byte_rate = block_align as u32 * sample_rate; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(block_align)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/writer.rs:110:25 [INFO] [stderr] | [INFO] [stderr] 110 | let byte_rate = block_align as u32 * sample_rate; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(block_align)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/writer.rs:195:46 [INFO] [stderr] | [INFO] [stderr] 195 | writer.write_int::(clamp(sample, MIN_I24_VALUE, MAX_I24_VALUE) as i64, 3) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(clamp(sample, MIN_I24_VALUE, MAX_I24_VALUE))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/writer.rs:221:28 [INFO] [stderr] | [INFO] [stderr] 221 | let num_channels = self.pcm_format.num_channels as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.pcm_format.num_channels)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/writer.rs:247:9 [INFO] [stderr] | [INFO] [stderr] 247 | self.pcm_format.bits_per_sample as u32 / 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.pcm_format.bits_per_sample)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/writer.rs:458:66 [INFO] [stderr] | [INFO] [stderr] 458 | wave_writer.written_samples = (u32::max_value() - 44) / (bits_per_sample as u32 / 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bits_per_sample)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/writer.rs:492:66 [INFO] [stderr] | [INFO] [stderr] 492 | wave_writer.written_samples = (u32::max_value() - 44) / (bits_per_sample as u32 / 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bits_per_sample)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/writer.rs:494:47 [INFO] [stderr] | [INFO] [stderr] 494 | assert!(wave_writer.written_samples % num_channels as u32 != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(num_channels)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/writer.rs:495:70 [INFO] [stderr] | [INFO] [stderr] 495 | wave_writer.written_samples -= wave_writer.written_samples % num_channels as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(num_channels)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/writer.rs:497:40 [INFO] [stderr] | [INFO] [stderr] 497 | wave_writer.written_samples -= num_channels as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(num_channels)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/writer.rs:570:49 [INFO] [stderr] | [INFO] [stderr] 570 | assert_eq!(get_little_endian_bytes(36 + expected_data_size as u32), &data[4..8]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(expected_data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/writer.rs:571:44 [INFO] [stderr] | [INFO] [stderr] 571 | assert_eq!(get_little_endian_bytes(expected_data_size as u32), &data[40..44]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(expected_data_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.61s [INFO] running `"docker" "inspect" "90545283d633529b891f7d7b597eb322efead7dc4b02cc96ee4f290b748fad2a"` [INFO] running `"docker" "rm" "-f" "90545283d633529b891f7d7b597eb322efead7dc4b02cc96ee4f290b748fad2a"` [INFO] [stdout] 90545283d633529b891f7d7b597eb322efead7dc4b02cc96ee4f290b748fad2a