[INFO] crate rfc2253 0.1.0 is already in cache [INFO] extracting crate rfc2253 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rfc2253/0.1.0 [INFO] extracting crate rfc2253 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rfc2253/0.1.0 [INFO] validating manifest of rfc2253-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rfc2253-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rfc2253-0.1.0 [INFO] finished frobbing rfc2253-0.1.0 [INFO] frobbed toml for rfc2253-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rfc2253/0.1.0/Cargo.toml [INFO] started frobbing rfc2253-0.1.0 [INFO] finished frobbing rfc2253-0.1.0 [INFO] frobbed toml for rfc2253-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rfc2253/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rfc2253-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rfc2253/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 757efeae7031834ccf81cf32c500d0c2698a9ea5175d3f1304cfe89441223e7d [INFO] running `"docker" "start" "-a" "757efeae7031834ccf81cf32c500d0c2698a9ea5175d3f1304cfe89441223e7d"` [INFO] [stderr] Checking rfc2253 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rfc2253.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] --> src/rfc2253.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:32:3 [INFO] [stderr] | [INFO] [stderr] 32 | return DistinguishedName { [INFO] [stderr] | _________^ [INFO] [stderr] 33 | | common_name: Some(name.to_owned()), [INFO] [stderr] 34 | | attributes: HashMap::::new() [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 32 | DistinguishedName { [INFO] [stderr] 33 | common_name: Some(name.to_owned()), [INFO] [stderr] 34 | attributes: HashMap::::new() [INFO] [stderr] 35 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:39:3 [INFO] [stderr] | [INFO] [stderr] 39 | return DistinguishedName { [INFO] [stderr] | _________^ [INFO] [stderr] 40 | | common_name: None, [INFO] [stderr] 41 | | attributes: HashMap::::new() [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 39 | DistinguishedName { [INFO] [stderr] 40 | common_name: None, [INFO] [stderr] 41 | attributes: HashMap::::new() [INFO] [stderr] 42 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:46:3 [INFO] [stderr] | [INFO] [stderr] 46 | return self.attributes.get("emailAddress").map(|s| s.to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.attributes.get("emailAddress").map(|s| s.to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:60:4 [INFO] [stderr] | [INFO] [stderr] 60 | return Some(self.input[self.cur]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.input[self.cur])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:62:4 [INFO] [stderr] | [INFO] [stderr] 62 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:67:3 [INFO] [stderr] | [INFO] [stderr] 67 | return self.cur >= self.input.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.cur >= self.input.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:83:3 [INFO] [stderr] | [INFO] [stderr] 83 | return Parser { [INFO] [stderr] | _________^ [INFO] [stderr] 84 | | state: ParserState { [INFO] [stderr] 85 | | input: input, [INFO] [stderr] 86 | | cur: 0 [INFO] [stderr] 87 | | } [INFO] [stderr] 88 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 83 | Parser { [INFO] [stderr] 84 | state: ParserState { [INFO] [stderr] 85 | input: input, [INFO] [stderr] 86 | cur: 0 [INFO] [stderr] 87 | } [INFO] [stderr] 88 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:113:3 [INFO] [stderr] | [INFO] [stderr] 113 | return Ok(map); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(map)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:133:3 [INFO] [stderr] | [INFO] [stderr] 133 | return Ok(Some((attr_type, attr_value))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some((attr_type, attr_value)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:140:6 [INFO] [stderr] | [INFO] [stderr] 140 | return self.parse_attribute_type_keychar(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.parse_attribute_type_keychar()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:142:6 [INFO] [stderr] | [INFO] [stderr] 142 | return self.parse_attribute_type_oid(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.parse_attribute_type_oid()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:144:6 [INFO] [stderr] | [INFO] [stderr] 144 | return Err(()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:146:12 [INFO] [stderr] | [INFO] [stderr] 146 | None => return Err(()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:166:3 [INFO] [stderr] | [INFO] [stderr] 166 | return Ok(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:185:3 [INFO] [stderr] | [INFO] [stderr] 185 | return Ok(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:189:3 [INFO] [stderr] | [INFO] [stderr] 189 | return self.parse_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.parse_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:193:3 [INFO] [stderr] | [INFO] [stderr] 193 | return match self.state.get() { [INFO] [stderr] | _________^ [INFO] [stderr] 194 | | Some('"') => return self.parse_string_quoted(), [INFO] [stderr] 195 | | Some('#') => return self.parse_hexstring(), [INFO] [stderr] 196 | | Some(_) => return self.parse_string_simple(), [INFO] [stderr] 197 | | None => Err(()), [INFO] [stderr] 198 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 193 | match self.state.get() { [INFO] [stderr] 194 | Some('"') => return self.parse_string_quoted(), [INFO] [stderr] 195 | Some('#') => return self.parse_hexstring(), [INFO] [stderr] 196 | Some(_) => return self.parse_string_simple(), [INFO] [stderr] 197 | None => Err(()), [INFO] [stderr] 198 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:224:3 [INFO] [stderr] | [INFO] [stderr] 224 | return Ok(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:260:3 [INFO] [stderr] | [INFO] [stderr] 260 | return Ok(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:270:3 [INFO] [stderr] | [INFO] [stderr] 270 | return match self.state.get() { [INFO] [stderr] | _________^ [INFO] [stderr] 271 | | Some(c) => [INFO] [stderr] 272 | | if is_special(c) || is_quotation(c) || is_escape(c) { [INFO] [stderr] 273 | | self.state.consume(); [INFO] [stderr] ... | [INFO] [stderr] 280 | | None => Err(()), [INFO] [stderr] 281 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 270 | match self.state.get() { [INFO] [stderr] 271 | Some(c) => [INFO] [stderr] 272 | if is_special(c) || is_quotation(c) || is_escape(c) { [INFO] [stderr] 273 | self.state.consume(); [INFO] [stderr] 274 | Ok(c.to_string()) [INFO] [stderr] 275 | } else if is_hexchar(c) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:308:3 [INFO] [stderr] | [INFO] [stderr] 308 | return Ok(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:324:17 [INFO] [stderr] | [INFO] [stderr] 324 | Some(c) => return Ok(c.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(c.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:325:14 [INFO] [stderr] | [INFO] [stderr] 325 | None => return Err(()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:327:14 [INFO] [stderr] | [INFO] [stderr] 327 | Err(_) => return Err(()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:334:2 [INFO] [stderr] | [INFO] [stderr] 334 | return (chr >= 'A' && chr <= 'Z') || (chr >= 'a' && chr <= 'z'); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(chr >= 'A' && chr <= 'Z') || (chr >= 'a' && chr <= 'z')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:338:2 [INFO] [stderr] | [INFO] [stderr] 338 | return chr >= '0' && chr <= '9'; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `chr >= '0' && chr <= '9'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:342:2 [INFO] [stderr] | [INFO] [stderr] 342 | return [INFO] [stderr] | _____^ [INFO] [stderr] 343 | | chr == ',' || [INFO] [stderr] 344 | | chr == '=' || [INFO] [stderr] 345 | | chr == '+' || [INFO] [stderr] ... | [INFO] [stderr] 348 | | chr == '#' || [INFO] [stderr] 349 | | chr == ';'; [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 342 | chr == ',' || [INFO] [stderr] 343 | chr == '=' || [INFO] [stderr] 344 | chr == '+' || [INFO] [stderr] 345 | chr == '<' || [INFO] [stderr] 346 | chr == '>' || [INFO] [stderr] 347 | chr == '#' || [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:353:2 [INFO] [stderr] | [INFO] [stderr] 353 | return chr == '"'; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `chr == '"'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:357:2 [INFO] [stderr] | [INFO] [stderr] 357 | return chr == '\\'; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `chr == '\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:361:2 [INFO] [stderr] | [INFO] [stderr] 361 | return [INFO] [stderr] | _____^ [INFO] [stderr] 362 | | (chr >= '0' && chr <= '9') || [INFO] [stderr] 363 | | (chr >= 'A' && chr <= 'F') || [INFO] [stderr] 364 | | (chr >= 'a' && chr <= 'f'); [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 361 | (chr >= '0' && chr <= '9') || [INFO] [stderr] 362 | (chr >= 'A' && chr <= 'F') || [INFO] [stderr] 363 | (chr >= 'a' && chr <= 'f') [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:370:2 [INFO] [stderr] | [INFO] [stderr] 370 | return match parser.parse_attributes() { [INFO] [stderr] | _____^ [INFO] [stderr] 371 | | Ok(attr) => Ok(DistinguishedName { [INFO] [stderr] 372 | | common_name: attr.get("CN").map(|x| x.to_owned()), [INFO] [stderr] 373 | | attributes: attr [INFO] [stderr] 374 | | }), [INFO] [stderr] 375 | | Err(_) => Err(()), [INFO] [stderr] 376 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 370 | match parser.parse_attributes() { [INFO] [stderr] 371 | Ok(attr) => Ok(DistinguishedName { [INFO] [stderr] 372 | common_name: attr.get("CN").map(|x| x.to_owned()), [INFO] [stderr] 373 | attributes: attr [INFO] [stderr] 374 | }), [INFO] [stderr] 375 | Err(_) => Err(()), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:381:2 [INFO] [stderr] | [INFO] [stderr] 381 | return parse_distinguished_name(&chars); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse_distinguished_name(&chars)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:32:3 [INFO] [stderr] | [INFO] [stderr] 32 | return DistinguishedName { [INFO] [stderr] | _________^ [INFO] [stderr] 33 | | common_name: Some(name.to_owned()), [INFO] [stderr] 34 | | attributes: HashMap::::new() [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 32 | DistinguishedName { [INFO] [stderr] 33 | common_name: Some(name.to_owned()), [INFO] [stderr] 34 | attributes: HashMap::::new() [INFO] [stderr] 35 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:39:3 [INFO] [stderr] | [INFO] [stderr] 39 | return DistinguishedName { [INFO] [stderr] | _________^ [INFO] [stderr] 40 | | common_name: None, [INFO] [stderr] 41 | | attributes: HashMap::::new() [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 39 | DistinguishedName { [INFO] [stderr] 40 | common_name: None, [INFO] [stderr] 41 | attributes: HashMap::::new() [INFO] [stderr] 42 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:46:3 [INFO] [stderr] | [INFO] [stderr] 46 | return self.attributes.get("emailAddress").map(|s| s.to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.attributes.get("emailAddress").map(|s| s.to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:60:4 [INFO] [stderr] | [INFO] [stderr] 60 | return Some(self.input[self.cur]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.input[self.cur])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:62:4 [INFO] [stderr] | [INFO] [stderr] 62 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:67:3 [INFO] [stderr] | [INFO] [stderr] 67 | return self.cur >= self.input.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.cur >= self.input.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:83:3 [INFO] [stderr] | [INFO] [stderr] 83 | return Parser { [INFO] [stderr] | _________^ [INFO] [stderr] 84 | | state: ParserState { [INFO] [stderr] 85 | | input: input, [INFO] [stderr] 86 | | cur: 0 [INFO] [stderr] 87 | | } [INFO] [stderr] 88 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 83 | Parser { [INFO] [stderr] 84 | state: ParserState { [INFO] [stderr] 85 | input: input, [INFO] [stderr] 86 | cur: 0 [INFO] [stderr] 87 | } [INFO] [stderr] 88 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:113:3 [INFO] [stderr] | [INFO] [stderr] 113 | return Ok(map); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(map)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:133:3 [INFO] [stderr] | [INFO] [stderr] 133 | return Ok(Some((attr_type, attr_value))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some((attr_type, attr_value)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:140:6 [INFO] [stderr] | [INFO] [stderr] 140 | return self.parse_attribute_type_keychar(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.parse_attribute_type_keychar()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:142:6 [INFO] [stderr] | [INFO] [stderr] 142 | return self.parse_attribute_type_oid(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.parse_attribute_type_oid()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:144:6 [INFO] [stderr] | [INFO] [stderr] 144 | return Err(()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:146:12 [INFO] [stderr] | [INFO] [stderr] 146 | None => return Err(()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:166:3 [INFO] [stderr] | [INFO] [stderr] 166 | return Ok(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:185:3 [INFO] [stderr] | [INFO] [stderr] 185 | return Ok(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:189:3 [INFO] [stderr] | [INFO] [stderr] 189 | return self.parse_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.parse_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:193:3 [INFO] [stderr] | [INFO] [stderr] 193 | return match self.state.get() { [INFO] [stderr] | _________^ [INFO] [stderr] 194 | | Some('"') => return self.parse_string_quoted(), [INFO] [stderr] 195 | | Some('#') => return self.parse_hexstring(), [INFO] [stderr] 196 | | Some(_) => return self.parse_string_simple(), [INFO] [stderr] 197 | | None => Err(()), [INFO] [stderr] 198 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 193 | match self.state.get() { [INFO] [stderr] 194 | Some('"') => return self.parse_string_quoted(), [INFO] [stderr] 195 | Some('#') => return self.parse_hexstring(), [INFO] [stderr] 196 | Some(_) => return self.parse_string_simple(), [INFO] [stderr] 197 | None => Err(()), [INFO] [stderr] 198 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:224:3 [INFO] [stderr] | [INFO] [stderr] 224 | return Ok(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:260:3 [INFO] [stderr] | [INFO] [stderr] 260 | return Ok(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:270:3 [INFO] [stderr] | [INFO] [stderr] 270 | return match self.state.get() { [INFO] [stderr] | _________^ [INFO] [stderr] 271 | | Some(c) => [INFO] [stderr] 272 | | if is_special(c) || is_quotation(c) || is_escape(c) { [INFO] [stderr] 273 | | self.state.consume(); [INFO] [stderr] ... | [INFO] [stderr] 280 | | None => Err(()), [INFO] [stderr] 281 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 270 | match self.state.get() { [INFO] [stderr] 271 | Some(c) => [INFO] [stderr] 272 | if is_special(c) || is_quotation(c) || is_escape(c) { [INFO] [stderr] 273 | self.state.consume(); [INFO] [stderr] 274 | Ok(c.to_string()) [INFO] [stderr] 275 | } else if is_hexchar(c) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:308:3 [INFO] [stderr] | [INFO] [stderr] 308 | return Ok(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:324:17 [INFO] [stderr] | [INFO] [stderr] 324 | Some(c) => return Ok(c.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(c.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:325:14 [INFO] [stderr] | [INFO] [stderr] 325 | None => return Err(()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:327:14 [INFO] [stderr] | [INFO] [stderr] 327 | Err(_) => return Err(()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:334:2 [INFO] [stderr] | [INFO] [stderr] 334 | return (chr >= 'A' && chr <= 'Z') || (chr >= 'a' && chr <= 'z'); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(chr >= 'A' && chr <= 'Z') || (chr >= 'a' && chr <= 'z')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:338:2 [INFO] [stderr] | [INFO] [stderr] 338 | return chr >= '0' && chr <= '9'; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `chr >= '0' && chr <= '9'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:342:2 [INFO] [stderr] | [INFO] [stderr] 342 | return [INFO] [stderr] | _____^ [INFO] [stderr] 343 | | chr == ',' || [INFO] [stderr] 344 | | chr == '=' || [INFO] [stderr] 345 | | chr == '+' || [INFO] [stderr] ... | [INFO] [stderr] 348 | | chr == '#' || [INFO] [stderr] 349 | | chr == ';'; [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 342 | chr == ',' || [INFO] [stderr] 343 | chr == '=' || [INFO] [stderr] 344 | chr == '+' || [INFO] [stderr] 345 | chr == '<' || [INFO] [stderr] 346 | chr == '>' || [INFO] [stderr] 347 | chr == '#' || [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:353:2 [INFO] [stderr] | [INFO] [stderr] 353 | return chr == '"'; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `chr == '"'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:357:2 [INFO] [stderr] | [INFO] [stderr] 357 | return chr == '\\'; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `chr == '\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:361:2 [INFO] [stderr] | [INFO] [stderr] 361 | return [INFO] [stderr] | _____^ [INFO] [stderr] 362 | | (chr >= '0' && chr <= '9') || [INFO] [stderr] 363 | | (chr >= 'A' && chr <= 'F') || [INFO] [stderr] 364 | | (chr >= 'a' && chr <= 'f'); [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 361 | (chr >= '0' && chr <= '9') || [INFO] [stderr] 362 | (chr >= 'A' && chr <= 'F') || [INFO] [stderr] 363 | (chr >= 'a' && chr <= 'f') [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:370:2 [INFO] [stderr] | [INFO] [stderr] 370 | return match parser.parse_attributes() { [INFO] [stderr] | _____^ [INFO] [stderr] 371 | | Ok(attr) => Ok(DistinguishedName { [INFO] [stderr] 372 | | common_name: attr.get("CN").map(|x| x.to_owned()), [INFO] [stderr] 373 | | attributes: attr [INFO] [stderr] 374 | | }), [INFO] [stderr] 375 | | Err(_) => Err(()), [INFO] [stderr] 376 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 370 | match parser.parse_attributes() { [INFO] [stderr] 371 | Ok(attr) => Ok(DistinguishedName { [INFO] [stderr] 372 | common_name: attr.get("CN").map(|x| x.to_owned()), [INFO] [stderr] 373 | attributes: attr [INFO] [stderr] 374 | }), [INFO] [stderr] 375 | Err(_) => Err(()), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rfc2253.rs:381:2 [INFO] [stderr] | [INFO] [stderr] 381 | return parse_distinguished_name(&chars); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse_distinguished_name(&chars)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `DistinguishedName` [INFO] [stderr] --> src/rfc2253.rs:38:2 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn new() -> DistinguishedName { [INFO] [stderr] | _____^ [INFO] [stderr] 39 | | return DistinguishedName { [INFO] [stderr] 40 | | common_name: None, [INFO] [stderr] 41 | | attributes: HashMap::::new() [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/rfc2253.rs:204:3 [INFO] [stderr] | [INFO] [stderr] 204 | loop { [INFO] [stderr] | _________^ [INFO] [stderr] 205 | | match self.state.get() { [INFO] [stderr] 206 | | Some(c) => [INFO] [stderr] 207 | | if is_special(c) { [INFO] [stderr] ... | [INFO] [stderr] 221 | | } [INFO] [stderr] 222 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(c) = self.state.get() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/rfc2253.rs:293:3 [INFO] [stderr] | [INFO] [stderr] 293 | loop { [INFO] [stderr] | _________^ [INFO] [stderr] 294 | | match self.state.get() { [INFO] [stderr] 295 | | Some(c) => [INFO] [stderr] 296 | | if is_hexchar(c) { [INFO] [stderr] ... | [INFO] [stderr] 305 | | } [INFO] [stderr] 306 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(c) = self.state.get() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `DistinguishedName` [INFO] [stderr] --> src/rfc2253.rs:38:2 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn new() -> DistinguishedName { [INFO] [stderr] | _____^ [INFO] [stderr] 39 | | return DistinguishedName { [INFO] [stderr] 40 | | common_name: None, [INFO] [stderr] 41 | | attributes: HashMap::::new() [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/rfc2253.rs:204:3 [INFO] [stderr] | [INFO] [stderr] 204 | loop { [INFO] [stderr] | _________^ [INFO] [stderr] 205 | | match self.state.get() { [INFO] [stderr] 206 | | Some(c) => [INFO] [stderr] 207 | | if is_special(c) { [INFO] [stderr] ... | [INFO] [stderr] 221 | | } [INFO] [stderr] 222 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(c) = self.state.get() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/rfc2253.rs:293:3 [INFO] [stderr] | [INFO] [stderr] 293 | loop { [INFO] [stderr] | _________^ [INFO] [stderr] 294 | | match self.state.get() { [INFO] [stderr] 295 | | Some(c) => [INFO] [stderr] 296 | | if is_hexchar(c) { [INFO] [stderr] ... | [INFO] [stderr] 305 | | } [INFO] [stderr] 306 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(c) = self.state.get() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rfc2253.rs:391:11 [INFO] [stderr] | [INFO] [stderr] 391 | assert!(res.attributes.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `res.attributes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:399:11 [INFO] [stderr] | [INFO] [stderr] 399 | assert!(res.attributes.get("C").unwrap() == "DE"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["C"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:407:11 [INFO] [stderr] | [INFO] [stderr] 407 | assert!(res.attributes.get("CN").unwrap() == "Nyan Cat"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["CN"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:415:11 [INFO] [stderr] | [INFO] [stderr] 415 | assert!(res.attributes.get("CN").unwrap() == "Nyan \"Cat\""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["CN"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:423:11 [INFO] [stderr] | [INFO] [stderr] 423 | assert!(res.attributes.get("CN").unwrap() == "Nyan=Cat"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["CN"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:431:11 [INFO] [stderr] | [INFO] [stderr] 431 | assert!(res.attributes.get("CN").unwrap() == "Nyan\\Cat"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["CN"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:439:11 [INFO] [stderr] | [INFO] [stderr] 439 | assert!(res.attributes.get("CN").unwrap() == "Nyan!Cat?"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["CN"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:447:11 [INFO] [stderr] | [INFO] [stderr] 447 | assert!(res.attributes.get("C").unwrap() == "DE"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["C"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:455:11 [INFO] [stderr] | [INFO] [stderr] 455 | assert!(res.attributes.get("CN").unwrap() == "Nyan Cat"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["CN"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:463:11 [INFO] [stderr] | [INFO] [stderr] 463 | assert!(res.attributes.get("CN").unwrap() == "Nyan \"Cat\""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["CN"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:471:11 [INFO] [stderr] | [INFO] [stderr] 471 | assert!(res.attributes.get("CN").unwrap() == "Nyan=Cat"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["CN"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:479:11 [INFO] [stderr] | [INFO] [stderr] 479 | assert!(res.attributes.get("CN").unwrap() == "Nyan\\Cat"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["CN"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:487:11 [INFO] [stderr] | [INFO] [stderr] 487 | assert!(res.attributes.get("CN").unwrap() == "Nyan!Cat?"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["CN"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:495:11 [INFO] [stderr] | [INFO] [stderr] 495 | assert!(res.attributes.get("CN").unwrap() == "NYAN!?"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["CN"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:531:11 [INFO] [stderr] | [INFO] [stderr] 531 | assert!(res.attributes.get("C").unwrap() == "DE"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["C"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:532:11 [INFO] [stderr] | [INFO] [stderr] 532 | assert!(res.attributes.get("L").unwrap() == "Berlin"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["L"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:533:11 [INFO] [stderr] | [INFO] [stderr] 533 | assert!(res.attributes.get("ST").unwrap() == "Berlin"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["ST"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:541:11 [INFO] [stderr] | [INFO] [stderr] 541 | assert!(res.attributes.get("C").unwrap() == "DE"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["C"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:542:11 [INFO] [stderr] | [INFO] [stderr] 542 | assert!(res.attributes.get("L").unwrap() == "Berlin"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["L"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:543:11 [INFO] [stderr] | [INFO] [stderr] 543 | assert!(res.attributes.get("ST").unwrap() == "Berlin"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["ST"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:550:11 [INFO] [stderr] | [INFO] [stderr] 550 | assert!(res.attributes.get("CN").unwrap() == "paul "); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["CN"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:552:11 [INFO] [stderr] | [INFO] [stderr] 552 | assert!(res.attributes.get("C").unwrap() == "DE"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["C"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:553:11 [INFO] [stderr] | [INFO] [stderr] 553 | assert!(res.attributes.get("L").unwrap() == "Berlin"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["L"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:554:11 [INFO] [stderr] | [INFO] [stderr] 554 | assert!(res.attributes.get("ST").unwrap() == "Berlin"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["ST"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:555:11 [INFO] [stderr] | [INFO] [stderr] 555 | assert!(res.attributes.get("O").unwrap() == "ACME Inc."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["O"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rfc2253.rs:556:11 [INFO] [stderr] | [INFO] [stderr] 556 | assert!(res.attributes.get("OU").unwrap() == "ACME Inc."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&res.attributes["OU"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> examples/rfc2253-example.rs:9:11 [INFO] [stderr] | [INFO] [stderr] 9 | assert!(dn.attributes.get("CN").unwrap() == "Hans Tester"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&dn.attributes["CN"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> examples/rfc2253-example.rs:10:11 [INFO] [stderr] | [INFO] [stderr] 10 | assert!(dn.attributes.get("C").unwrap() == "DE"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&dn.attributes["C"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> examples/rfc2253-example.rs:11:11 [INFO] [stderr] | [INFO] [stderr] 11 | assert!(dn.attributes.get("L").unwrap() == "Berlin"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&dn.attributes["L"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> examples/rfc2253-example.rs:12:11 [INFO] [stderr] | [INFO] [stderr] 12 | assert!(dn.attributes.get("ST").unwrap() == "Berlin"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&dn.attributes["ST"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> examples/rfc2253-example.rs:13:11 [INFO] [stderr] | [INFO] [stderr] 13 | assert!(dn.attributes.get("O").unwrap() == "ACME Inc."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&dn.attributes["O"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> examples/rfc2253-example.rs:14:11 [INFO] [stderr] | [INFO] [stderr] 14 | assert!(dn.attributes.get("OU").unwrap() == "ACME Inc."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&dn.attributes["OU"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.80s [INFO] running `"docker" "inspect" "757efeae7031834ccf81cf32c500d0c2698a9ea5175d3f1304cfe89441223e7d"` [INFO] running `"docker" "rm" "-f" "757efeae7031834ccf81cf32c500d0c2698a9ea5175d3f1304cfe89441223e7d"` [INFO] [stdout] 757efeae7031834ccf81cf32c500d0c2698a9ea5175d3f1304cfe89441223e7d