[INFO] crate resolv-conf 0.6.1 is already in cache [INFO] extracting crate resolv-conf 0.6.1 into work/ex/clippy-test-run/sources/stable/reg/resolv-conf/0.6.1 [INFO] extracting crate resolv-conf 0.6.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/resolv-conf/0.6.1 [INFO] validating manifest of resolv-conf-0.6.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of resolv-conf-0.6.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing resolv-conf-0.6.1 [INFO] finished frobbing resolv-conf-0.6.1 [INFO] frobbed toml for resolv-conf-0.6.1 written to work/ex/clippy-test-run/sources/stable/reg/resolv-conf/0.6.1/Cargo.toml [INFO] started frobbing resolv-conf-0.6.1 [INFO] finished frobbing resolv-conf-0.6.1 [INFO] frobbed toml for resolv-conf-0.6.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/resolv-conf/0.6.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting resolv-conf-0.6.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/resolv-conf/0.6.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a013f04e0f69579b56cad8f16596f2fd705346554203e6103cde2f2b0b26c03f [INFO] running `"docker" "start" "-a" "a013f04e0f69579b56cad8f16596f2fd705346554203e6103cde2f2b0b26c03f"` [INFO] [stderr] Checking resolv-conf v0.6.1 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider adding a `Default` implementation for `config::Config` [INFO] [stderr] --> src/config.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | / pub fn new() -> Config { [INFO] [stderr] 130 | | Config { [INFO] [stderr] 131 | | nameservers: Vec::new(), [INFO] [stderr] 132 | | domain: None, [INFO] [stderr] ... | [INFO] [stderr] 150 | | } [INFO] [stderr] 151 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 102 | impl Default for config::Config { [INFO] [stderr] 103 | fn default() -> Self { [INFO] [stderr] 104 | Self::new() [INFO] [stderr] 105 | } [INFO] [stderr] 106 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/config.rs:196:5 [INFO] [stderr] | [INFO] [stderr] 196 | / pub fn get_last_search_or_domain<'a>(&'a self) -> DomainIter<'a> { [INFO] [stderr] 197 | | let domain_iter = match self.last_search { [INFO] [stderr] 198 | | LastSearch::Search => DomainIterInternal::Search( [INFO] [stderr] 199 | | self.get_search() [INFO] [stderr] ... | [INFO] [stderr] 205 | | DomainIter(domain_iter) [INFO] [stderr] 206 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/config.rs:200:54 [INFO] [stderr] | [INFO] [stderr] 200 | .and_then(|domains| Some(domains.into_iter())), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `config::Config` [INFO] [stderr] --> src/config.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | / pub fn new() -> Config { [INFO] [stderr] 130 | | Config { [INFO] [stderr] 131 | | nameservers: Vec::new(), [INFO] [stderr] 132 | | domain: None, [INFO] [stderr] ... | [INFO] [stderr] 150 | | } [INFO] [stderr] 151 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 102 | impl Default for config::Config { [INFO] [stderr] 103 | fn default() -> Self { [INFO] [stderr] 104 | Self::new() [INFO] [stderr] 105 | } [INFO] [stderr] 106 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/config.rs:196:5 [INFO] [stderr] | [INFO] [stderr] 196 | / pub fn get_last_search_or_domain<'a>(&'a self) -> DomainIter<'a> { [INFO] [stderr] 197 | | let domain_iter = match self.last_search { [INFO] [stderr] 198 | | LastSearch::Search => DomainIterInternal::Search( [INFO] [stderr] 199 | | self.get_search() [INFO] [stderr] ... | [INFO] [stderr] 205 | | DomainIter(domain_iter) [INFO] [stderr] 206 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/config.rs:200:54 [INFO] [stderr] | [INFO] [stderr] 200 | .and_then(|domains| Some(domains.into_iter())), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.57s [INFO] running `"docker" "inspect" "a013f04e0f69579b56cad8f16596f2fd705346554203e6103cde2f2b0b26c03f"` [INFO] running `"docker" "rm" "-f" "a013f04e0f69579b56cad8f16596f2fd705346554203e6103cde2f2b0b26c03f"` [INFO] [stdout] a013f04e0f69579b56cad8f16596f2fd705346554203e6103cde2f2b0b26c03f