[INFO] crate reproto-semver 0.3.36 is already in cache [INFO] extracting crate reproto-semver 0.3.36 into work/ex/clippy-test-run/sources/stable/reg/reproto-semver/0.3.36 [INFO] extracting crate reproto-semver 0.3.36 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reproto-semver/0.3.36 [INFO] validating manifest of reproto-semver-0.3.36 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of reproto-semver-0.3.36 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing reproto-semver-0.3.36 [INFO] finished frobbing reproto-semver-0.3.36 [INFO] frobbed toml for reproto-semver-0.3.36 written to work/ex/clippy-test-run/sources/stable/reg/reproto-semver/0.3.36/Cargo.toml [INFO] started frobbing reproto-semver-0.3.36 [INFO] finished frobbing reproto-semver-0.3.36 [INFO] frobbed toml for reproto-semver-0.3.36 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reproto-semver/0.3.36/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting reproto-semver-0.3.36 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reproto-semver/0.3.36:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f38d0405d0a53fa0e7690e08def7600c1a233fb5e66d532955846d3e9260008a [INFO] running `"docker" "start" "-a" "f38d0405d0a53fa0e7690e08def7600c1a233fb5e66d532955846d3e9260008a"` [INFO] [stderr] Checking reproto-semver v0.3.36 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | chars: chars, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | c1: c1, [INFO] [stderr] | ^^^^^^ help: replace it with: `c1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | c2: c2, [INFO] [stderr] | ^^^^^^ help: replace it with: `c2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | lexer: lexer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lexer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | c1: c1, [INFO] [stderr] | ^^^^^^ help: replace it with: `c1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:354:13 [INFO] [stderr] | [INFO] [stderr] 354 | op: op, [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:355:13 [INFO] [stderr] | [INFO] [stderr] 355 | major: major, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `major` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:356:13 [INFO] [stderr] | [INFO] [stderr] 356 | minor: minor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:357:13 [INFO] [stderr] | [INFO] [stderr] 357 | patch: patch, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `patch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:358:13 [INFO] [stderr] | [INFO] [stderr] 358 | pre: pre, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pre` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:377:13 [INFO] [stderr] | [INFO] [stderr] 377 | predicates: predicates, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `predicates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:396:13 [INFO] [stderr] | [INFO] [stderr] 396 | major: major, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `major` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:397:13 [INFO] [stderr] | [INFO] [stderr] 397 | minor: minor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | patch: patch, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `patch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:399:13 [INFO] [stderr] | [INFO] [stderr] 399 | pre: pre, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pre` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:400:13 [INFO] [stderr] | [INFO] [stderr] 400 | build: build, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `build` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> version.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | major: major, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `major` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> version.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | minor: minor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> version.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | patch: patch, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `patch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | chars: chars, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | c1: c1, [INFO] [stderr] | ^^^^^^ help: replace it with: `c1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lexer.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | c2: c2, [INFO] [stderr] | ^^^^^^ help: replace it with: `c2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | lexer: lexer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lexer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | c1: c1, [INFO] [stderr] | ^^^^^^ help: replace it with: `c1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:354:13 [INFO] [stderr] | [INFO] [stderr] 354 | op: op, [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:355:13 [INFO] [stderr] | [INFO] [stderr] 355 | major: major, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `major` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:356:13 [INFO] [stderr] | [INFO] [stderr] 356 | minor: minor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:357:13 [INFO] [stderr] | [INFO] [stderr] 357 | patch: patch, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `patch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:358:13 [INFO] [stderr] | [INFO] [stderr] 358 | pre: pre, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pre` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:377:13 [INFO] [stderr] | [INFO] [stderr] 377 | predicates: predicates, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `predicates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:396:13 [INFO] [stderr] | [INFO] [stderr] 396 | major: major, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `major` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:397:13 [INFO] [stderr] | [INFO] [stderr] 397 | minor: minor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | patch: patch, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `patch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:399:13 [INFO] [stderr] | [INFO] [stderr] 399 | pre: pre, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pre` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> parser.rs:400:13 [INFO] [stderr] | [INFO] [stderr] 400 | build: build, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `build` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> version.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | major: major, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `major` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> version.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | minor: minor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> version.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | patch: patch, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `patch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> lexer.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | / loop { [INFO] [stderr] 231 | | // two subsequent char tokens. [INFO] [stderr] 232 | | if let Some((_, a, b)) = self.two() { [INFO] [stderr] 233 | | let two = match (a, b) { [INFO] [stderr] ... | [INFO] [stderr] 274 | | return None; [INFO] [stderr] 275 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> parser.rs:405:19 [INFO] [stderr] | [INFO] [stderr] 405 | pub fn is_eof(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> range.rs:406:17 [INFO] [stderr] | [INFO] [stderr] 406 | / match self.minor { [INFO] [stderr] 407 | | Some(v) => try!(write!(fmt, ".{}", v)), [INFO] [stderr] 408 | | None => (), [INFO] [stderr] 409 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(v) = self.minor { try!(write!(fmt, ".{}", v)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> range.rs:411:17 [INFO] [stderr] | [INFO] [stderr] 411 | / match self.patch { [INFO] [stderr] 412 | | Some(v) => try!(write!(fmt, ".{}", v)), [INFO] [stderr] 413 | | None => (), [INFO] [stderr] 414 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(v) = self.patch { try!(write!(fmt, ".{}", v)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `reproto-semver`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> lexer.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | / loop { [INFO] [stderr] 231 | | // two subsequent char tokens. [INFO] [stderr] 232 | | if let Some((_, a, b)) = self.two() { [INFO] [stderr] 233 | | let two = match (a, b) { [INFO] [stderr] ... | [INFO] [stderr] 274 | | return None; [INFO] [stderr] 275 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> parser.rs:405:19 [INFO] [stderr] | [INFO] [stderr] 405 | pub fn is_eof(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> range.rs:406:17 [INFO] [stderr] | [INFO] [stderr] 406 | / match self.minor { [INFO] [stderr] 407 | | Some(v) => try!(write!(fmt, ".{}", v)), [INFO] [stderr] 408 | | None => (), [INFO] [stderr] 409 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(v) = self.minor { try!(write!(fmt, ".{}", v)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> range.rs:411:17 [INFO] [stderr] | [INFO] [stderr] 411 | / match self.patch { [INFO] [stderr] 412 | | Some(v) => try!(write!(fmt, ".{}", v)), [INFO] [stderr] 413 | | None => (), [INFO] [stderr] 414 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(v) = self.patch { try!(write!(fmt, ".{}", v)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> range.rs:500:34 [INFO] [stderr] | [INFO] [stderr] 500 | assert!(r.to_string() == "= 1.0.0".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `"= 1.0.0"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> version.rs:611:17 [INFO] [stderr] | [INFO] [stderr] 611 | assert!(Version::parse("1.0.0").unwrap().is_prerelease() == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!Version::parse("1.0.0").unwrap().is_prerelease()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> version.rs:612:17 [INFO] [stderr] | [INFO] [stderr] 612 | assert!(Version::parse("0.0.1").unwrap().is_prerelease() == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!Version::parse("0.0.1").unwrap().is_prerelease()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> version.rs:808:59 [INFO] [stderr] | [INFO] [stderr] 808 | for (i, &SemverTest(left, right, loose)) in input.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into-iter-on-array` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> version.rs:943:60 [INFO] [stderr] | [INFO] [stderr] 943 | for (i, &SemverTest(req, version, loose)) in input.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `reproto-semver`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f38d0405d0a53fa0e7690e08def7600c1a233fb5e66d532955846d3e9260008a"` [INFO] running `"docker" "rm" "-f" "f38d0405d0a53fa0e7690e08def7600c1a233fb5e66d532955846d3e9260008a"` [INFO] [stdout] f38d0405d0a53fa0e7690e08def7600c1a233fb5e66d532955846d3e9260008a