[INFO] crate reffers 0.5.1 is already in cache [INFO] extracting crate reffers 0.5.1 into work/ex/clippy-test-run/sources/stable/reg/reffers/0.5.1 [INFO] extracting crate reffers 0.5.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reffers/0.5.1 [INFO] validating manifest of reffers-0.5.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of reffers-0.5.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing reffers-0.5.1 [INFO] finished frobbing reffers-0.5.1 [INFO] frobbed toml for reffers-0.5.1 written to work/ex/clippy-test-run/sources/stable/reg/reffers/0.5.1/Cargo.toml [INFO] started frobbing reffers-0.5.1 [INFO] finished frobbing reffers-0.5.1 [INFO] frobbed toml for reffers-0.5.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reffers/0.5.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting reffers-0.5.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reffers/0.5.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 36a6750daa7148a9feb94f05ed421896041ce10ee31f26daeab9d9fdf70b3ebf [INFO] running `"docker" "start" "-a" "36a6750daa7148a9feb94f05ed421896041ce10ee31f26daeab9d9fdf70b3ebf"` [INFO] [stderr] Checking reffers v0.5.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/aref.rs:441:13 [INFO] [stderr] | [INFO] [stderr] 441 | target: target, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/aref.rs:441:13 [INFO] [stderr] | [INFO] [stderr] 441 | target: target, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/arc.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | r [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/arc.rs:225:17 [INFO] [stderr] | [INFO] [stderr] 225 | let r = ArcPtr(z, PhantomData); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rc_bitmask.rs:200:41 [INFO] [stderr] | [INFO] [stderr] 200 | assert_eq!(u32::SHIFTED[BM_REF], 0x00000004); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rc_bitmask.rs:201:41 [INFO] [stderr] | [INFO] [stderr] 201 | assert_eq!(u32::MASKS[BM_REF], 0x00000ffc); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0ffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rc_bitmask.rs:202:41 [INFO] [stderr] | [INFO] [stderr] 202 | assert_eq!(u32::SHIFTED[BM_STRONG], 0x00001000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rc_bitmask.rs:203:41 [INFO] [stderr] | [INFO] [stderr] 203 | assert_eq!(u32::MASKS[BM_STRONG], 0x003ff000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x003f_f000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rc_bitmask.rs:204:41 [INFO] [stderr] | [INFO] [stderr] 204 | assert_eq!(u32::SHIFTED[BM_WEAK], 0x00400000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rc_bitmask.rs:205:41 [INFO] [stderr] | [INFO] [stderr] 205 | assert_eq!(u32::MASKS[BM_WEAK], 0xffc00000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffc0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rc_bitmask.rs:208:19 [INFO] [stderr] | [INFO] [stderr] 208 | assert_eq!(m, 0x00400000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rc_bitmask.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | m = 0xffc00000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffc0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/arc.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | r [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/arc.rs:225:17 [INFO] [stderr] | [INFO] [stderr] 225 | let r = ArcPtr(z, PhantomData); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/aref.rs:295:5 [INFO] [stderr] | [INFO] [stderr] 295 | fn ne(&self, other: &Self) -> bool { **self != **other } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/aref.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | fn ne(&self, other: &Self) -> bool { self.0.ne(&other.0) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/aref.rs:309:5 [INFO] [stderr] | [INFO] [stderr] 309 | fn ne(&self, other: &Self) -> bool { self.0.ne(&other.0) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/aref.rs:531:31 [INFO] [stderr] | [INFO] [stderr] 531 | self.0.try_map(f).map(|z| ARefs(z)) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `ARefs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/aref.rs:579:31 [INFO] [stderr] | [INFO] [stderr] 579 | self.0.try_map(f).map(|z| ARefss(z)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `ARefss` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rmba.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / match self { [INFO] [stderr] 21 | | &SlowRMBA::Ref(ref t) => Some(SlowRMBA::Ref(t)), [INFO] [stderr] 22 | | &SlowRMBA::Arc(ref t) => Some(SlowRMBA::Arc(t.clone())), [INFO] [stderr] 23 | | _ => None, [INFO] [stderr] 24 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 20 | match *self { [INFO] [stderr] 21 | SlowRMBA::Ref(ref t) => Some(SlowRMBA::Ref(t)), [INFO] [stderr] 22 | SlowRMBA::Arc(ref t) => Some(SlowRMBA::Arc(t.clone())), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rmba.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / match self { [INFO] [stderr] 30 | | &mut SlowRMBA::RefMut(ref mut t) => Some(t), [INFO] [stderr] 31 | | &mut SlowRMBA::Box(ref mut t) => Some(t), [INFO] [stderr] 32 | | &mut SlowRMBA::Arc(ref mut t) => Arc::get_mut(t), [INFO] [stderr] 33 | | _ => None, [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | match *self { [INFO] [stderr] 30 | SlowRMBA::RefMut(ref mut t) => Some(t), [INFO] [stderr] 31 | SlowRMBA::Box(ref mut t) => Some(t), [INFO] [stderr] 32 | SlowRMBA::Arc(ref mut t) => Arc::get_mut(t), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rmba.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / match self { [INFO] [stderr] 44 | | &SlowRMBA::Ref(ref t) => t, [INFO] [stderr] 45 | | &SlowRMBA::RefMut(ref t) => t, [INFO] [stderr] 46 | | &SlowRMBA::Box(ref t) => t, [INFO] [stderr] 47 | | &SlowRMBA::Arc(ref t) => t, [INFO] [stderr] 48 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | match *self { [INFO] [stderr] 44 | SlowRMBA::Ref(ref t) => t, [INFO] [stderr] 45 | SlowRMBA::RefMut(ref t) => t, [INFO] [stderr] 46 | SlowRMBA::Box(ref t) => t, [INFO] [stderr] 47 | SlowRMBA::Arc(ref t) => t, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rmba.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | *f = *f & (!3); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `*f &= (!3)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/rmba.rs:100:21 [INFO] [stderr] | [INFO] [stderr] 100 | assert!(*f & 3 == 0); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `(*f).trailing_zeros() >= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rmba.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | *f = *f + add; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `*f += add` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rmba.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | *f = *f - 2*mem::size_of::(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*f -= 2*mem::size_of::()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/rmba.rs:223:5 [INFO] [stderr] | [INFO] [stderr] 223 | fn ne(&self, other: &Self) -> bool { **self != **other } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rc_bitmask.rs:66:69 [INFO] [stderr] | [INFO] [stderr] 66 | fn set_state(&mut self, v: u8) { *self = (*self & !3) | ((v & 3) as $t); } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(v & 3)` [INFO] [stderr] ... [INFO] [stderr] 182 | rc_bit_mask_internal!(primitive, u16, 5, 4, 5); [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/rc_bitmask.rs:66:69 [INFO] [stderr] | [INFO] [stderr] 66 | fn set_state(&mut self, v: u8) { *self = (*self & !3) | ((v & 3) as $t); } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(v & 3)` [INFO] [stderr] ... [INFO] [stderr] 185 | rc_bit_mask_internal!(primitive, u32, 10, 10, 10); [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rc_bitmask.rs:66:69 [INFO] [stderr] | [INFO] [stderr] 66 | fn set_state(&mut self, v: u8) { *self = (*self & !3) | ((v & 3) as $t); } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(v & 3)` [INFO] [stderr] ... [INFO] [stderr] 191 | rc_bit_mask_internal!(primitive, u64, 21, 20, 21); [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u128 may become silently lossy if types change [INFO] [stderr] --> src/rc_bitmask.rs:66:69 [INFO] [stderr] | [INFO] [stderr] 66 | fn set_state(&mut self, v: u8) { *self = (*self & !3) | ((v & 3) as $t); } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u128::from(v & 3)` [INFO] [stderr] ... [INFO] [stderr] 194 | rc_bit_mask_internal!(primitive, u128, 42, 42, 42); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rc.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | / pub fn try_get<'a>(&'a self) -> Result, State> { [INFO] [stderr] 195 | | let s = self.state(); [INFO] [stderr] 196 | | if s != State::Available && s != State::Borrowed { return Err(s); } [INFO] [stderr] 197 | | [INFO] [stderr] ... | [INFO] [stderr] 202 | | Ok(RCellRef(self)) [INFO] [stderr] 203 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rc.rs:205:5 [INFO] [stderr] | [INFO] [stderr] 205 | / pub fn try_get_mut<'a>(&'a self) -> Result, State> { [INFO] [stderr] 206 | | let s = self.state(); [INFO] [stderr] 207 | | if s != State::Available { return Err(s); } [INFO] [stderr] 208 | | self.set_state(State::BorrowedMut); [INFO] [stderr] 209 | | Ok(RCellRefMut(self)) [INFO] [stderr] 210 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/rc.rs:321:46 [INFO] [stderr] | [INFO] [stderr] 321 | unsafe { slice::from_raw_parts_mut((*s).data.as_mut_ptr(), (*s).len as usize) } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/rc.rs:321:70 [INFO] [stderr] | [INFO] [stderr] 321 | unsafe { slice::from_raw_parts_mut((*s).data.as_mut_ptr(), (*s).len as usize) } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/rc.rs:333:56 [INFO] [stderr] | [INFO] [stderr] 333 | let u: *mut [u8] = slice::from_raw_parts_mut((*s).data.as_mut_ptr(), (*s).len as usize); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/rc.rs:333:80 [INFO] [stderr] | [INFO] [stderr] 333 | let u: *mut [u8] = slice::from_raw_parts_mut((*s).data.as_mut_ptr(), (*s).len as usize); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/rc.rs:379:28 [INFO] [stderr] | [INFO] [stderr] 379 | ptr::write(p.offset(idx as isize), item) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `p.add(idx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/rc_macros.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | fn ne(&self, other: &Self) -> bool { **self != **other } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/rc.rs:535:1 [INFO] [stderr] | [INFO] [stderr] 535 | impl_deref_and_friends!(Ref, BitMask); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/rc_macros.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | fn ne(&self, other: &Self) -> bool { **self != **other } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/rc.rs:564:1 [INFO] [stderr] | [INFO] [stderr] 564 | impl_deref_and_friends!(RefMut, BitMask); [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/arc.rs:137:57 [INFO] [stderr] | [INFO] [stderr] 137 | if let Err(e) = m.inc(BM_REF) { return (Err(e.into()), None); } [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/arc.rs:146:60 [INFO] [stderr] | [INFO] [stderr] 146 | if let Err(e) = m.inc(BM_STRONG) { return (Err(e.into()), None); } [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/arc.rs:153:58 [INFO] [stderr] | [INFO] [stderr] 153 | if let Err(e) = m.inc(BM_WEAK) { return (Err(e.into()), None); } [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/arc.rs:251:28 [INFO] [stderr] | [INFO] [stderr] 251 | ptr::write(p.offset(idx as isize), item) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `p.add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/rc_macros.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | fn ne(&self, other: &Self) -> bool { **self != **other } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/arc.rs:269:1 [INFO] [stderr] | [INFO] [stderr] 269 | impl_deref_and_friends!(RefMut, BitMask); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/rc_macros.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | fn ne(&self, other: &Self) -> bool { **self != **other } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/arc.rs:298:1 [INFO] [stderr] | [INFO] [stderr] 298 | impl_deref_and_friends!(Ref, BitMask); [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `reffers`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/aref.rs:295:5 [INFO] [stderr] | [INFO] [stderr] 295 | fn ne(&self, other: &Self) -> bool { **self != **other } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/aref.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | fn ne(&self, other: &Self) -> bool { self.0.ne(&other.0) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/aref.rs:309:5 [INFO] [stderr] | [INFO] [stderr] 309 | fn ne(&self, other: &Self) -> bool { self.0.ne(&other.0) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/aref.rs:531:31 [INFO] [stderr] | [INFO] [stderr] 531 | self.0.try_map(f).map(|z| ARefs(z)) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `ARefs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/aref.rs:579:31 [INFO] [stderr] | [INFO] [stderr] 579 | self.0.try_map(f).map(|z| ARefss(z)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `ARefss` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/aref.rs:653:29 [INFO] [stderr] | [INFO] [stderr] 653 | verify_areffic(Box::new(arr.clone())).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `arr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/aref.rs:654:28 [INFO] [stderr] | [INFO] [stderr] 654 | verify_areffic(Rc::new(arr.clone())).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `arr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/aref.rs:655:29 [INFO] [stderr] | [INFO] [stderr] 655 | verify_areffic(Arc::new(arr.clone())).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `arr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/aref.rs:656:28 [INFO] [stderr] | [INFO] [stderr] 656 | verify_areffic(Bx::new(arr.clone())).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `arr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/aref.rs:657:29 [INFO] [stderr] | [INFO] [stderr] 657 | verify_areffic(Bxm::new(arr.clone())).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `arr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/aref.rs:658:40 [INFO] [stderr] | [INFO] [stderr] 658 | verify_areffic(RMBA::from(Arc::new(arr.clone()))).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `arr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/aref.rs:662:26 [INFO] [stderr] | [INFO] [stderr] 662 | let r = RefCell::new(arr.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `arr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/aref.rs:665:25 [INFO] [stderr] | [INFO] [stderr] 665 | let r = RwLock::new(arr.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `arr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/aref.rs:668:24 [INFO] [stderr] | [INFO] [stderr] 668 | let m = Mutex::new(arr.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `arr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/aref.rs:670:43 [INFO] [stderr] | [INFO] [stderr] 670 | verify_areffic(rc::Ref::<_, u32>::new(arr.clone())).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `arr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/aref.rs:671:46 [INFO] [stderr] | [INFO] [stderr] 671 | verify_areffic(rc::RefMut::<_, u32>::new(arr.clone())).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `arr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rmba.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / match self { [INFO] [stderr] 21 | | &SlowRMBA::Ref(ref t) => Some(SlowRMBA::Ref(t)), [INFO] [stderr] 22 | | &SlowRMBA::Arc(ref t) => Some(SlowRMBA::Arc(t.clone())), [INFO] [stderr] 23 | | _ => None, [INFO] [stderr] 24 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 20 | match *self { [INFO] [stderr] 21 | SlowRMBA::Ref(ref t) => Some(SlowRMBA::Ref(t)), [INFO] [stderr] 22 | SlowRMBA::Arc(ref t) => Some(SlowRMBA::Arc(t.clone())), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rmba.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / match self { [INFO] [stderr] 30 | | &mut SlowRMBA::RefMut(ref mut t) => Some(t), [INFO] [stderr] 31 | | &mut SlowRMBA::Box(ref mut t) => Some(t), [INFO] [stderr] 32 | | &mut SlowRMBA::Arc(ref mut t) => Arc::get_mut(t), [INFO] [stderr] 33 | | _ => None, [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | match *self { [INFO] [stderr] 30 | SlowRMBA::RefMut(ref mut t) => Some(t), [INFO] [stderr] 31 | SlowRMBA::Box(ref mut t) => Some(t), [INFO] [stderr] 32 | SlowRMBA::Arc(ref mut t) => Arc::get_mut(t), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rmba.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / match self { [INFO] [stderr] 44 | | &SlowRMBA::Ref(ref t) => t, [INFO] [stderr] 45 | | &SlowRMBA::RefMut(ref t) => t, [INFO] [stderr] 46 | | &SlowRMBA::Box(ref t) => t, [INFO] [stderr] 47 | | &SlowRMBA::Arc(ref t) => t, [INFO] [stderr] 48 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | match *self { [INFO] [stderr] 44 | SlowRMBA::Ref(ref t) => t, [INFO] [stderr] 45 | SlowRMBA::RefMut(ref t) => t, [INFO] [stderr] 46 | SlowRMBA::Box(ref t) => t, [INFO] [stderr] 47 | SlowRMBA::Arc(ref t) => t, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rmba.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | *f = *f & (!3); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `*f &= (!3)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/rmba.rs:100:21 [INFO] [stderr] | [INFO] [stderr] 100 | assert!(*f & 3 == 0); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `(*f).trailing_zeros() >= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rmba.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | *f = *f + add; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `*f += add` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rmba.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | *f = *f - 2*mem::size_of::(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*f -= 2*mem::size_of::()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/rmba.rs:223:5 [INFO] [stderr] | [INFO] [stderr] 223 | fn ne(&self, other: &Self) -> bool { **self != **other } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/rmba.rs:250:48 [INFO] [stderr] | [INFO] [stderr] 250 | impl Dummy for u8 { fn foo(&self) -> i32 { *self as i32 } } [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(*self)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rc_bitmask.rs:66:69 [INFO] [stderr] | [INFO] [stderr] 66 | fn set_state(&mut self, v: u8) { *self = (*self & !3) | ((v & 3) as $t); } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(v & 3)` [INFO] [stderr] ... [INFO] [stderr] 182 | rc_bit_mask_internal!(primitive, u16, 5, 4, 5); [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/rc_bitmask.rs:66:69 [INFO] [stderr] | [INFO] [stderr] 66 | fn set_state(&mut self, v: u8) { *self = (*self & !3) | ((v & 3) as $t); } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(v & 3)` [INFO] [stderr] ... [INFO] [stderr] 185 | rc_bit_mask_internal!(primitive, u32, 10, 10, 10); [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rc_bitmask.rs:66:69 [INFO] [stderr] | [INFO] [stderr] 66 | fn set_state(&mut self, v: u8) { *self = (*self & !3) | ((v & 3) as $t); } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(v & 3)` [INFO] [stderr] ... [INFO] [stderr] 191 | rc_bit_mask_internal!(primitive, u64, 21, 20, 21); [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u128 may become silently lossy if types change [INFO] [stderr] --> src/rc_bitmask.rs:66:69 [INFO] [stderr] | [INFO] [stderr] 66 | fn set_state(&mut self, v: u8) { *self = (*self & !3) | ((v & 3) as $t); } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u128::from(v & 3)` [INFO] [stderr] ... [INFO] [stderr] 194 | rc_bit_mask_internal!(primitive, u128, 42, 42, 42); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rc.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | / pub fn try_get<'a>(&'a self) -> Result, State> { [INFO] [stderr] 195 | | let s = self.state(); [INFO] [stderr] 196 | | if s != State::Available && s != State::Borrowed { return Err(s); } [INFO] [stderr] 197 | | [INFO] [stderr] ... | [INFO] [stderr] 202 | | Ok(RCellRef(self)) [INFO] [stderr] 203 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rc.rs:205:5 [INFO] [stderr] | [INFO] [stderr] 205 | / pub fn try_get_mut<'a>(&'a self) -> Result, State> { [INFO] [stderr] 206 | | let s = self.state(); [INFO] [stderr] 207 | | if s != State::Available { return Err(s); } [INFO] [stderr] 208 | | self.set_state(State::BorrowedMut); [INFO] [stderr] 209 | | Ok(RCellRefMut(self)) [INFO] [stderr] 210 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/rc.rs:321:46 [INFO] [stderr] | [INFO] [stderr] 321 | unsafe { slice::from_raw_parts_mut((*s).data.as_mut_ptr(), (*s).len as usize) } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/rc.rs:321:70 [INFO] [stderr] | [INFO] [stderr] 321 | unsafe { slice::from_raw_parts_mut((*s).data.as_mut_ptr(), (*s).len as usize) } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/rc.rs:333:56 [INFO] [stderr] | [INFO] [stderr] 333 | let u: *mut [u8] = slice::from_raw_parts_mut((*s).data.as_mut_ptr(), (*s).len as usize); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/rc.rs:333:80 [INFO] [stderr] | [INFO] [stderr] 333 | let u: *mut [u8] = slice::from_raw_parts_mut((*s).data.as_mut_ptr(), (*s).len as usize); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/rc.rs:379:28 [INFO] [stderr] | [INFO] [stderr] 379 | ptr::write(p.offset(idx as isize), item) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `p.add(idx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/rc_macros.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | fn ne(&self, other: &Self) -> bool { **self != **other } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/rc.rs:535:1 [INFO] [stderr] | [INFO] [stderr] 535 | impl_deref_and_friends!(Ref, BitMask); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/rc_macros.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | fn ne(&self, other: &Self) -> bool { **self != **other } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/rc.rs:564:1 [INFO] [stderr] | [INFO] [stderr] 564 | impl_deref_and_friends!(RefMut, BitMask); [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/arc.rs:137:57 [INFO] [stderr] | [INFO] [stderr] 137 | if let Err(e) = m.inc(BM_REF) { return (Err(e.into()), None); } [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/arc.rs:146:60 [INFO] [stderr] | [INFO] [stderr] 146 | if let Err(e) = m.inc(BM_STRONG) { return (Err(e.into()), None); } [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/arc.rs:153:58 [INFO] [stderr] | [INFO] [stderr] 153 | if let Err(e) = m.inc(BM_WEAK) { return (Err(e.into()), None); } [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/arc.rs:251:28 [INFO] [stderr] | [INFO] [stderr] 251 | ptr::write(p.offset(idx as isize), item) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `p.add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/rc_macros.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | fn ne(&self, other: &Self) -> bool { **self != **other } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/arc.rs:269:1 [INFO] [stderr] | [INFO] [stderr] 269 | impl_deref_and_friends!(RefMut, BitMask); [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/rc_macros.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | fn ne(&self, other: &Self) -> bool { **self != **other } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/arc.rs:298:1 [INFO] [stderr] | [INFO] [stderr] 298 | impl_deref_and_friends!(Ref, BitMask); [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `reffers`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "36a6750daa7148a9feb94f05ed421896041ce10ee31f26daeab9d9fdf70b3ebf"` [INFO] running `"docker" "rm" "-f" "36a6750daa7148a9feb94f05ed421896041ce10ee31f26daeab9d9fdf70b3ebf"` [INFO] [stdout] 36a6750daa7148a9feb94f05ed421896041ce10ee31f26daeab9d9fdf70b3ebf