[INFO] crate ref_thread_local 0.0.0 is already in cache [INFO] extracting crate ref_thread_local 0.0.0 into work/ex/clippy-test-run/sources/stable/reg/ref_thread_local/0.0.0 [INFO] extracting crate ref_thread_local 0.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ref_thread_local/0.0.0 [INFO] validating manifest of ref_thread_local-0.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ref_thread_local-0.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ref_thread_local-0.0.0 [INFO] finished frobbing ref_thread_local-0.0.0 [INFO] frobbed toml for ref_thread_local-0.0.0 written to work/ex/clippy-test-run/sources/stable/reg/ref_thread_local/0.0.0/Cargo.toml [INFO] started frobbing ref_thread_local-0.0.0 [INFO] finished frobbing ref_thread_local-0.0.0 [INFO] frobbed toml for ref_thread_local-0.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ref_thread_local/0.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ref_thread_local-0.0.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ref_thread_local/0.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5e1087307749d954ebb70be82552dea86873a18e04f6f41c1cdf407f7d867871 [INFO] running `"docker" "start" "-a" "5e1087307749d954ebb70be82552dea86873a18e04f6f41c1cdf407f7d867871"` [INFO] [stderr] Checking ref_thread_local v0.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/refmanager.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / return Self { [INFO] [stderr] 29 | | ptr_inner_data: self.ptr_inner_data, [INFO] [stderr] 30 | | ptr_borrow_count: self.ptr_borrow_count, [INFO] [stderr] 31 | | ptr_value: self.ptr_value, [INFO] [stderr] 32 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 28 | Self { [INFO] [stderr] 29 | ptr_inner_data: self.ptr_inner_data, [INFO] [stderr] 30 | ptr_borrow_count: self.ptr_borrow_count, [INFO] [stderr] 31 | ptr_value: self.ptr_value, [INFO] [stderr] 32 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/refmanager.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / return Self { [INFO] [stderr] 29 | | ptr_inner_data: self.ptr_inner_data, [INFO] [stderr] 30 | | ptr_borrow_count: self.ptr_borrow_count, [INFO] [stderr] 31 | | ptr_value: self.ptr_value, [INFO] [stderr] 32 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 28 | Self { [INFO] [stderr] 29 | ptr_inner_data: self.ptr_inner_data, [INFO] [stderr] 30 | ptr_borrow_count: self.ptr_borrow_count, [INFO] [stderr] 31 | ptr_value: self.ptr_value, [INFO] [stderr] 32 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/refmanager.rs:208:3 [INFO] [stderr] | [INFO] [stderr] 208 | / pub const INIT_SELF: Self = RefManagerDataGuard { [INFO] [stderr] 209 | | peek_data: Cell::new(Self::INIT_PEEK_DATA), [INFO] [stderr] 210 | | }; [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::declare_interior_mutable_const)] on by default [INFO] [stderr] help: consider requiring `refmanager::RefManagerDataGuard` to be `Copy` [INFO] [stderr] --> src/refmanager.rs:208:24 [INFO] [stderr] | [INFO] [stderr] 208 | pub const INIT_SELF: Self = RefManagerDataGuard { [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `ref_thread_local`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/refmanager.rs:208:3 [INFO] [stderr] | [INFO] [stderr] 208 | / pub const INIT_SELF: Self = RefManagerDataGuard { [INFO] [stderr] 209 | | peek_data: Cell::new(Self::INIT_PEEK_DATA), [INFO] [stderr] 210 | | }; [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::declare_interior_mutable_const)] on by default [INFO] [stderr] help: consider requiring `refmanager::RefManagerDataGuard` to be `Copy` [INFO] [stderr] --> src/refmanager.rs:208:24 [INFO] [stderr] | [INFO] [stderr] 208 | pub const INIT_SELF: Self = RefManagerDataGuard { [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `ref_thread_local`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5e1087307749d954ebb70be82552dea86873a18e04f6f41c1cdf407f7d867871"` [INFO] running `"docker" "rm" "-f" "5e1087307749d954ebb70be82552dea86873a18e04f6f41c1cdf407f7d867871"` [INFO] [stdout] 5e1087307749d954ebb70be82552dea86873a18e04f6f41c1cdf407f7d867871