[INFO] crate recycler 0.1.4 is already in cache [INFO] extracting crate recycler 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/recycler/0.1.4 [INFO] extracting crate recycler 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/recycler/0.1.4 [INFO] validating manifest of recycler-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of recycler-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing recycler-0.1.4 [INFO] finished frobbing recycler-0.1.4 [INFO] frobbed toml for recycler-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/recycler/0.1.4/Cargo.toml [INFO] started frobbing recycler-0.1.4 [INFO] finished frobbing recycler-0.1.4 [INFO] frobbed toml for recycler-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/recycler/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting recycler-0.1.4 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/recycler/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 209ecea1e16d19dcde72dfc73affbeaed37a3a99f107c70a7c08d79c2cce599c [INFO] running `"docker" "start" "-a" "209ecea1e16d19dcde72dfc73affbeaed37a3a99f107c70a7c08d79c2cce599c"` [INFO] [stderr] Checking recycler v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: methods called `new` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:126:26 [INFO] [stderr] | [INFO] [stderr] 126 | #[inline] pub fn new(&mut self) -> String { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lib.rs:126:15 [INFO] [stderr] | [INFO] [stderr] 126 | #[inline] pub fn new(&mut self) -> String { [INFO] [stderr] | _______________^ [INFO] [stderr] 127 | | self.stash.pop().unwrap_or(String::new()) [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | self.stash.pop().unwrap_or(String::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.stash.pop().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:152:23 [INFO] [stderr] | [INFO] [stderr] 152 | let mut vec = self.stash.pop().unwrap_or(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.stash.pop().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:161:26 [INFO] [stderr] | [INFO] [stderr] 161 | #[inline] pub fn new(&mut self) -> (Vec, &mut R) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lib.rs:161:15 [INFO] [stderr] | [INFO] [stderr] 161 | #[inline] pub fn new(&mut self) -> (Vec, &mut R) { [INFO] [stderr] | _______________^ [INFO] [stderr] 162 | | (self.stash.pop().unwrap_or(Vec::new()), &mut self.recycler) [INFO] [stderr] 163 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:162:10 [INFO] [stderr] | [INFO] [stderr] 162 | (self.stash.pop().unwrap_or(Vec::new()), &mut self.recycler) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.stash.pop().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | / if let &Some(ref thing) = other { [INFO] [stderr] 190 | | Some(self.recycler.recreate(thing)) [INFO] [stderr] 191 | | } [INFO] [stderr] 192 | | else { None } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 189 | if let Some(ref thing) = *other { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:126:26 [INFO] [stderr] | [INFO] [stderr] 126 | #[inline] pub fn new(&mut self) -> String { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lib.rs:126:15 [INFO] [stderr] | [INFO] [stderr] 126 | #[inline] pub fn new(&mut self) -> String { [INFO] [stderr] | _______________^ [INFO] [stderr] 127 | | self.stash.pop().unwrap_or(String::new()) [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | self.stash.pop().unwrap_or(String::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.stash.pop().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:152:23 [INFO] [stderr] | [INFO] [stderr] 152 | let mut vec = self.stash.pop().unwrap_or(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.stash.pop().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:161:26 [INFO] [stderr] | [INFO] [stderr] 161 | #[inline] pub fn new(&mut self) -> (Vec, &mut R) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lib.rs:161:15 [INFO] [stderr] | [INFO] [stderr] 161 | #[inline] pub fn new(&mut self) -> (Vec, &mut R) { [INFO] [stderr] | _______________^ [INFO] [stderr] 162 | | (self.stash.pop().unwrap_or(Vec::new()), &mut self.recycler) [INFO] [stderr] 163 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:162:10 [INFO] [stderr] | [INFO] [stderr] 162 | (self.stash.pop().unwrap_or(Vec::new()), &mut self.recycler) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.stash.pop().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | / if let &Some(ref thing) = other { [INFO] [stderr] 190 | | Some(self.recycler.recreate(thing)) [INFO] [stderr] 191 | | } [INFO] [stderr] 192 | | else { None } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 189 | if let Some(ref thing) = *other { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/benches.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `recycler`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "209ecea1e16d19dcde72dfc73affbeaed37a3a99f107c70a7c08d79c2cce599c"` [INFO] running `"docker" "rm" "-f" "209ecea1e16d19dcde72dfc73affbeaed37a3a99f107c70a7c08d79c2cce599c"` [INFO] [stdout] 209ecea1e16d19dcde72dfc73affbeaed37a3a99f107c70a7c08d79c2cce599c