[INFO] crate recital 0.3.0 is already in cache [INFO] extracting crate recital 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/recital/0.3.0 [INFO] extracting crate recital 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/recital/0.3.0 [INFO] validating manifest of recital-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of recital-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing recital-0.3.0 [INFO] finished frobbing recital-0.3.0 [INFO] frobbed toml for recital-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/recital/0.3.0/Cargo.toml [INFO] started frobbing recital-0.3.0 [INFO] finished frobbing recital-0.3.0 [INFO] frobbed toml for recital-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/recital/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting recital-0.3.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/recital/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ff2c7ee2175545ac10d5cc58e861c3f2016d6dbd3af4351e6e188b14045b71fc [INFO] running `"docker" "start" "-a" "ff2c7ee2175545ac10d5cc58e861c3f2016d6dbd3af4351e6e188b14045b71fc"` [INFO] [stderr] Checking recital v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused imports: `Alpha`, `Number` [INFO] [stderr] --> src/version.rs:32:24 [INFO] [stderr] | [INFO] [stderr] 32 | use self::Identifier::{Alpha, Number}; [INFO] [stderr] | ^^^^^ ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Alpha`, `Number` [INFO] [stderr] --> src/version.rs:32:24 [INFO] [stderr] | [INFO] [stderr] 32 | use self::Identifier::{Alpha, Number}; [INFO] [stderr] | ^^^^^ ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/version.rs:97:36 [INFO] [stderr] | [INFO] [stderr] 97 | Identifier::Number(n as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 109 | from_n!(u8); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/version.rs:97:36 [INFO] [stderr] | [INFO] [stderr] 97 | Identifier::Number(n as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 110 | from_n!(u16); [INFO] [stderr] | ------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/version.rs:97:36 [INFO] [stderr] | [INFO] [stderr] 97 | Identifier::Number(n as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 111 | from_n!(u32); [INFO] [stderr] | ------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/version.rs:97:36 [INFO] [stderr] | [INFO] [stderr] 97 | Identifier::Number(n as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 109 | from_n!(u8); [INFO] [stderr] | ------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/version.rs:97:36 [INFO] [stderr] | [INFO] [stderr] 97 | Identifier::Number(n as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 110 | from_n!(u16); [INFO] [stderr] | ------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/version.rs:97:36 [INFO] [stderr] | [INFO] [stderr] 97 | Identifier::Number(n as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 111 | from_n!(u32); [INFO] [stderr] | ------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/parser.rs:106:22 [INFO] [stderr] | [INFO] [stderr] 106 | pre: extensions.0.clone().unwrap_or(Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `extensions.0.clone().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/parser.rs:107:24 [INFO] [stderr] | [INFO] [stderr] 107 | build: extensions.1.clone().unwrap_or(Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `extensions.1.clone().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | / match version(s.as_bytes()) { [INFO] [stderr] 124 | | IResult::Done(remainder, version) => { [INFO] [stderr] 125 | | if 0 == remainder.len() { [INFO] [stderr] 126 | | return Ok(version); [INFO] [stderr] ... | [INFO] [stderr] 130 | | _ => {} [INFO] [stderr] 131 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 123 | if let IResult::Done(remainder, version) = version(s.as_bytes()) { [INFO] [stderr] 124 | if 0 == remainder.len() { [INFO] [stderr] 125 | return Ok(version); [INFO] [stderr] 126 | } [INFO] [stderr] 127 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:125:20 [INFO] [stderr] | [INFO] [stderr] 125 | if 0 == remainder.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `remainder.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/resolve.rs:257:26 [INFO] [stderr] | [INFO] [stderr] 257 | pub fn resolve(versions: &Vec, constraints: &Constraints) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Version]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/parser.rs:106:22 [INFO] [stderr] | [INFO] [stderr] 106 | pre: extensions.0.clone().unwrap_or(Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `extensions.0.clone().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/parser.rs:107:24 [INFO] [stderr] | [INFO] [stderr] 107 | build: extensions.1.clone().unwrap_or(Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `extensions.1.clone().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | / match version(s.as_bytes()) { [INFO] [stderr] 124 | | IResult::Done(remainder, version) => { [INFO] [stderr] 125 | | if 0 == remainder.len() { [INFO] [stderr] 126 | | return Ok(version); [INFO] [stderr] ... | [INFO] [stderr] 130 | | _ => {} [INFO] [stderr] 131 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 123 | if let IResult::Done(remainder, version) = version(s.as_bytes()) { [INFO] [stderr] 124 | if 0 == remainder.len() { [INFO] [stderr] 125 | return Ok(version); [INFO] [stderr] 126 | } [INFO] [stderr] 127 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:125:20 [INFO] [stderr] | [INFO] [stderr] 125 | if 0 == remainder.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `remainder.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/resolve.rs:257:26 [INFO] [stderr] | [INFO] [stderr] 257 | pub fn resolve(versions: &Vec, constraints: &Constraints) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Version]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.55s [INFO] running `"docker" "inspect" "ff2c7ee2175545ac10d5cc58e861c3f2016d6dbd3af4351e6e188b14045b71fc"` [INFO] running `"docker" "rm" "-f" "ff2c7ee2175545ac10d5cc58e861c3f2016d6dbd3af4351e6e188b14045b71fc"` [INFO] [stdout] ff2c7ee2175545ac10d5cc58e861c3f2016d6dbd3af4351e6e188b14045b71fc