[INFO] crate reader-writer 0.0.2 is already in cache
[INFO] extracting crate reader-writer 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/reader-writer/0.0.2
[INFO] extracting crate reader-writer 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reader-writer/0.0.2
[INFO] validating manifest of reader-writer-0.0.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of reader-writer-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing reader-writer-0.0.2
[INFO] finished frobbing reader-writer-0.0.2
[INFO] frobbed toml for reader-writer-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/reader-writer/0.0.2/Cargo.toml
[INFO] started frobbing reader-writer-0.0.2
[INFO] finished frobbing reader-writer-0.0.2
[INFO] frobbed toml for reader-writer-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reader-writer/0.0.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting reader-writer-0.0.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/reader-writer/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8639b6dff021481f2b73bb0a68c1147814e7447e5825e8ffb424b89a53022d9b
[INFO] running `"docker" "start" "-a" "8639b6dff021481f2b73bb0a68c1147814e7447e5825e8ffb424b89a53022d9b"`
[INFO] [stderr]     Checking reader-writer v0.0.2 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/reader.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |             read: read
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `read`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/reader.rs:77:21
[INFO] [stderr]    |
[INFO] [stderr] 77 |                 let e = (buf[4] as u64) << 24;
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/reader.rs:78:21
[INFO] [stderr]    |
[INFO] [stderr] 78 |                 let f = (buf[5] as u64) << 16;
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]   --> src/reader.rs:79:21
[INFO] [stderr]    |
[INFO] [stderr] 79 |                 let g = (buf[6] as u64) << 8;
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]   --> src/reader.rs:80:21
[INFO] [stderr]    |
[INFO] [stderr] 80 |                 let h = buf[7] as u64;
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/writer.rs:78:13
[INFO] [stderr]    |
[INFO] [stderr] 78 |             write: write
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `write`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/reader.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |             read: read
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `read`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/reader.rs:77:21
[INFO] [stderr]    |
[INFO] [stderr] 77 |                 let e = (buf[4] as u64) << 24;
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/reader.rs:78:21
[INFO] [stderr]    |
[INFO] [stderr] 78 |                 let f = (buf[5] as u64) << 16;
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]   --> src/reader.rs:79:21
[INFO] [stderr]    |
[INFO] [stderr] 79 |                 let g = (buf[6] as u64) << 8;
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]   --> src/reader.rs:80:21
[INFO] [stderr]    |
[INFO] [stderr] 80 |                 let h = buf[7] as u64;
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/writer.rs:78:13
[INFO] [stderr]    |
[INFO] [stderr] 78 |             write: write
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `write`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/reader.rs:32:17
[INFO] [stderr]    |
[INFO] [stderr] 32 |                 return Err(err)
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(err)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/reader.rs:112:9
[INFO] [stderr]     |
[INFO] [stderr] 112 |         return Ok(Some(s))
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(s))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/writer.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         return self.count
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.count`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/reader.rs:32:17
[INFO] [stderr]    |
[INFO] [stderr] 32 |                 return Err(err)
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(err)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/reader.rs:112:9
[INFO] [stderr]     |
[INFO] [stderr] 112 |         return Ok(Some(s))
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(s))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/writer.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         return self.count
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.count`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:79:36
[INFO] [stderr]    |
[INFO] [stderr] 79 |             check(writer.write_u32(0xabcdef01));
[INFO] [stderr]    |                                    ^^^^^^^^^^ help: consider: `0xabcd_ef01`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:80:36
[INFO] [stderr]    |
[INFO] [stderr] 80 |             check(writer.write_u64(0xabcdef0102030405));
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^ help: consider: `0xabcd_ef01_0203_0405`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:88:56
[INFO] [stderr]    |
[INFO] [stderr] 88 |         assert!(reader.read_u32().unwrap().unwrap() == 0xabcdef01);
[INFO] [stderr]    |                                                        ^^^^^^^^^^ help: consider: `0xabcd_ef01`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:89:56
[INFO] [stderr]    |
[INFO] [stderr] 89 |         assert!(reader.read_u64().unwrap().unwrap() == 0xabcdef0102030405);
[INFO] [stderr]    |                                                        ^^^^^^^^^^^^^^^^^^ help: consider: `0xabcd_ef01_0203_0405`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:41:25
[INFO] [stderr]    |
[INFO] [stderr] 41 |                 let a = (buf[0] as u16) << 8;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:42:25
[INFO] [stderr]    |
[INFO] [stderr] 42 |                 let b = buf[1] as u16;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^ help: try: `u16::from(buf[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:56:25
[INFO] [stderr]    |
[INFO] [stderr] 56 |                 let a = (buf[0] as u32) << 24;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:57:25
[INFO] [stderr]    |
[INFO] [stderr] 57 |                 let b = (buf[1] as u32) << 16;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:58:25
[INFO] [stderr]    |
[INFO] [stderr] 58 |                 let c = (buf[2] as u32) << 8;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:59:25
[INFO] [stderr]    |
[INFO] [stderr] 59 |                 let d = buf[3] as u32;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^ help: try: `u32::from(buf[3])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:73:25
[INFO] [stderr]    |
[INFO] [stderr] 73 |                 let a = (buf[0] as u64) << 56;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:74:25
[INFO] [stderr]    |
[INFO] [stderr] 74 |                 let b = (buf[1] as u64) << 48;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:75:25
[INFO] [stderr]    |
[INFO] [stderr] 75 |                 let c = (buf[2] as u64) << 40;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:76:25
[INFO] [stderr]    |
[INFO] [stderr] 76 |                 let d = (buf[3] as u64) << 32;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[3])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:77:25
[INFO] [stderr]    |
[INFO] [stderr] 77 |                 let e = (buf[4] as u64) << 24;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[4])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:78:25
[INFO] [stderr]    |
[INFO] [stderr] 78 |                 let f = (buf[5] as u64) << 16;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[5])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:79:25
[INFO] [stderr]    |
[INFO] [stderr] 79 |                 let g = (buf[6] as u64) << 8;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[6])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:80:25
[INFO] [stderr]    |
[INFO] [stderr] 80 |                 let h = buf[7] as u64;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^ help: try: `u64::from(buf[7])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/writer.rs:11:35
[INFO] [stderr]    |
[INFO] [stderr] 11 |     fn write_string(&mut self, v: &String) -> std::io::Result<()>;
[INFO] [stderr]    |                                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `writer::CountWriter`
[INFO] [stderr]   --> src/writer.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | /     pub fn new() -> CountWriter {
[INFO] [stderr] 20 | |         CountWriter {
[INFO] [stderr] 21 | |             count: 0
[INFO] [stderr] 22 | |         }
[INFO] [stderr] 23 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 14 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:41:25
[INFO] [stderr]    |
[INFO] [stderr] 41 |                 let a = (buf[0] as u16) << 8;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:42:25
[INFO] [stderr]    |
[INFO] [stderr] 42 |                 let b = buf[1] as u16;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^ help: try: `u16::from(buf[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:56:25
[INFO] [stderr]    |
[INFO] [stderr] 56 |                 let a = (buf[0] as u32) << 24;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:57:25
[INFO] [stderr]    |
[INFO] [stderr] 57 |                 let b = (buf[1] as u32) << 16;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:58:25
[INFO] [stderr]    |
[INFO] [stderr] 58 |                 let c = (buf[2] as u32) << 8;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:59:25
[INFO] [stderr]    |
[INFO] [stderr] 59 |                 let d = buf[3] as u32;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^ help: try: `u32::from(buf[3])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:73:25
[INFO] [stderr]    |
[INFO] [stderr] 73 |                 let a = (buf[0] as u64) << 56;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:74:25
[INFO] [stderr]    |
[INFO] [stderr] 74 |                 let b = (buf[1] as u64) << 48;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:75:25
[INFO] [stderr]    |
[INFO] [stderr] 75 |                 let c = (buf[2] as u64) << 40;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:76:25
[INFO] [stderr]    |
[INFO] [stderr] 76 |                 let d = (buf[3] as u64) << 32;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[3])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:77:25
[INFO] [stderr]    |
[INFO] [stderr] 77 |                 let e = (buf[4] as u64) << 24;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[4])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:78:25
[INFO] [stderr]    |
[INFO] [stderr] 78 |                 let f = (buf[5] as u64) << 16;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[5])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:79:25
[INFO] [stderr]    |
[INFO] [stderr] 79 |                 let g = (buf[6] as u64) << 8;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[6])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/reader.rs:80:25
[INFO] [stderr]    |
[INFO] [stderr] 80 |                 let h = buf[7] as u64;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^ help: try: `u64::from(buf[7])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/writer.rs:11:35
[INFO] [stderr]    |
[INFO] [stderr] 11 |     fn write_string(&mut self, v: &String) -> std::io::Result<()>;
[INFO] [stderr]    |                                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `writer::CountWriter`
[INFO] [stderr]   --> src/writer.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | /     pub fn new() -> CountWriter {
[INFO] [stderr] 20 | |         CountWriter {
[INFO] [stderr] 21 | |             count: 0
[INFO] [stderr] 22 | |         }
[INFO] [stderr] 23 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 14 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/lib.rs:106:39
[INFO] [stderr]     |
[INFO] [stderr] 106 |                 assert!(s.unwrap() == "Hello World".to_string());
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"Hello World"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.67s
[INFO] running `"docker" "inspect" "8639b6dff021481f2b73bb0a68c1147814e7447e5825e8ffb424b89a53022d9b"`
[INFO] running `"docker" "rm" "-f" "8639b6dff021481f2b73bb0a68c1147814e7447e5825e8ffb424b89a53022d9b"`
[INFO] [stdout] 8639b6dff021481f2b73bb0a68c1147814e7447e5825e8ffb424b89a53022d9b