[INFO] crate rcstring 0.2.1 is already in cache [INFO] extracting crate rcstring 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/rcstring/0.2.1 [INFO] extracting crate rcstring 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rcstring/0.2.1 [INFO] validating manifest of rcstring-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rcstring-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rcstring-0.2.1 [INFO] finished frobbing rcstring-0.2.1 [INFO] frobbed toml for rcstring-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/rcstring/0.2.1/Cargo.toml [INFO] started frobbing rcstring-0.2.1 [INFO] finished frobbing rcstring-0.2.1 [INFO] frobbed toml for rcstring-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rcstring/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rcstring-0.2.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rcstring/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d9f91610957542512d34196283caa2c85f399486d8f39a1e1042836a26aa8d1b [INFO] running `"docker" "start" "-a" "d9f91610957542512d34196283caa2c85f399486d8f39a1e1042836a26aa8d1b"` [INFO] [stderr] Checking rcstring v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:85:22 [INFO] [stderr] | [INFO] [stderr] 85 | if unsafe { *ptr.offset(ctr as isize) < 0 as c_char } { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(ctr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: item `CString<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:95:1 [INFO] [stderr] | [INFO] [stderr] 95 | / impl<'a> CString<'a> { [INFO] [stderr] 96 | | /// Constructs a new CString from a string slice [INFO] [stderr] 97 | | /// [INFO] [stderr] 98 | | /// The caller **MUST** ensure that there is a trailing NULL to terminate [INFO] [stderr] ... | [INFO] [stderr] 161 | | } [INFO] [stderr] 162 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:112:12 [INFO] [stderr] | [INFO] [stderr] 112 | if s.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:154:28 [INFO] [stderr] | [INFO] [stderr] 154 | pub unsafe fn into_raw(&self) -> *const c_char { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/lib.rs:173:5 [INFO] [stderr] | [INFO] [stderr] 173 | / fn ne(&self, other: &CString) -> bool { [INFO] [stderr] 174 | | ! self.eq(other) [INFO] [stderr] 175 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:85:22 [INFO] [stderr] | [INFO] [stderr] 85 | if unsafe { *ptr.offset(ctr as isize) < 0 as c_char } { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(ctr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: item `CString<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:95:1 [INFO] [stderr] | [INFO] [stderr] 95 | / impl<'a> CString<'a> { [INFO] [stderr] 96 | | /// Constructs a new CString from a string slice [INFO] [stderr] 97 | | /// [INFO] [stderr] 98 | | /// The caller **MUST** ensure that there is a trailing NULL to terminate [INFO] [stderr] ... | [INFO] [stderr] 161 | | } [INFO] [stderr] 162 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:112:12 [INFO] [stderr] | [INFO] [stderr] 112 | if s.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:154:28 [INFO] [stderr] | [INFO] [stderr] 154 | pub unsafe fn into_raw(&self) -> *const c_char { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/lib.rs:173:5 [INFO] [stderr] | [INFO] [stderr] 173 | / fn ne(&self, other: &CString) -> bool { [INFO] [stderr] 174 | | ! self.eq(other) [INFO] [stderr] 175 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.37s [INFO] running `"docker" "inspect" "d9f91610957542512d34196283caa2c85f399486d8f39a1e1042836a26aa8d1b"` [INFO] running `"docker" "rm" "-f" "d9f91610957542512d34196283caa2c85f399486d8f39a1e1042836a26aa8d1b"` [INFO] [stdout] d9f91610957542512d34196283caa2c85f399486d8f39a1e1042836a26aa8d1b