[INFO] crate random 0.12.2 is already in cache [INFO] extracting crate random 0.12.2 into work/ex/clippy-test-run/sources/stable/reg/random/0.12.2 [INFO] extracting crate random 0.12.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/random/0.12.2 [INFO] validating manifest of random-0.12.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of random-0.12.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing random-0.12.2 [INFO] finished frobbing random-0.12.2 [INFO] frobbed toml for random-0.12.2 written to work/ex/clippy-test-run/sources/stable/reg/random/0.12.2/Cargo.toml [INFO] started frobbing random-0.12.2 [INFO] finished frobbing random-0.12.2 [INFO] frobbed toml for random-0.12.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/random/0.12.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting random-0.12.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/random/0.12.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e26410d645c50fd377112150904a5238dd9f85e9804df1d0b69bb782f3b5ff03 [INFO] running `"docker" "start" "-a" "e26410d645c50fd377112150904a5238dd9f85e9804df1d0b69bb782f3b5ff03"` [INFO] [stderr] Checking random v0.12.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sequence.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | Sequence { source: source, phantom: PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sequence.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | Sequence { source: source, phantom: PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/value.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | i32 => [948125133, -1432682055], [INFO] [stderr] | ^^^^^^^^^ help: consider: `948_125_133` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/value.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | i32 => [948125133, -1432682055], [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_432_682_055` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/value.rs:43:22 [INFO] [stderr] | [INFO] [stderr] 43 | i64 => [-6330235019914458621, -4877218639256617945], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `6_330_235_019_914_458_621` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/value.rs:43:44 [INFO] [stderr] | [INFO] [stderr] 43 | i64 => [-6330235019914458621, -4877218639256617945], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `4_877_218_639_256_617_945` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `default::Default` [INFO] [stderr] --> src/default.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Default { [INFO] [stderr] 19 | | thread_local!(static DEFAULT: Rc> = { [INFO] [stderr] 20 | | Rc::new(RefCell::new(Xorshift128Plus::new([42, 69]))) [INFO] [stderr] 21 | | }); [INFO] [stderr] 22 | | Default(DEFAULT.with(|source| source.clone())) [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for default::Default { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/source.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / fn iter<'l, V>(&'l mut self) -> Sequence<'l, Self, V> where Self: Sized, V: Value { [INFO] [stderr] 23 | | From::from(self) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `default::Default` [INFO] [stderr] --> src/default.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Default { [INFO] [stderr] 19 | | thread_local!(static DEFAULT: Rc> = { [INFO] [stderr] 20 | | Rc::new(RefCell::new(Xorshift128Plus::new([42, 69]))) [INFO] [stderr] 21 | | }); [INFO] [stderr] 22 | | Default(DEFAULT.with(|source| source.clone())) [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for default::Default { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/source.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / fn iter<'l, V>(&'l mut self) -> Sequence<'l, Self, V> where Self: Sized, V: Value { [INFO] [stderr] 23 | | From::from(self) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.68s [INFO] running `"docker" "inspect" "e26410d645c50fd377112150904a5238dd9f85e9804df1d0b69bb782f3b5ff03"` [INFO] running `"docker" "rm" "-f" "e26410d645c50fd377112150904a5238dd9f85e9804df1d0b69bb782f3b5ff03"` [INFO] [stdout] e26410d645c50fd377112150904a5238dd9f85e9804df1d0b69bb782f3b5ff03