[INFO] crate rand_num_gen 0.1.0 is already in cache [INFO] extracting crate rand_num_gen 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rand_num_gen/0.1.0 [INFO] extracting crate rand_num_gen 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rand_num_gen/0.1.0 [INFO] validating manifest of rand_num_gen-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rand_num_gen-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rand_num_gen-0.1.0 [INFO] finished frobbing rand_num_gen-0.1.0 [INFO] frobbed toml for rand_num_gen-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rand_num_gen/0.1.0/Cargo.toml [INFO] started frobbing rand_num_gen-0.1.0 [INFO] finished frobbing rand_num_gen-0.1.0 [INFO] frobbed toml for rand_num_gen-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rand_num_gen/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rand_num_gen-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rand_num_gen/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6d3a91d311a7a3770d3dace6951891cf1ef7212371c13725cd9792958e1da276 [INFO] running `"docker" "start" "-a" "6d3a91d311a7a3770d3dace6951891cf1ef7212371c13725cd9792958e1da276"` [INFO] [stderr] Compiling cc v1.0.28 [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Checking rand_num_gen v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/xorshift.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | let z = (a << 16) | (b >> 16); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/xorshift.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | let w = (b << 16) | (a >> 16); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/xorshift.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | let x = (a << 16) | (b >> 16); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/xorshift.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | let y = (b << 16) | (c >> 16); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/xorshift.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | let z = (c << 16) | (a >> 16); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/xorshift.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | let w = (b << 16) | (a >> 16); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/random_byte_iter.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | rng: rng, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rng` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/random_iter.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | rng: rng, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `libc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/xorshift.rs:18:33 [INFO] [stderr] | [INFO] [stderr] 18 | SeedableRng::from_seed([0x193a6754, 0xa8a7d469, 0x97830e05, 0x113ba7bb]) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x193a_6754` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/xorshift.rs:18:45 [INFO] [stderr] | [INFO] [stderr] 18 | SeedableRng::from_seed([0x193a6754, 0xa8a7d469, 0x97830e05, 0x113ba7bb]) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xa8a7_d469` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/xorshift.rs:18:57 [INFO] [stderr] | [INFO] [stderr] 18 | SeedableRng::from_seed([0x193a6754, 0xa8a7d469, 0x97830e05, 0x113ba7bb]) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x9783_0e05` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/xorshift.rs:18:69 [INFO] [stderr] | [INFO] [stderr] 18 | SeedableRng::from_seed([0x193a6754, 0xa8a7d469, 0x97830e05, 0x113ba7bb]) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x113b_a7bb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/random.rs:104:34 [INFO] [stderr] | [INFO] [stderr] 104 | fn random(_: &mut R) -> () { () } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/random.rs:104:42 [INFO] [stderr] | [INFO] [stderr] 104 | fn random(_: &mut R) -> () { () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng.rs:25:33 [INFO] [stderr] | [INFO] [stderr] 25 | const UPPER_MASK: u32 = 0x3F800000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3F80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng.rs:26:33 [INFO] [stderr] | [INFO] [stderr] 26 | const LOWER_MASK: u32 = 0x7FFFFF; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x007F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng.rs:34:33 [INFO] [stderr] | [INFO] [stderr] 34 | const UPPER_MASK: u64 = 0x3FF0000000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x3FF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rng.rs:35:33 [INFO] [stderr] | [INFO] [stderr] 35 | const LOWER_MASK: u64 = 0xFFFFFFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `0x000F_FFFF_FFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `cc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/random.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | / match char::from_u32(rng.next_u32() & CHAR_MASK) { [INFO] [stderr] 74 | | Some(c) => return c, [INFO] [stderr] 75 | | None => (), [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(c) = char::from_u32(rng.next_u32() & CHAR_MASK) { return c }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rng.rs:12:10 [INFO] [stderr] | [INFO] [stderr] 12 | ((self.next_u32() as u64) << 32) | (self.next_u32() as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.next_u32())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rng.rs:12:44 [INFO] [stderr] | [INFO] [stderr] 12 | ((self.next_u32() as u64) << 32) | (self.next_u32() as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.next_u32())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/rng.rs:29:36 [INFO] [stderr] | [INFO] [stderr] 29 | let result: f32 = unsafe { mem::transmute(tmp) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(tmp)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/rng.rs:38:36 [INFO] [stderr] | [INFO] [stderr] 38 | let result: f64 = unsafe { mem::transmute(tmp) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(tmp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rng.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / fn random_iter<'a, T>(&'a mut self) -> RandomIter<'a, T, Self> [INFO] [stderr] 52 | | where T: Random, [INFO] [stderr] 53 | | Self: Sized, [INFO] [stderr] 54 | | { [INFO] [stderr] 55 | | RandomIter::new(self) [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rng.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / fn random_byte_iter<'a>(&'a mut self) -> RandomByteIter<'a, Self> [INFO] [stderr] 60 | | where Self: Sized, [INFO] [stderr] 61 | | { [INFO] [stderr] 62 | | RandomByteIter::new(self) [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "6d3a91d311a7a3770d3dace6951891cf1ef7212371c13725cd9792958e1da276"` [INFO] running `"docker" "rm" "-f" "6d3a91d311a7a3770d3dace6951891cf1ef7212371c13725cd9792958e1da276"` [INFO] [stdout] 6d3a91d311a7a3770d3dace6951891cf1ef7212371c13725cd9792958e1da276